Page MenuHomePhabricator
Create Task
Maniphest T7045

Allow linters to be skipped
Open, NormalPublic
Actions

Description

Currently we have the ability to "skip" a unit test if, for example, you are missing a dependency locally. This is then reflected in the Differential UI which shows "SKIPPED" for that particular unit test.

We should extend this functionality to linters as well. This would allow diffs to be submitted without installing a bunch of externals needed for the linters configured for the project. This would probably involve tweaking a bunch of stuff:

  • The Differential UI should probably show a list of linters and their status (PASS / ERROR / WARNING / ADVICE / SKIP) instead of showing a list of lint messages.
  • We currently don't send this information from arc diff. We should extend the data that is transferred using the arc:lint key to include linter statuses.

There is some discussion in D10463.

Related Objects
Search...

Event Timeline

joshuaspence created this task.Jan 26 2015, 7:50 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Lint, Differential.
joshuaspence mentioned this in D10463: Improve handling for missing externals when linting.
joshuaspence added a subscriber: joshuaspence.
joshuaspence claimed this task.Feb 11 2015, 8:53 PM
joshuaspence triaged this task as Normal priority.
joshuaspence mentioned this in T7739: Redesign Lint/Unit properties .Apr 13 2015, 9:24 AM
johnny-bit added a subscriber: johnny-bit.Apr 13 2015, 9:35 AM
epriestley added a subtask: T8095: Let Harbormaster own Lint and Unit results.May 6 2015, 3:27 PM
cburroughs added a subscriber: cburroughs.May 6 2015, 6:57 PM
epriestley closed subtask T8095: Let Harbormaster own Lint and Unit results as Resolved.Jun 23 2015, 5:24 PM
epriestley mentioned this in D14298: External linters can now specify a version requirement..Oct 18 2015, 1:11 PM
epriestley added a subscriber: epriestley.Oct 18 2015, 1:16 PM

Just collecting some more related stuff here: D14298 adds a .arclint-configurable version requirement check, which currently executes as a side effect of getCacheVersion().

A better structure here is probably more like:

  • In ArcanistLintEngine, move the getRunnableLinters() call up (to before we do all the cache stuff).
  • Remove canRun(), which is only used by the XML linter. Replace this with a more general call which does availability checks.
  • Move internal binary availability checks, future internal binary version checks, and .arclint configured version checks here.

So we'd just get all of the version checks out of the way up front in a structured way.

revi added a subscriber: revi.Oct 26 2015, 11:57 AM
tycho.tatitscheff awarded a token.Oct 26 2015, 12:56 PM
tycho.tatitscheff added a subscriber: tycho.tatitscheff.
eadler added a subscriber: eadler.Feb 25 2016, 10:10 PM
Phabricator · Built by Phacility