Page MenuHomePhabricator

Counterexample header is incorrectly colored in email
Closed, ResolvedPublic

Description

T9592#140779 contains a counterexample, which renders correctly in the web UI bit uses yellow instead of red in the email notification:

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Mail, Remarkup.
joshuaspence added a subscriber: joshuaspence.

I think we always get that gap between the header and body in mail, too (even for non-counterexamples).

@epriestley :correct me if Im wrong, the way of fixing this is searching in the file that describe code block ?
Then i look for code in $this->getEngine()->isHTMLMailMode() blocks and try to get it right ? Seems easy for color, a little bit less for the gap.

I will be pleased to try contributing. Can @joshuaspence paste me the html of the counterexample in the mail. Sadly I was still in text email at this time.

epriestley closed this task as Resolved.May 6 2016, 12:41 AM
epriestley claimed this task.

I think I fixed this in D15847:

counterexample.c
int *p = 0;
*p++;