Page MenuHomePhabricator
Differential D20385

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2019, 9:24 PM.
Tags
None
Referenced Files
F15534319: D20385.diff
Wed, Apr 23, 11:45 PM
F15490211: D20385.id48647.diff
Fri, Apr 11, 3:16 PM
F15490169: D20385.id48646.diff
Fri, Apr 11, 2:56 PM
F15486543: D20385.id.diff
Thu, Apr 10, 8:05 AM
F15485134: D20385.diff
Wed, Apr 9, 10:05 PM
F15465176: D20385.id48646.diff
Wed, Apr 2, 3:34 PM
F15374250: D20385.diff
Mar 12 2025, 5:53 PM
Unknown Object (File)
Mar 3 2025, 2:17 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13275: Build Portals: a standalone menu page / dashboard of dashboards
Commits
rPfb193106314e: Fix some overlooked profile menu construction callsites
Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan
  • Visited each controller, saw actual pages instead of menu construction fatals.
  • Grepped for getProfileMenu().

Diff Detail

Repository
rP Phabricator
Branch
portal27
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22521
Build 30835: Run Core Tests
Build 30834: arc lint + arc unit

Revision Contents
Changeset List

Diff 48646

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility