Page MenuHomePhabricator
Differential D20385

Fix some overlooked profile menu construction callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2019, 9:24 PM.
Tags
None
Referenced Files
F13088435: D20385.diff
Thu, Apr 25, 1:26 AM
Unknown Object (File)
Fri, Apr 19, 5:36 PM
Unknown Object (File)
Fri, Apr 19, 3:09 AM
Unknown Object (File)
Thu, Apr 18, 7:09 AM
Unknown Object (File)
Wed, Apr 17, 11:35 PM
Unknown Object (File)
Mon, Apr 8, 7:13 AM
Unknown Object (File)
Mon, Apr 1, 11:37 PM
Unknown Object (File)
Mon, Apr 1, 10:50 PM
View All 96 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13275: Build Portals: a standalone menu page / dashboard of dashboards
Commits
rPfb193106314e: Fix some overlooked profile menu construction callsites
Summary

Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.

Test Plan
  • Visited each controller, saw actual pages instead of menu construction fatals.
  • Grepped for getProfileMenu().

Diff Detail

Repository
rP Phabricator
Branch
portal27
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22521
Build 30835: Run Core Tests
Build 30834: arc lint + arc unit

Revision Contents
Changeset List

Diff 48646

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility