Page MenuHomePhabricator

On Dashboards, distinguish between invalid panels and restricted panels
ClosedPublic

Authored by epriestley on Apr 3 2019, 2:01 PM.
Tags
None
Referenced Files
F18741602: D20376.id48613.diff
Thu, Oct 2, 2:46 PM
F18697350: D20376.diff
Sat, Sep 27, 9:33 AM
F18696235: D20376.diff
Sat, Sep 27, 7:10 AM
F18658649: D20376.id48614.diff
Tue, Sep 23, 7:39 AM
F18653500: D20376.id.diff
Sun, Sep 21, 2:04 PM
F18653012: D20376.id48641.diff
Sun, Sep 21, 10:34 AM
F18623236: D20376.id48614.diff
Mon, Sep 15, 2:55 PM
F18623234: D20376.id48613.diff
Mon, Sep 15, 2:55 PM
Subscribers
None

Details

Summary

Depends on D20374. Panels may not be visible if they are restricted (no permission) or if they are invalid (e.g., the panel was deleted).

Render these as two separate states instead of one big combined state.

Test Plan

Screen Shot 2019-04-03 at 6.59.43 AM.png (217×777 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
portal22
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22488
Build 30787: Run Core Tests
Build 30786: arc lint + arc unit