Paths

Table of Contentst

Differential D20358

Update all existing ProfileMenuItems for the more-structured API
ClosedPublic
Actions

Authored by epriestley on Mar 31 2019, 7:12 PM.

Tags

None

Referenced Files

	F15493814: D20358.id48609.diff
	Sat, Apr 12, 10:11 PM

	F15490419: D20358.id48576.diff
	Fri, Apr 11, 5:14 PM

	F15489769: D20358.id48609.diff
	Fri, Apr 11, 12:07 PM

	F15488087: D20358.id.diff
	Thu, Apr 10, 7:17 PM

	F15487068: D20358.id48577.diff
	Thu, Apr 10, 10:58 AM

	F15484711: D20358.diff
	Wed, Apr 9, 7:43 PM

	F15480096: D20358.id48576.diff
	Tue, Apr 8, 11:35 AM

	F15462420: D20358.diff
	Tue, Apr 1, 3:03 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13275: Build Portals: a standalone menu page / dashboard of dashboards

Commits

rP5192ae47509e: Update all existing ProfileMenuItems for the more-structured API

Summary

Depends on D20357. Ref T13275. Now that there's a stronger layer between "stuff in the database" and "stuff on the screen", these subclasses all need to emit intermediate objects instead of raw, HTML-producing view objects.

This update is mostly mechanical.

Test Plan

Viewed Home, Favorites, Portals, User Profiles, Project Profiles.
Clicked each item on each menu/profile type.
Added every (I think?) type of item to a menu and clicked them all.
Grepped for obsolete symbols (newNavigationMenuItems, willBuildNavigationItems).

Diff Detail

Repository

Branch

portal8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22449
Build 30727: Run Core Tests
Build 30726: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 31 2019, 7:12 PM

Harbormaster completed remote builds in B22449: Diff 48576.Mar 31 2019, 7:13 PM

epriestley requested review of this revision.Mar 31 2019, 7:13 PM

Minor API completeness / correctness fixes.
Support image icons, used by "Project" menu items.

This also includes some changes aimed at T12871, which improve rendering of dashboards that aren't accessible. Instead of just failing into a confusing broken/empty state, we now show "Restricted" vs "Invalid" vs "Archived" more clearly.

Harbormaster completed remote builds in B22450: Diff 48577.Mar 31 2019, 7:18 PM

epriestley added a child revision: D20359: When picking a default menu item to render, don't pick disabled items.Mar 31 2019, 9:13 PM

amckinley accepted this revision.Apr 1 2019, 10:11 PM

This revision is now accepted and ready to land.Apr 1 2019, 10:11 PM

Closed by commit rP5192ae47509e: Update all existing ProfileMenuItems for the more-structured API (authored by epriestley). · Explain WhyApr 2 2019, 10:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in 2019 Week 16 (Late April).Apr 18 2019, 1:55 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

menuitem/

PhabricatorDashboardPortalMenuItem.php

8 lines

home/

menuitem/

PhabricatorHomeLauncherProfileMenuItem.php

8 lines

PhabricatorHomeProfileMenuItem.php

8 lines

people/

menuitem/

PhabricatorPeopleBadgesProfileMenuItem.php

6 lines

PhabricatorPeopleCommitsProfileMenuItem.php

6 lines

PhabricatorPeopleDetailsProfileMenuItem.php

8 lines

PhabricatorPeopleManageProfileMenuItem.php

6 lines

PhabricatorPeoplePictureProfileMenuItem.php

42 lines

PhabricatorPeopleRevisionsProfileMenuItem.php

6 lines

PhabricatorPeopleTasksProfileMenuItem.php

6 lines

project/

menuitem/

PhabricatorProjectDetailsProfileMenuItem.php

8 lines

PhabricatorProjectManageProfileMenuItem.php

8 lines

PhabricatorProjectMembersProfileMenuItem.php

8 lines

PhabricatorProjectPictureProfileMenuItem.php

30 lines

PhabricatorProjectPointsProfileMenuItem.php

6 lines

PhabricatorProjectSubprojectsProfileMenuItem.php

8 lines

PhabricatorProjectWorkboardProfileMenuItem.php

8 lines

search/

engine/

PhabricatorProfileMenuItemView.php

5 lines

menuitem/

PhabricatorApplicationProfileMenuItem.php

6 lines

PhabricatorConpherenceProfileMenuItem.php

23 lines

PhabricatorDashboardProfileMenuItem.php

94 lines

PhabricatorDividerProfileMenuItem.php

7 lines

PhabricatorEditEngineProfileMenuItem.php

12 lines

PhabricatorLabelProfileMenuItem.php

6 lines

PhabricatorLinkProfileMenuItem.php

20 lines

PhabricatorManageProfileMenuItem.php

8 lines

PhabricatorMotivatorProfileMenuItem.php

4 lines

PhabricatorProfileMenuItem.php

41 lines

PhabricatorProjectProfileMenuItem.php

10 lines

Diff 48576

src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php

Loading...

src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php

Loading...

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleCommitsProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeoplePictureProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectPictureProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php

Loading...

src/applications/search/engine/PhabricatorProfileMenuItemView.php

Loading...

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorLabelProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorLinkProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorManageProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php

Loading...