Details
Details
- Viewed Home, Favorites, Portals, User Profiles, Project Profiles.
- Clicked each item on each menu/profile type.
- Added every (I think?) type of item to a menu and clicked them all.
- Grepped for obsolete symbols (newNavigationMenuItems, willBuildNavigationItems).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- portal8
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 22449 Build 30727: Run Core Tests Build 30726: arc lint + arc unit
Event Timeline
Comment Actions
- Minor API completeness / correctness fixes.
- Support image icons, used by "Project" menu items.
This also includes some changes aimed at T12871, which improve rendering of dashboards that aren't accessible. Instead of just failing into a confusing broken/empty state, we now show "Restricted" vs "Invalid" vs "Archived" more clearly.