Page MenuHomePhabricator

Automatically build mobile menus from navigation, and clean up external ProfileMenu API
ClosedPublic

Authored by epriestley on Mar 31 2019, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 7:45 AM
Unknown Object (File)
Mon, Mar 25, 7:45 AM
Unknown Object (File)
Mon, Mar 25, 7:45 AM
Unknown Object (File)
Mon, Mar 25, 7:44 AM
Unknown Object (File)
Mon, Mar 25, 7:44 AM
Unknown Object (File)
Sun, Mar 24, 11:22 AM
Unknown Object (File)
Sat, Mar 2, 6:48 AM
Unknown Object (File)
Feb 24 2024, 4:36 PM
Subscribers
None

Details

Summary

Depends on D20355. Ref T13275. Ref T13247. Currently, "Hamburger" menus are not automatically built from navigation menus. However, this is (I'm almost completely sure?) a reasonable and appropriate default behavior, and saves us some code around profile menus.

With this rule in place, we can remove setApplicationMenu() and getApplicationMenu() from StandardPageView, since they have no callers.

This also updates a lot of profile menu callsites to a new API which is added in the next change.

Test Plan

See the next two changes.

Diff Detail

Repository
rP Phabricator
Branch
portal6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22447
Build 30723: Run Core Tests
Build 30722: arc lint + arc unit