Page MenuHomePhabricator

Allow profile menu items to be locked to the top or bottom of the menu
ClosedPublic

Authored by epriestley on Mar 30 2019, 10:09 PM.
Tags
None
Referenced Files
F15535671: D20355.id48606.diff
Thu, Apr 24, 6:13 AM
F15504285: D20355.id.diff
Mon, Apr 14, 5:07 PM
F15498308: D20355.id48572.diff
Sun, Apr 13, 12:37 PM
F15483594: D20355.diff
Wed, Apr 9, 1:20 PM
F15378824: D20355.diff
Mar 13 2025, 5:14 PM
Unknown Object (File)
Feb 25 2025, 9:32 AM
Unknown Object (File)
Feb 24 2025, 2:34 AM
Unknown Object (File)
Feb 14 2025, 5:43 PM
Subscribers
None

Details

Summary

Depends on D20353. Ref T13275. This is just some small quality-of-life fixes:

  • When you add items to menus, they currently go below the "Edit Menu/Manage Menu" links by default. This isn't a very good place for them. Instead, lock "edit" items to the bottom of the menu.
  • Lock profile pictures to the top of the menu. This just simplifies things a little.
  • Show more iconography hints on the "edit menu items" UI.
  • Add a "drag stuff to do things" hint if some stuff can be dragged.
Test Plan
  • Added new items to a Portal, they didn't go to the very bottom. Instead, they went above the "Edit/Manage" links; a sensible place for them.
  • Viewed the "edit menu items" screen, saw more hints and visual richness.
  • Viewed/edited Home, Projects, Portals, Favorites

Diff Detail

Repository
rP Phabricator
Branch
portal5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22445
Build 30719: Run Core Tests
Build 30718: arc lint + arc unit