Page MenuHomePhabricator

Allow Portals to be edited, and improve empty/blank states
ClosedPublic

Authored by epriestley on Mar 29 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 7:43 AM
Unknown Object (File)
Mon, Mar 25, 7:42 AM
Unknown Object (File)
Mon, Mar 25, 7:42 AM
Unknown Object (File)
Feb 15 2024, 1:20 PM
Unknown Object (File)
Feb 7 2024, 11:07 PM
Unknown Object (File)
Jan 20 2024, 4:40 PM
Unknown Object (File)
Jan 16 2024, 5:11 PM
Unknown Object (File)
Jan 12 2024, 4:45 PM
Subscribers
None

Details

Summary

Depends on D20348. Ref T13275. Portals are mostly just a "ProfileMenuEngine" menu, and that code is already relatively modular/flexible, so set that up to start with.

The stuff it gets wrong right now is mostly around empty/no-permission states, since the original use cases (project menus) didn't have any of these states: it's not possible to have a project menu with no content.

Let the engine render an "empty" state (when there are no items that can render a content page) and try to make some of the empty behavior a little more user-friendly.

This mostly makes portals work, more or less.

Test Plan

Screen Shot 2019-03-29 at 3.03.39 PM.png (910×1 px, 288 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable