Page MenuHomePhabricator
Create Task
Maniphest T10625

Links like "((prototype))" are not expanded properly in email
Closed, ResolvedPublic
Actions

Description

In T10624#165819, @chad wrote:

See Prototype.

I got an email containing this:
<p>See <a href="/u/prototype" target="_blank">Prototype</a>.</p>
Which of course is invalid.
Assuming this is Diviner because the link redirects towards that application.

Revisions and Commits

rP Phabricator
D15497rP981f3a9068bb When marking up Phurl URLs for mail, use absolute URLs

Related Objects

Event Timeline

Krenair created this task.Mar 18 2016, 10:40 PM
chad added a comment.Mar 18 2016, 10:41 PM

Phurl is a prototype, too.

Krenair added a comment.Mar 18 2016, 10:43 PM

So this actually in Phurl (not clear from the link) and not valid itself because Phurl is a prototype?

chad added a comment.Mar 18 2016, 10:48 PM

Yeaaah, I would assume this worked for free with Remarkup, but I guess not. Yeah it's Phurl,

epriestley added a subscriber: epriestley.Mar 18 2016, 10:48 PM

Yes, Phurl provides URL shortening. U10 is the root object providing ((prototype)).

epriestley added a comment.Mar 18 2016, 10:49 PM

This is probably very easy to fix, let me spend 3 seconds on it.

chad edited projects, added Phurl; removed Diviner.Mar 18 2016, 10:49 PM
epriestley added a comment.Mar 18 2016, 10:51 PM

Oh -- I misunderstood. The issue isn't that we're getting invalid markup or emitting markup in a text context, but that the link is relative.

epriestley added a revision: D15497: When marking up Phurl URLs for mail, use absolute URLs.Mar 18 2016, 10:59 PM
epriestley closed this task as Resolved by committing rP981f3a9068bb: When marking up Phurl URLs for mail, use absolute URLs.Mar 18 2016, 11:00 PM
epriestley added a commit: rP981f3a9068bb: When marking up Phurl URLs for mail, use absolute URLs.
epriestley added a comment.Mar 18 2016, 11:02 PM

Test: User Guide: Prototype Applications

epriestley added a comment.Mar 18 2016, 11:02 PM

That one worked OK, yell if you're still seeing an issue?

Krenair added a comment.Mar 18 2016, 11:30 PM

Yep, that worked. Thanks.

Phabricator · Built by Phacility