Differential D12891

Specify branch in Diffusion commit email
AbandonedPublic
Actions

Authored by Krenair on May 17 2015, 10:42 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6897: Diffusion commit email notification does not specify branch

Summary

Fixed T6897

Test Plan

Commit to repository, check email inbox

Diff Detail

Repository

rP Phabricator

Branch

T6897

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6052
Build 6072: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Krenair updated this revision to Diff 31005.May 17 2015, 10:42 PM

Krenair added a task: T6897: Diffusion commit email notification does not specify branch.

Krenair retitled this revision from to Specify branch in Diffusion commit email.

Krenair updated this object.

Krenair edited the test plan for this revision. (Show Details)

Krenair added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 10:42 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Did you actually execute your test plan? I would expect this change to:

not affect Diffusion mail at all; and
sometimes show a BRANCH heading twice in Differential mail.

epriestley requested changes to this revision.May 19 2015, 2:14 PM

epriestley edited edge metadata.

This revision now requires changes to proceed.May 19 2015, 2:14 PM

I checked the email quickly, but clearly not well enough.

I don't think I know enough about Git and Phabricator's internals to do this.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

4 lines

Diff 31005

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Specify branch in Diffusion commit emailAbandonedPublicActions