HomePhabricator
Diffusion Phabricator 7cab903943f5

Migrate Differential revision edges to use modern `EdgeType` subclasses
7cab903943f5
Actions

Description

Migrate Differential revision edges to use modern EdgeType subclasses

Summary: Modernize Differential edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan: From previous experience, these changes are fairly trivial and safe. I poked around a little to make sure things looked reasonably okay.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, Krenair, epriestley

Differential Revision: https://secure.phabricator.com/D11074

Details

Auditors
Krenair
Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jan 1 2015, 4:08 AM
Reviewer
Blessed Reviewers
Differential Revision
D11074: Migrate Differential revision edges to use modern `EdgeType` subclasses
Parents
rPc564a3c22a65: Fix method name
Branches
Unknown
Tags
Unknown

Event Timeline

joshuaspence committed rP7cab903943f5: Migrate Differential revision edges to use modern `EdgeType` subclasses (authored by joshuaspence).Jan 1 2015, 4:07 AM
joshuaspence added a project: Blessed Reviewers.Jan 1 2015, 4:09 AM
Krenair raised a concern with this commit.Jan 3 2015, 8:09 PM
Krenair added a subscriber: epriestley.
Krenair added a subscriber: Krenair.

Shouldn't DiffusionCommitHasRevisionEdgeType and DifferentialReviewerForRevisionEdgeType have get*String functions? Is this what is causing the Herald entries on https://secure.phabricator.com/project/edit/1308/ ?

Krenair resigned from this audit.Jan 4 2015, 5:09 PM

This got fixed in rP2dea110 it seems.

Changes (31)

PathSize
resources/
sql/
autopatches/
patches/
src/
applications/
differential/
controller/
customfield/
edge/
editor/
query/
storage/
differential/
edge/
ponder/
edge/
DifferentialRevisionDependedOnByRevisionEdgeType.php
PonderVotingUserHasQuestionEdgeType.php
differential/
edge/
maniphest/
edge/
DifferentialRevisionDependsOnRevisionEdgeType.php
ManiphestTaskDependsOnTaskEdgeType.php
DifferentialRevisionHasCommitEdgeType.php
ManiphestTaskHasCommitEdgeType.php
differential/
edge/
diffusion/
edge/
DifferentialRevisionHasReviewerEdgeType.php
DiffusionCommitHasTaskEdgeType.php
diffusion/
controller/
edge/
events/
maniphest/
controller/
edge/
releeph/
commitfinder/
field/
specification/
repository/
worker/
commitmessageparser/
search/
controller/
infrastructure/
edges/
constants/
internationalization/
translation/

rP7cab903943f5

View Options

resources/sql/autopatches/20140212.dx.1.armageddon.php

Loading...
View Options

resources/sql/autopatches/20140420.rel.2.objectmig.php

Loading...
View Options

resources/sql/patches/20130409.commitdrev.php

Loading...
View Options

resources/sql/patches/20131004.dxreviewers.php

Loading...
View Options

resources/sql/patches/migrate-differential-dependencies.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentPreviewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialDependenciesField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialDependsOnField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php

Loading...
View Options

src/applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php

Loading...
View Options

src/applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php

Loading...
View Options

src/applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php

Loading...
View Options

src/applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php

Loading...
View Options

src/applications/diffusion/events/DiffusionHovercardEventListener.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php

Loading...
View Options

src/applications/releeph/commitfinder/ReleephCommitFinder.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility