Paths

Table of Contentst

Diffusion Phabricator 7c2a7d03651c

Modernize remaining edge types
7c2a7d03651c
Actions

Description

Modernize remaining edge types

Summary: Modernize remaining edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan: Browsed around and performed various actions include subscribing, unsubscribing and watching.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11116

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Jan 2 2015, 11:59 PM

Reviewer

Blessed Reviewers

Differential Revision

D11116: Modernize remaining edge types

Parents

rPd0d186610376: Remove an unused variable

Branches

Unknown

Tags

Unknown

Event Timeline

joshuaspence committed rP7c2a7d03651c: Modernize remaining edge types (authored by joshuaspence).Jan 2 2015, 11:58 PM

joshuaspence added a project: Blessed Reviewers.

Krenair mentioned this in T4968: Change phrasing of "task subscriber added" message.Jan 3 2015, 8:59 PM

Changes (61)

Path

Size

resources/

sql/

autopatches/

20140210.projcfield.4.memmig.sql

20140211.dx.3.migsubscriptions.sql

20140731.audit.1.subscribers.php

20140904.macroattach.php

patches/

20130201.revisionunsubscribed.php

20130703.legalpaddocdenorm.php

20131121.repocredentials.2.mig.php

src/

__phutil_library_map__.php

applications/

audit/

storage/

PhabricatorAuditTransaction.php

conpherence/

editor/

ConpherenceEditor.php

mail/

ConpherenceReplyHandler.php

query/

ConpherenceThreadQuery.php

differential/

customfield/

DifferentialAsanaRepresentationField.php

DifferentialJIRAIssuesField.php

editor/

DifferentialTransactionEditor.php

query/

DifferentialRevisionQuery.php

storage/

DifferentialRevision.php

doorkeeper/

edge

PhabricatorAsanaTaskHasObjectEdgeType.php

PhabricatorJiraIssueHasObjectEdgeType.php

PhabricatorObjectHasAsanaTaskEdgeType.php

PhabricatorObjectHasJiraIssueEdgeType.php

worker/

DoorkeeperAsanaFeedWorker.php

DoorkeeperJIRAFeedWorker.php

	doorkeeper/	edge/
	transactions/	edges/

	PhabricatorAsanaSubtaskHasObjectEdgeType.php
	PhabricatorObjectMentionsObjectEdgeType.php

	PhabricatorObjectHasAsanaSubtaskEdgeType.php
	PhabricatorObjectMentionsObjectEdgeType.php

files/

edge

PhabricatorFileHasObjectEdgeType.php

query/

PhabricatorFileQuery.php

storage/

PhabricatorFile.php

legalpad/

editor/

LegalpadDocumentEditor.php

query/

LegalpadDocumentQuery.php

maniphest/

query/

ManiphestTaskQuery.php

passphrase/

controller/

PassphraseCredentialViewController.php

edge

	passphrase/	edge/
	transactions/	edges/

	PhabricatorCredentialsUsedByObjectEdgeType.php
	PhabricatorObjectMentionsObjectEdgeType.php

project/

controller/

PhabricatorProjectWatchController.php

editor/

PhabricatorProjectTransactionEditor.php

query/

PhabricatorProjectQuery.php

repository/

editor/

PhabricatorRepositoryEditor.php

subscriptions/

editor/

PhabricatorSubscriptionsEditor.php

events/

PhabricatorSubscriptionsUIEventListener.php

query/

PhabricatorSubscribersQuery.php

transactions/

edges/

PhabricatorContributedToObjectEdgeType.php

	PhabricatorObjectUsesCredentialsEdgeType.php
	PhabricatorObjectMentionsObjectEdgeType.php

PhabricatorTestNoCycleEdgeType.php

	PhabricatorUnsubscribedFromObjectEdgeType.php
	PhabricatorObjectMentionsObjectEdgeType.php

PhabricatorWatcherHasObjectEdgeType.php

editor/

PhabricatorApplicationTransactionCommentEditor.php

PhabricatorApplicationTransactionEditor.php

	transactions/	edges/
	project/	edge/

	PhabricatorObjectHasContributorEdgeType.php
	PhabricatorProjectProjectHasMemberEdgeType.php

	transactions/	edges/
	maniphest/	edge/

	PhabricatorObjectHasFileEdgeType.php
	ManiphestTaskHasMockEdgeType.php

	PhabricatorObjectHasSubscriberEdgeType.php
	ManiphestTaskHasMockEdgeType.php

	PhabricatorObjectHasWatcherEdgeType.php
	ManiphestTaskHasMockEdgeType.php

	transactions/	edges/
	dashboard/	edge/

	PhabricatorObjectHasUnsubscriberEdgeType.php
	PhabricatorDashboardDashboardHasPanelEdgeType.php

	transactions/	edges/
	differential/	edge/

	PhabricatorSubscribedToObjectEdgeType.php
	DifferentialReviewerForRevisionEdgeType.php

infrastructure/

edges/

__tests__/

PhabricatorEdgeTestCase.php

constants/

PhabricatorEdgeConfig.php

type/

PhabricatorEdgeType.php

PhabricatorLegacyEdgeType.php

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

rP7c2a7d03651c

View Options

resources/sql/autopatches/20140210.projcfield.4.memmig.sql

View Options

resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql

View Options

resources/sql/autopatches/20140731.audit.1.subscribers.php

View Options

resources/sql/autopatches/20140904.macroattach.php

View Options

resources/sql/patches/20130201.revisionunsubscribed.php

View Options

resources/sql/patches/20130703.legalpaddocdenorm.php

View Options

resources/sql/patches/20131121.repocredentials.2.mig.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

View Options

src/applications/conpherence/editor/ConpherenceEditor.php

View Options

src/applications/conpherence/mail/ConpherenceReplyHandler.php

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

View Options

src/applications/differential/customfield/DifferentialAsanaRepresentationField.php

View Options

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/doorkeeper/edge/PhabricatorAsanaSubtaskHasObjectEdgeType.php

View Options

src/applications/doorkeeper/edge/PhabricatorAsanaTaskHasObjectEdgeType.php

View Options

src/applications/doorkeeper/edge/PhabricatorJiraIssueHasObjectEdgeType.php

View Options

src/applications/doorkeeper/edge/PhabricatorObjectHasAsanaSubtaskEdgeType.php

View Options

src/applications/doorkeeper/edge/PhabricatorObjectHasAsanaTaskEdgeType.php

View Options

src/applications/doorkeeper/edge/PhabricatorObjectHasJiraIssueEdgeType.php

View Options

src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php

View Options

src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php

View Options

src/applications/files/edge/PhabricatorFileHasObjectEdgeType.php

View Options

src/applications/files/query/PhabricatorFileQuery.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

View Options

src/applications/legalpad/query/LegalpadDocumentQuery.php

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

View Options

src/applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php

View Options

src/applications/project/controller/PhabricatorProjectWatchController.php

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

View Options

src/applications/project/query/PhabricatorProjectQuery.php

View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

View Options

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php

View Options

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

View Options

src/applications/subscriptions/query/PhabricatorSubscribersQuery.php

View Options

src/applications/transactions/edges/PhabricatorContributedToObjectEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectHasFileEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectHasSubscriberEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectHasUnsubscriberEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorObjectUsesCredentialsEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorSubscribedToObjectEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorTestNoCycleEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorUnsubscribedFromObjectEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorWatcherHasObjectEdgeType.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/infrastructure/edges/tests/PhabricatorEdgeTestCase.php

View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

View Options

src/infrastructure/edges/type/PhabricatorEdgeType.php

View Options

src/infrastructure/edges/type/PhabricatorLegacyEdgeType.php

View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Modernize remaining edge types7c2a7d03651cActions

Description

Details

Event Timeline

Changes (61)

rP7c2a7d03651c

resources/sql/autopatches/20140210.projcfield.4.memmig.sql

resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql

resources/sql/autopatches/20140731.audit.1.subscribers.php

resources/sql/autopatches/20140904.macroattach.php

resources/sql/patches/20130201.revisionunsubscribed.php

resources/sql/patches/20130703.legalpaddocdenorm.php

resources/sql/patches/20131121.repocredentials.2.mig.php

src/__phutil_library_map__.php

src/applications/audit/storage/PhabricatorAuditTransaction.php

src/applications/conpherence/editor/ConpherenceEditor.php

src/applications/conpherence/mail/ConpherenceReplyHandler.php

src/applications/conpherence/query/ConpherenceThreadQuery.php

src/applications/differential/customfield/DifferentialAsanaRepresentationField.php

src/applications/differential/customfield/DifferentialJIRAIssuesField.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/differential/query/DifferentialRevisionQuery.php

src/applications/differential/storage/DifferentialRevision.php

src/applications/doorkeeper/edge/PhabricatorAsanaSubtaskHasObjectEdgeType.php

src/applications/doorkeeper/edge/PhabricatorAsanaTaskHasObjectEdgeType.php

src/applications/doorkeeper/edge/PhabricatorJiraIssueHasObjectEdgeType.php

src/applications/doorkeeper/edge/PhabricatorObjectHasAsanaSubtaskEdgeType.php

src/applications/doorkeeper/edge/PhabricatorObjectHasAsanaTaskEdgeType.php

src/applications/doorkeeper/edge/PhabricatorObjectHasJiraIssueEdgeType.php

src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php

src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php

src/applications/files/edge/PhabricatorFileHasObjectEdgeType.php

src/applications/files/query/PhabricatorFileQuery.php

src/applications/files/storage/PhabricatorFile.php

src/applications/legalpad/editor/LegalpadDocumentEditor.php

src/applications/legalpad/query/LegalpadDocumentQuery.php

src/applications/maniphest/query/ManiphestTaskQuery.php

src/applications/passphrase/controller/PassphraseCredentialViewController.php

src/applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php

src/applications/project/controller/PhabricatorProjectWatchController.php

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

src/applications/project/query/PhabricatorProjectQuery.php

src/applications/repository/editor/PhabricatorRepositoryEditor.php

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

src/applications/subscriptions/query/PhabricatorSubscribersQuery.php

src/applications/transactions/edges/PhabricatorContributedToObjectEdgeType.php

src/applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php

src/applications/transactions/edges/PhabricatorObjectHasFileEdgeType.php

src/applications/transactions/edges/PhabricatorObjectHasSubscriberEdgeType.php

src/applications/transactions/edges/PhabricatorObjectHasUnsubscriberEdgeType.php

src/applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php

src/applications/transactions/edges/PhabricatorObjectUsesCredentialsEdgeType.php

src/applications/transactions/edges/PhabricatorSubscribedToObjectEdgeType.php

src/applications/transactions/edges/PhabricatorTestNoCycleEdgeType.php

src/applications/transactions/edges/PhabricatorUnsubscribedFromObjectEdgeType.php

src/applications/transactions/edges/PhabricatorWatcherHasObjectEdgeType.php

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/infrastructure/edges/__tests__/PhabricatorEdgeTestCase.php

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

src/infrastructure/edges/type/PhabricatorEdgeType.php

src/infrastructure/edges/type/PhabricatorLegacyEdgeType.php

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Modernize remaining edge types
7c2a7d03651c
Actions

src/infrastructure/edges/tests/PhabricatorEdgeTestCase.php