Page MenuHomePhabricator

Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns
Closed, ResolvedPublic

Description

  • Comment on something
  • Edit the comment
  • View history
  • See dropdown buttons which do nothing

See also T6731: No "quote" option for some discussion comments?

Revisions and Commits

Restricted Differential Revision

Event Timeline

Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added a project: Transactions.
Krenair added subscribers: Krenair, btrahan.

lets see if I can reproduce here. this is an edit. I will be clicking the dropdown next on save, and then view history (different order from repro steps)

Screen_Shot_2015-01-08_at_9.58.48_AM.png (1×2 px, 463 KB)

Here's a screenshot of what I got making https://secure.phabricator.com/T6895#90476. I did the following

  • left a comment
  • edited the comment
  • clicked the carrot in the far right of the ui
  • selected 'view edit history'
  • took that screenshot

Am I not getting the reproduction steps right? Can you reproduce this issue here?

Nope, that's right. I can reproduce the issue here.

@Krenair is reporting that within the Edit History dialog we render a dropdown menu which does not actually work, not that "View Edit History" does not work. Specifically:

history_dropdown.png (867×1 px, 166 KB)

I think we should just hide these. The value of quoting an older version of a comment seems very small, and the complexity to hook them up isn't trivial.

  • Within the "View Edit History" dialog, we render dropdown menus which do not work. See screenshot immediately above.
  • Making these work is low-value and moderate-complexity, so let's just hide them.
  • Easiest fix is probably something like setHideCommentOptions(true) at the top level of PhabricatorApplicationTransactionCommentHistoryController, then pass it down the stack until you get to the dropdown rendering stuff.
epriestley renamed this task from Cannot get View Raw/Quote options on comment history entries to Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns.Jan 9 2015, 2:55 PM
epriestley triaged this task as Low priority.
lpriestley added a revision: Restricted Differential Revision.Jan 12 2015, 10:13 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 12 2015, 10:14 PM
epriestley added a commit: Restricted Diffusion Commit.