- Comment on something
- Edit the comment
- View history
- See dropdown buttons which do nothing
See also T6731: No "quote" option for some discussion comments?
Description
Description
Revisions and Commits
Revisions and Commits
Related Objects
Related Objects
- Mentioned Here
- T6731: No "quote" option for some discussion comments
Event Timeline
Comment Actions
lets see if I can reproduce here. this is an edit. I will be clicking the dropdown next on save, and then view history (different order from repro steps)
Comment Actions
Here's a screenshot of what I got making https://secure.phabricator.com/T6895#90476. I did the following
- left a comment
- edited the comment
- clicked the carrot in the far right of the ui
- selected 'view edit history'
- took that screenshot
Am I not getting the reproduction steps right? Can you reproduce this issue here?
Comment Actions
@Krenair is reporting that within the Edit History dialog we render a dropdown menu which does not actually work, not that "View Edit History" does not work. Specifically:
I think we should just hide these. The value of quoting an older version of a comment seems very small, and the complexity to hook them up isn't trivial.
Comment Actions
- Within the "View Edit History" dialog, we render dropdown menus which do not work. See screenshot immediately above.
- Making these work is low-value and moderate-complexity, so let's just hide them.
- Easiest fix is probably something like setHideCommentOptions(true) at the top level of PhabricatorApplicationTransactionCommentHistoryController, then pass it down the stack until you get to the dropdown rendering stuff.