how did this ever escape us
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 20 2018
See email. An instance got an invite into an awkward state by cancelling the invite after the user had accepted it but before they registered an account.
The GRANT syntax also appears to have changed. We currently do this (in Phacility-specific code):
Also ignore the untamed-wilds branch, I'm just pulling it out of the wreckage of my explosion-prone laptop (see also T13168).
ignore me
(Yell if I'm assuming too much here.)
The fix I'd propose is:
This isn't meaningful, but we can raise a more specific error.
When you "Analyze", we include a stack trace of where the query was issued from so you can hunt it down if you aren't sure. Does that explain the behavior?
Jul 19 2018
EC2 volume ddata005.phacility.net filled up, causing problems for instances hosted on db005, leading to PHI771. I'll dig back into the CloudWatch monitoring stuff I setup a few months ago and make the db hosts report storage metrics the same way the repo hosts already do.
Bumping this just to say that another team I work with wants to track WIP using count instead of points. In their case, they are a support team, so their board is populated by cross-tagging tasks that belong to other teams. When those cross-tag tasks have story points for the team that originated the task, the story points show on the support team, as well. This means that the support team can't default the story points to 1 just to get the count in WIP.
Oh also apparently query profiling doesn't always come up when you click on it, here is an example error
Via PHI773, filter_input_array(INPUT_ENV, FILTER_UNSAFE_RAW); does not appear to work if variables_order excludes E.
Jul 18 2018
Plans, yes. Timing is trickier. Currently, we only have one outstanding request for this feature (PHI760, which mostly wants project.search). So it's in queue somewhere, but currently beyond the forecasting horizon.
@epriestley any timing/plans for expanding? Would love to replace our older user token flows with an OAuth flow. We'd need a few other methods though:
Conduit API methods define a getRequiredScope() method, which tells you the scope they require.
Are there any obvious ways to see scope requirements/availability today, even if it means spelunking into the source code?
- Install XCode. Find the secret "Install Command Line Tools" option inside the Hidden Chamber of XCode and click it.
xcode-select --install should be possible without a full XCode installation.
Build just the extension from source?
Jul 17 2018
I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.
Jul 16 2018
T1022 is possibly somewhat-vaguely-adjacent on symlink stuff.
@jcox do you know how to reproduce arc diff dying when you try to create certain types of diffs that move or remove symlinks? I think that's adjacent, if not identical to what's being talked about here.
I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:
Jul 13 2018
As a special case of this, if you commit an empty a.py file, then add content to it and also add a new empty b.py file in a commit on top of it, the new empty b.py will be detected as a copy of a.py based on the previous (empty) content of the file. I think Git is being pretty reasonable/consistent here, but this is potentially also expectation-defying:
Trying to reproduce this locally just hits the ft_doc.epochModified issue. I'm not immediately sure why the behavior differs between my local install and secure, but that issue probably needs to be fixed first.
Jul 11 2018
Jul 10 2018
ugh, zucchini
Jul 9 2018
Jul 8 2018
Jul 5 2018
Jul 3 2018
Jul 2 2018
I really haven't looked into the backwards compatibility issue as we're already test-driving on PHP 7.3 preview, so I can't help you out there. Your suggestion to detect the PHP version and offer this solution only for versions of PHP 7 and higher seems like the most obvious approach.
I didn't even suggest dropping support, I'm merely listing the options to allow both versions to work.
We use a manually patched version of arcanist because it suits our company's use case, but it wouldn't be suitable for a merge in Phabricator's codebase in this state.
Jun 29 2018
@mydeveloperday Thanks! That'll work
@dwilches I needed the same ,just wrote up my solution here
Tough decision to make. Given the fact that most PHP projects are abandoning PHP 5 support is great, but with forcing users to upgrade is not always a good thing, as I'm not sure how this would impact the corporate/enterprise customers.
@DragonBe Backwards compatibility is broken by this fix. I'm not sure what the phabricator policy is regarding this, but I see two options:
- Creating another test engine (one for PHPUnit <= 5 and one for PHPUnit > 5)
- Parsing output differently depending on the PHPUnit version and reuse the old code where needed. This would require a little work to do things properly I guess.
In T8510#200946, @aklapper wrote:In https://phabricator.wikimedia.org/T76732#2803813 ksmith brings up that "In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option."
Jun 28 2018
Can't wait for "connect 2" to come out on playstation six.
Jun 27 2018
Is there a workaround for including a newline in a table's cells? I've tried with both pipe and HTML syntax, and with %%%, triple back-tick and <br> with no success.
PHI781 asks for [ ] Show on commit message template. for "Maniphest Tasks:".