Page MenuHomePhabricator

Saved meme-maker results are case-insensitive
Closed, ResolvedPublic

Assigned To
Authored By
amckinley
Jul 20 2018, 10:22 PM
Referenced Files
F5752906: Screen Shot 2018-07-20 at 3.17.15 PM.png
Jul 20 2018, 10:22 PM
Subscribers
Tokens
"The World Burns" token, awarded by epriestley.

Description

See this screenshot:

Screen Shot 2018-07-20 at 3.17.15 PM.png (892×1 px, 637 KB)

I originally wrote the top and bottom text in normal mixed-case, expecting the meme generator to appropriately use an all-uppercase impact font (separate UBN task for that issue coming soon). When changing the text to uppercase, I ended up with a preview meme as shown. Replacing any of the text with new text results in a new, correct preview. Removing all text and copy/pasting it results in the same preview as shown. This affects both the preview image and (as expected) the final, saved image.

Since this is a revenue-impacting bug, please provide a timeline for expected resolution and keep all stakeholders in the loop. Post-mortem scheduling to follow.

Revisions and Commits

Event Timeline

amckinley triaged this task as Unbreak Now! priority.Jul 20 2018, 10:22 PM
amckinley created this task.

I think in D19196 the engine always generated uppercase text, but that got changed in D19200, perhaps?

Removing the phutil_utf8_strtoupper() calls in MemeEngine likely fixes this.