Page MenuHomePhabricator
Feed All Stories

Mar 22 2017

epriestley closed T12437: Phriction Public Visibility requires login as Invalid.

This is expected:

Mar 22 2017, 2:42 PM · Bug Report
ruslan_a created T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.
Mar 22 2017, 2:41 PM · Typeahead, Projects, Maniphest, Feature Request
boruchy added a comment to T12437: Phriction Public Visibility requires login.

The root is visible to users only.
We only marked certain docs for public, but they require login.

Mar 22 2017, 2:37 PM · Bug Report
chad closed T12436: New users do not easily find the way to comment Maniphest tasks as Invalid.

No interest from the upstream (we don't take design suggestions as feature requests), you are welcome to fork Phabricator to provide these locally if you need.

Mar 22 2017, 2:30 PM · Feature Request
epriestley added a comment to T12437: Phriction Public Visibility requires login.

I can't reproduce this. Phriction is successfully public on this install:

Mar 22 2017, 2:18 PM · Bug Report
boruchy created T12437: Phriction Public Visibility requires login.
Mar 22 2017, 2:16 PM · Bug Report
epriestley claimed T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.
Mar 22 2017, 2:05 PM · EditEngine, Bug Report
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: Unknown Object (Differential Revision).
Mar 22 2017, 2:00 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T11050: Allow resigning from a review you are not directly responsible for: Unknown Object (Differential Revision).
Mar 22 2017, 1:49 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley updated the task description for T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes.
Mar 22 2017, 12:06 PM · Guides
epriestley added a comment to T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.

It's a lot easier to merge stuff than split it, so don't worry about filing new stuff if there's any ambiguity. We can merge them with a couple clicks, but if you've really described a different issue then splitting them is much more of a pain.

Mar 22 2017, 12:03 PM · EditEngine, Bug Report
epriestley added a revision to T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice: Unknown Object (Differential Revision).
Mar 22 2017, 12:03 PM · EditEngine, Bug Report
d.maznekov added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Yes, we have several Spaces. But 90% of users are member to default space arranged by Custom policy if understand right report of reproduction bug coming from @cspeckmim.
I'm a user part of all spaces and I'm facing again that Locked task error.
The form for Create Task is common for all Spaces ( Default Create Form·Edit Form ). Default edit policy is only for subscribers.

Mar 22 2017, 11:46 AM · Bug Report, EditEngine
stevex created T12436: New users do not easily find the way to comment Maniphest tasks.
Mar 22 2017, 10:30 AM · Feature Request
johannesberdin edited the content of Community Resources.
Mar 22 2017, 9:48 AM
dujmovic.antonio awarded T12435: Add support for Spaces in Phriction a Like token.
Mar 22 2017, 9:37 AM · Phriction, Feature Request
kristo.mario created T12435: Add support for Spaces in Phriction.
Mar 22 2017, 9:32 AM · Phriction, Feature Request
bbrdaric added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

Just noticed one more quirky thing about users with no view policy for any space. They can't log out and they get one more "No Access to Spaces" message in the modal. Just like email verification, I don't understand why log out should depend on space view policy.

Mar 22 2017, 9:18 AM · Bug Report
bbrdaric added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

Your workflow looks like this, right?

  • Users register, but can't do anything with their accounts.
  • Separately, users email a project administrator to get access (they know to do this via some out-of-band channel?).
  • The project administrator grants them access to projects or directly to spaces.
  • The project administrator emails them back to let them know they can continue.
Mar 22 2017, 9:08 AM · Bug Report
mcorteel added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.

We tested this style (black with shadow) on our install, but the consensus is that it looks awful...
I guess a simple black text color is a little subtle, but at least it isn't confusing (like the blue color) or ugly (like the shadow).
@chad what do you think?

Mar 22 2017, 6:22 AM · Remarkup, Bug Report
cspeckmim updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:55 AM · Bug Report, EditEngine
cspeckmim edited projects for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task, added: Bug Report; removed Bug Report (Needs Information).
Mar 22 2017, 3:46 AM · Bug Report, EditEngine
cspeckmim updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:45 AM · Bug Report, EditEngine
cspeckmim updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:30 AM · Bug Report, EditEngine
cspeckmim updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:25 AM · Bug Report, EditEngine
cspeckmim updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:24 AM · Bug Report, EditEngine
cspeckmim renamed T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task from Locked task on create new one to Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 22 2017, 3:23 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Thanks @chad for the help and motivation~

Mar 22 2017, 3:18 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

nyancat

Mar 22 2017, 3:17 AM · Bug Report, EditEngine
chad reopened T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task as "Open".
Mar 22 2017, 3:17 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

The key ingredient is to next set the default View/Edit policy of Maniphest to the Employees group (for Default Space which user is not accessible to)

Mar 22 2017, 3:16 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I only approve "code" from @epriestley

Mar 22 2017, 2:56 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

what's your policy on supporting "random" PHP snippets from "sources" into Phabricator code

Mar 22 2017, 2:55 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

should send it to the log

Mar 22 2017, 2:54 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

phlog($var);

Mar 22 2017, 2:53 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

i have hosed it?

Screen Shot 2017-03-21 at 10.51.32 PM.png (886×1 px, 98 KB)

Mar 22 2017, 2:52 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

sosneaky

Mar 22 2017, 2:51 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

phlog

Mar 22 2017, 2:50 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

itsasecret

Mar 22 2017, 2:50 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

shh

Mar 22 2017, 2:50 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

What is the best way to log something to the web server logs? I've been mostly using exceptions but that's proving to be more and more cumbersome.

Mar 22 2017, 2:48 AM · Bug Report, EditEngine
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

FWIW I do truly believe we have a bug here, just no idea where. Might be worth adding some logging?

Mar 22 2017, 2:08 AM · Bug Report, EditEngine
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Mar 22 2017, 2:08 AM · Dashboards (v2)
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I tried reproducing this on my phacility instance but I couldn't. Additional steps I took to mimic my setup were:

  1. Make the Default Space only accessible to a specific group (say, Employees)
  2. Make the default Maniphest Task Form visible only to Employees
  3. Make the new Contractors task form default to being in the {Contractors} Space, and only visible/editable by Contractors
Mar 22 2017, 2:05 AM · Bug Report, EditEngine
cspeckmim added a comment to T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.

Maybe this should've been reported on T10004?

Mar 22 2017, 1:57 AM · EditEngine, Bug Report
cspeckmim created T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice.
Mar 22 2017, 1:54 AM · EditEngine, Bug Report
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I'm also running last week's install
libphutil: 24ede7a5dbfd38079c87fc61de64012551965837
arcanist: 822bc53ca306e06314560d8a76f68771d732e8e0
phabricator: 56dd1b297c3e5cdbb477acc7435d6aa5749f33f2

Mar 22 2017, 1:05 AM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I am seeing this too. I've not confirmed 100% but I think it has to do with Spaces:

  1. Create a Space (not the default Space) visible to Project Contractors
  2. Create a Maniphest Task Form (/transactions/editengine/maniphest.task/) that is visible to Contractors, set as being Edit Form
  3. Create a User that is only a member of Contractors and which does not have access to the default space
  4. Log in as the new user and attempt to create a new task using that task form. You will be presented with the "Edit Locked Task" form.
Mar 22 2017, 1:03 AM · Bug Report, EditEngine
chad closed T12174: Home Menu Errata as Resolved.

I think most everything here is complete and will file individual follow up tasks if needed.

Mar 22 2017, 12:48 AM · Dashboards (v2), Profile Menu Item

Mar 21 2017

epriestley closed T12433: Developer as Invalid.
Mar 21 2017, 11:48 PM · Feature Request
• imapsystem8 created T12433: Developer .
Mar 21 2017, 11:38 PM · Feature Request
epriestley created T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes.
Mar 21 2017, 11:16 PM · Guides
epriestley added a comment to T10390: Dashboards v2 (UX).

extra-thinking.jpg (512×512 px, 6 KB)

Mar 21 2017, 10:47 PM · Dashboards (v2)
chad closed T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH as Invalid.
Mar 21 2017, 10:00 PM · Bug Report
chad added a comment to T12420: Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH.

I can't say, I see a lot of questions about it with nginx though with a little googling. Going to close this, feel free to comment again if you can reliably reproduce it for us.

Mar 21 2017, 10:00 PM · Bug Report
chad added a comment to T10390: Dashboards v2 (UX).

thinking-face.png (256×256 px, 53 KB)

Mar 21 2017, 9:17 PM · Dashboards (v2)
epriestley added a comment to T10390: Dashboards v2 (UX).

(And it's easier to build query panels.)

Mar 21 2017, 7:17 PM · Dashboards (v2)
epriestley added a comment to T10390: Dashboards v2 (UX).

I'm fine with getting rid of the template, I think it's much less relevant now that home is no longer a single dashboard.

Mar 21 2017, 7:17 PM · Dashboards (v2)
epriestley added a project to T5698: Github-style Remarkup previews on a checked-in resource: Contributor Onboarding.

I think we could even default it to "fancy mode" without a setting, at least to start with. I'm not sure anyone will want to access the plain text mode with enough frequency that we need it to be sticky.

Mar 21 2017, 7:17 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley created T12431: Pull logs should let us identify client disconnects.
Mar 21 2017, 7:04 PM · Phacility, Diffusion
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Mar 21 2017, 6:28 PM · Dashboards (v2)
chad added a comment to T4200: Building OS packages and install scripts.

Once arc is installed, you can just run arc update. Given the plan to also distribute linters, etc, this would still be preferable for each individual installation vs. us.

Mar 21 2017, 5:54 PM · Guides, Setup
friesenschrauber added a comment to T12430: Stop cutting of Mail History for new Tasks.

Alright chad, from T8783 it seemed like Nuance was still far away, but 3 months doesn't sound that bad.
As suggested I commented on our use case for Nuance. I think we can probably stop annoying @epriestley with that Diff and I'll just patch it on my own installation while Nuance is still in development which is probably easier for all of us.

Mar 21 2017, 5:52 PM · Feature Request
aleb added a comment to T4200: Building OS packages and install scripts.

Commenting here since you merged T12429. I find surprising you put Arcanist in the same bucket as Phabricator. I think you don't even have to do all the work to make Arcanist users happy. I might be wrong, but I think there will be people adding support for Arcanist to their favorite package manager (I'm ignoring Windows), if only they'd have tags or marked releases to work with?

Mar 21 2017, 5:52 PM · Guides, Setup
friesenschrauber added a comment to T8783: Unprototype Nuance (v1).

Coming from T12430: Stop cutting of Mail History for new Tasks I think Nuance could be a great Application for our Use Case of managing Requests to our Team.

Mar 21 2017, 5:48 PM · Nuance, Restricted Project
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Mar 21 2017, 5:41 PM · Dashboards (v2)
chad added a comment to T10390: Dashboards v2 (UX).

Wondering if we should get rid of "template dashboard".

Mar 21 2017, 5:40 PM · Dashboards (v2)
chad updated subscribers of T12430: Stop cutting of Mail History for new Tasks.

We're planning on building Nuance on the short-term roadmap (1-3 months) so use cases right now are very helpful. I'd have to leave the contribution question up to @epriestley. I don't recall other installs needing this sort of thing, so it could be a while before we look into it further.

Mar 21 2017, 5:34 PM · Feature Request
friesenschrauber added a comment to T12430: Stop cutting of Mail History for new Tasks.

Though I can't imagine a use case where keeping full mails for new objects makes anything worse than it is right now, I'll look into Nuance, which actually sounds nice, even though a bit overkill and far away in the stars for our use case. (and will probably bring the last of our Users who just learned to use Maniphest to finally resignate too ;-) ).

Mar 21 2017, 5:31 PM · Feature Request
chad added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

@epriestley this doesn't seem hard to build for a fledgling designer/intern engineer.

Mar 21 2017, 5:22 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
chad added a comment to T12430: Stop cutting of Mail History for new Tasks.

I'm going to punt this into Nuance since it's "help desk" essentially. Maybe add a comment there too.

Mar 21 2017, 5:13 PM · Feature Request
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Mar 21 2017, 5:13 PM · Dashboards (v2)
chad merged T12430: Stop cutting of Mail History for new Tasks into T8783: Unprototype Nuance (v1).
Mar 21 2017, 5:12 PM · Nuance, Restricted Project
chad merged task T12430: Stop cutting of Mail History for new Tasks into T8783: Unprototype Nuance (v1).
Mar 21 2017, 5:12 PM · Feature Request
chad added a comment to T12430: Stop cutting of Mail History for new Tasks.

Doesn't this make Phabricator worse in every other case?

Mar 21 2017, 5:00 PM · Feature Request
friesenschrauber created T12430: Stop cutting of Mail History for new Tasks.
Mar 21 2017, 4:55 PM · Feature Request
stevex awarded T5024: Provide a dedicated page for viewing a single workboard column a Like token.
Mar 21 2017, 4:49 PM · Restricted Project, Workboards
epriestley renamed T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue from An instance managed to generate an out-of-date URI index to User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue.
Mar 21 2017, 3:28 PM · Customer Impact, Daemons, Search, Diffusion
apierritba awarded T12416: Repository mirroring fails due to new `git ls-remote` usage a Like token.
Mar 21 2017, 2:37 PM · Diffusion, Bug Report
20after4 added a comment to T12296: Improve Phacility repository import performance.

While the git ls-remote change isn't really motivated as a performance improvement, it does seem to have reduced CPU usage a measurable amount (deployed on the morning of 3/18), maybe 15%:

Mar 21 2017, 2:19 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

While the git ls-remote change isn't really motivated as a performance improvement, it does seem to have reduced CPU usage a measurable amount (deployed on the morning of 3/18), maybe 15%:

Mar 21 2017, 2:13 PM · Customer Impact, Diffusion, Ops
epriestley lowered the priority of T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue from Normal to Wishlist.

The cause of this was mundane: the daemon queue has a large repository import in it, so the repository search update got stuck behind the import tasks. Manually forcing an index update with bin/search index Rx fixed the index.

Mar 21 2017, 1:56 PM · Customer Impact, Daemons, Search, Diffusion
chad closed T12427: Profile informations immediately visible as Wontfix.

We have no additional design plans around hovercards.

Mar 21 2017, 1:47 PM · Feature Request
jkrets awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 21 2017, 1:35 PM · Workboards (v3), Restricted Project
epriestley added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

I don't really consider this behavior a bug, because this (users registering into zero spaces) isn't really a supported workflow. The menu rendering is less ambiguously a bug, but I'd likely fix it by just hiding the menu in this state, and that won't address your issue. And it doesn't cause any problems unless you get into this questionable state in the first place, so cleaning it up is difficult to prioritize.

Mar 21 2017, 1:30 PM · Bug Report
bbrdaric added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

Oh, I see...so, no luck there...but this would be a great option if it worked the way I initially understood.

Mar 21 2017, 1:00 PM · Bug Report
• sujitb added a comment to T10362: Display comments in a Phabricator task as a tree view instead of quoted inline comments.

Tezt comment

Mar 21 2017, 12:57 PM · Restricted Project, Maniphest, Feature Request
epriestley merged T12428: Unable to export the tasks in a workboard column into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 21 2017, 12:47 PM · Restricted Project, Workboards
epriestley merged task T12428: Unable to export the tasks in a workboard column into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 21 2017, 12:47 PM · Feature Request
epriestley added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

"Can Create (Non-Bot) Users" is a fake permission for Phacility SAAS disguised as a real permission. You must always have that permission and be an administrator to create users: that is, it can only be used to reduce the set of administrators who have permission to create users. In the Phacility SAAS cluster, we set this permission to "No One".

Mar 21 2017, 12:42 PM · Bug Report
epriestley merged T12426: Allow admins to edit the full names of users into T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users.
Mar 21 2017, 12:38 PM · Profile
epriestley merged task T12426: Allow admins to edit the full names of users into T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users.
Mar 21 2017, 12:38 PM · Feature Request
epriestley added a comment to T12426: Allow admins to edit the full names of users.

In the short term, if you want to email me at support@ with the details, I'll fix these manually. We've rarely seen this request and the cost to build this self-serve, even if it didn't have product issues, is greater than the cost to manually fix all known cases for now. I'll build some kind of self-serve solution at the point when I get tired of doing them manually.

Mar 21 2017, 12:38 PM · Feature Request
epriestley merged T12429: Make it easier to install and update arcanist on Mac into T4200: Building OS packages and install scripts.
Mar 21 2017, 12:20 PM · Guides, Setup
epriestley merged task T12429: Make it easier to install and update arcanist on Mac into T4200: Building OS packages and install scripts.
Mar 21 2017, 12:20 PM · Feature Request
aleb created T12429: Make it easier to install and update arcanist on Mac.
Mar 21 2017, 12:13 PM · Feature Request
bbrdaric added a comment to T12421: Can't verify email address if user doesn't have view policy for any space.

Why should verifying email address depend on any space view policy?

Mar 21 2017, 10:52 AM · Bug Report
cristinagheorghisan created T12428: Unable to export the tasks in a workboard column.
Mar 21 2017, 10:18 AM · Feature Request
stevex updated the task description for T12427: Profile informations immediately visible.
Mar 21 2017, 9:22 AM · Feature Request
stevex updated the task description for T12427: Profile informations immediately visible.
Mar 21 2017, 9:22 AM · Feature Request