Page MenuHomePhabricator
Feed All Stories

Mar 23 2017

epriestley added a revision to T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?: Unknown Object (Differential Revision).
Mar 23 2017, 5:48 PM · Bug Report
deathsyn updated the task description for T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.
Mar 23 2017, 5:46 PM · Bug Report
chad added a comment to T11189: Add more Markdown Italics support to Remarkup.

Well we also have a lunch today.

Mar 23 2017, 5:45 PM · Remarkup, Feature Request
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

We could probably ship it (.md in Diffusion rendering as GitHub Flavored Markdown) this week -- it wouldn't be perfect, but we do have total freedom there to iterate as we find cases we're missing there -- it's just a pretty hard sell as a priority for me relative to the development cost. Obviously it would be nice if you bring in your repository to Phabricator and the README.md renders perfectly instead of rendering mostly-okay-but-a-bit-buggy, but it's hard for me to imagine we're losing many users there.

Mar 23 2017, 5:44 PM · Remarkup, Feature Request
chad added a comment to T11189: Add more Markdown Italics support to Remarkup.

Having markdown rendered in documentation as expected probably alleviates 90% of my concerns. At least, having to retype or reformat large chunks of text is un-cool and arduous. Learning some new markup, less so. But it sounds like thats years away.

Mar 23 2017, 5:37 PM · Remarkup, Feature Request
chad added a comment to T11189: Add more Markdown Italics support to Remarkup.

My anecdote here is Betamax vs. VHS. Yes, one is superior, the other has 95% of the market. I believe we're both right, but weigh certain issues differently. I see the new user coming from GitHub as the more important customer, as it leads to growth. The more things are different in Phabricator, the steeper the climb. You're right from a technical standpoint, and I do believe Remarkup is superior, so I'm stuck.

Mar 23 2017, 5:35 PM · Remarkup, Feature Request
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

I think the two goals are sufficiently in conflict and the value of supporting these rules is so low that it probably isn't worth the effort to try to get it right most of the time.

Mar 23 2017, 5:24 PM · Remarkup, Feature Request
chad added a comment to T11189: Add more Markdown Italics support to Remarkup.

Maybe a different question is, what percentage of block of Remarkup here include code-related discussions. I'm not saying rendering those well shouldn't be a high-priority, I just see Remarkup used for much much more (task discussions, documents, conpherence, etc).

Mar 23 2017, 5:13 PM · Remarkup, Feature Request
chad added a comment to T11189: Add more Markdown Italics support to Remarkup.

Are you strictly saying both goals here are not attainable?

Mar 23 2017, 5:10 PM · Remarkup, Feature Request
20after4 added a comment to T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.

I can confirm that In Any: does not seem to include subprojects. I tried to make some sense of the way the project search functions work but it's pretty complicated.

Mar 23 2017, 4:54 PM · Typeahead, Projects, Maniphest, Feature Request
epriestley added a comment to T11189: Add more Markdown Italics support to Remarkup.

My viewpoint is that Markdown was developed for writing first-party blog posts, not for technical discussions about software.

Mar 23 2017, 4:53 PM · Remarkup, Feature Request
deathsyn created T12444: Can't reach Maniphest or People front pages on stable upgrade because of Avatar creation?.
Mar 23 2017, 4:41 PM · Bug Report
chad reopened T11189: Add more Markdown Italics support to Remarkup as "Open".

Just going to reopen this as a wishlist item. Italics/Bold here is probably the biggest requests for cross-functionality Remarkup <-> Markdown I'd personally have. And at least in your test cases, it seems even GitHub fails at them (and CommonMark), though Slack does not, so I think these are workable in the general sense, just will likely come with lost of test cases and regex support. I think correctness of expectation is your main concern (and the maintenance cost), not adhering to a "spec"?

Mar 23 2017, 4:34 PM · Remarkup, Feature Request
epriestley added a revision to T12217: Reduce the hardware cost of Phacility free instances: Unknown Object (Differential Revision).
Mar 23 2017, 2:35 PM · Ops, Phacility
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Oh, sorry! I totally missed the bit with italics which described things quite precisely.

Mar 23 2017, 2:02 PM · Bug Report, EditEngine
cspeckmim added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

After updating the task a million times I did reduce the reproduction steps to just not having the user in the Default View Policy (presumably at time of creation the creator is not in the Subscribers policy group explaining the others' scenarios). I had updated the description to note that but I chould've made that much more clear. Spaces were totally a red herring.

Mar 23 2017, 1:59 PM · Bug Report, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

@cspeckmim I think that patch fixes the issue, thanks for hunting down those reproduction steps!

Mar 23 2017, 1:42 PM · Bug Report, EditEngine
epriestley closed T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task as Resolved by committing Restricted Diffusion Commit.
Mar 23 2017, 1:40 PM · Bug Report, EditEngine
• tomekj2ee awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 23 2017, 1:16 PM · Workboards (v3), Restricted Project
epriestley closed T12432: Silent libc upgrade on Ubuntu systems may have disrupted DNS from PHP and other processes as Resolved.

I haven't seen more of this and there's no planned action on our end, so I'm going to presume we've weathered the storm.

Mar 23 2017, 12:46 PM · Guides
epriestley added a revision to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task: Unknown Object (Differential Revision).
Mar 23 2017, 12:43 PM · Bug Report, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I'm going to fix the bug with these reproduction instructions:

Mar 23 2017, 12:41 PM · Bug Report, EditEngine
• tomekj2ee awarded T6835: Add a Gantt chart view to the "Reports" section a Love token.
Mar 23 2017, 12:03 PM · Maniphest
d.maznekov added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I even get the same error every time creating a new task.
It seems related to Maniphest Policies.
Our Maniphest Policies are:

༄ Maniphest 2017-03-23 07-43-00.jpg (602×875 px, 166 KB)

What solves the problem is setting Default View Policy and Default Edit Policy to All Users.
Hope that helps.

Mar 23 2017, 7:15 AM · Bug Report, EditEngine
rall0r added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I even get the same error every time creating a new task.
It seems related to Maniphest Policies.
Our Maniphest Policies are:

༄ Maniphest 2017-03-23 07-43-00.jpg (602×875 px, 166 KB)

Mar 23 2017, 6:45 AM · Bug Report, EditEngine
20after4 added a comment to T12441: Implement "Phabricator Stories".

If there's any good content in this feature at all, why do I never see it reposted to Reddit or Facebook or Twitter? Are Reddit and Twitter just for old people now?

Mar 23 2017, 3:33 AM
20after4 added a comment to T12003: Explain to users how fulltext queries are parsed and executed.

Elasticsearch has much better support for non-latin language analysis. See https://www.elastic.co/guide/en/elasticsearch/guide/current/icu-tokenizer.html discusses their ability to properly tokenize Thai, Chinese and Japanese text.

Mar 23 2017, 3:10 AM · Search
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 2:02 AM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 1:57 AM · Daemons, Ops, Phacility
epriestley added a comment to T12443: Applying fulltext limits first causes missing results.

T12003 is also related to this (providing more explanatory, contextual help for users executing searches which may not be doing what they want for technical reasons).

Mar 23 2017, 1:54 AM · Restricted Project, Search, Bug Report
epriestley added a comment to T12443: Applying fulltext limits first causes missing results.

There's some additional stuff in D17384, where Elastic has an internal hard limit of 10K results.

Mar 23 2017, 1:48 AM · Restricted Project, Search, Bug Report
jboning added a project to T12443: Applying fulltext limits first causes missing results: Restricted Project.
Mar 23 2017, 1:33 AM · Restricted Project, Search, Bug Report
alexmv created T12443: Applying fulltext limits first causes missing results.
Mar 23 2017, 1:31 AM · Restricted Project, Search, Bug Report
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Mar 23 2017, 1:17 AM · Daemons, Ops, Phacility
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

@beber, please file a new task with reproduction instructions that work on a clean install if you believe you've found a bug.

Mar 23 2017, 12:33 AM · Maniphest, Feature Request
beber added a comment to T12335: Ability to lock a task to prevent further edits.
Mar 23 2017, 12:30 AM · Maniphest, Feature Request
cspeckmim added a comment to T12441: Implement "Phabricator Stories".

@phillco - Is this for like, seeing code reviews that haven't had active participation in while? So users could see what's not being reviewed and lend a hand? Under the assumption that the "most-qualified" stakeholders (or Owners?) are already reviewers/subscribers of a code change but aren't being active, how effective would others' review be?

Mar 23 2017, 12:24 AM
epriestley added a comment to T12442: Build PhrictionPortal.

One other thought as a sort of counterpoint to myself: if we do implement T11367, I probably would expect it to work more like "portals", where you define a portal/directory/volume and everything inside it shares the same permissions. But that's because I'd plan to eventually build DefinitelyNotDropbox.app for bridging file directories to the desktop so you could mount the filesystem on your computer as a disk, and I think we get into enormous amounts of trouble if I mount the phacility_tax_documents/ drive locally and then individual files inside it might have individual permissions so I couldn't view or edit some of them, since there's no way we can give users guidance about that from a filesystem mount. But maybe we have more flexibility there than I think.

Mar 23 2017, 12:22 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think we could just add spaces without any real fuss, yeah. Two possible considerations:

Mar 23 2017, 12:15 AM · Phriction
chad merged T12442: Build PhrictionPortal into T9379: Build Phriction v3.
Mar 23 2017, 12:13 AM · Phriction
chad merged task T12442: Build PhrictionPortal into T9379: Build Phriction v3.
Mar 23 2017, 12:12 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

Ok I think this is mostly a UI issue then, and I didn't think this entirely through. Also, spaces then should just work?

Mar 23 2017, 12:10 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I do think we could make a product argument like "the hierarchical permissions system is too complicated for users to understand, and they'd be better off with a less powerful system". That might look like:

Mar 23 2017, 12:08 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

(this is a problem for me switching on and off projects, haha, I forget design decisions)

Mar 23 2017, 12:08 AM · Phriction
chad added a comment to T12442: Build PhrictionPortal.

I probably solved most of this with my Phriction redesign which visually treated child pages as navigation.

Mar 23 2017, 12:08 AM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

I think PhrictionPortal probably doesn't look too much different from "make a second wiki, except this time you don't have permission to edit the root document, and it's locked to public / all users visibility automatically, and it's at some other URL other than /w/, and remarkup has two different rules".

Mar 23 2017, 12:03 AM · Phriction

Mar 22 2017

chad added a comment to T12442: Build PhrictionPortal.

Hmmmmm, so this essentially exists but you have to make /w/ public in order to achieve it?

Mar 22 2017, 11:45 PM · Phriction
epriestley added a comment to T12442: Build PhrictionPortal.

When I create a second portal ("Encyclopedia of Fruit") and a page ("Orange"), what URL does the page exist at?

Mar 22 2017, 11:42 PM · Phriction
chad renamed T12435: Add support for Spaces in Phriction from Add support for spaces in phriction to Add support for spaces in Phriction.
Mar 22 2017, 11:20 PM · Phriction, Feature Request
chad added a subtask for T12442: Build PhrictionPortal: T12435: Add support for Spaces in Phriction.
Mar 22 2017, 11:20 PM · Phriction
chad created T12442: Build PhrictionPortal.
Mar 22 2017, 11:19 PM · Phriction
kristo.mario added a comment to T12435: Add support for Spaces in Phriction.

Yeah, we kind of fake that now by offering an index page on Phriction welcome with major projects being there on "root" level.

Mar 22 2017, 9:32 PM · Phriction, Feature Request
chad added a project to T12435: Add support for Spaces in Phriction: Phriction.
Mar 22 2017, 9:20 PM · Phriction, Feature Request
chad added a comment to T12435: Add support for Spaces in Phriction.

I think we should just move Phriction to being a full CMS with different top-level hierarchies, which could be space aware. Just implementing Spaces doesn't make much sense otherwise.

Mar 22 2017, 9:20 PM · Phriction, Feature Request
beng added a comment to T12441: Implement "Phabricator Stories".

🔥 🔥 🔥

Mar 22 2017, 9:03 PM
phil awarded T12441: Implement "Phabricator Stories" a Dat Boi token.
Mar 22 2017, 9:02 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I 😍 love staying in touch with my favorite brands. 🎁

Mar 22 2017, 8:59 PM
beng added a comment to T12441: Implement "Phabricator Stories".

Hmm, I could definitely see "Philters" in the near future! Imagine the sponsorship opportunities to add Branded Comments™ via Phabricator® Philters™.

Mar 22 2017, 8:58 PM
beng added a comment to T12441: Implement "Phabricator Stories".

@epriestley: Yeah, I think the brightness level is off. I got a very dark picture as well, although it wasn't all-black.

Mar 22 2017, 8:36 PM
phillco added a comment to T12441: Implement "Phabricator Stories".

In my view, Stories products encourage out-of-band collaboration where the original product falls short. For example Instagram has a "best self forward" impression that causes users to artificially constrain posting. Instagram Stories combats this with its ephemerality and whimsy. It's a "back door" without having to fix the root problems in the main product.

Mar 22 2017, 8:24 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I got the python script working by changing "w" to "wb" like a comment suggested, but I'm only getting all-black bitmaps out of it.

Mar 22 2017, 8:18 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

Does anyone actually use the "Stories" feature in one of the other things that implements it (Excel, Settings.app, Disk Recovery Utility, etc)? Why is it compelling?

Mar 22 2017, 8:09 PM
beng added a comment to T12441: Implement "Phabricator Stories".

@epriestley: Evidently imagesnap no longer works on macOS 10.11 "El Capitan":

Mar 22 2017, 7:56 PM
chad added a comment to T12441: Implement "Phabricator Stories".

I think this would be easy as a menu-item, really. Main issue is what criteria to pick for the stories.

Mar 22 2017, 7:51 PM
beng added a comment to T12441: Implement "Phabricator Stories".

That would be revealing whether or not FB has already been internally A/B testing precisely this on engineers.

Mar 22 2017, 7:51 PM
chad added a comment to T12441: Implement "Phabricator Stories".

Do you even have Cat Facts internally yet?

Mar 22 2017, 7:50 PM
chad added a comment to T12441: Implement "Phabricator Stories".

you expect Fb to cherry-pick it?

Mar 22 2017, 7:49 PM
beng added a comment to T12441: Implement "Phabricator Stories".

I view this as a really effective mechanism to ensure timely code review. Don't review my diff within 24 hours? Poof, code is deleted.

Mar 22 2017, 7:49 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

The UI should probably look like this (not 100% final/polished yet):

Mar 22 2017, 7:45 PM
beng added a comment to T12441: Implement "Phabricator Stories".

+1

Mar 22 2017, 7:45 PM
chad added a comment to T12441: Implement "Phabricator Stories".

Face-You-Make-Robert-Downey-Jr.jpg (523×460 px, 16 KB)

Mar 22 2017, 7:41 PM
epriestley added a comment to T12441: Implement "Phabricator Stories".

I think pictures are part of a "story"? We can have users upload pictures and take pictures with phones. There doesn't seem to be a native CLI way to get Macbooks to take photos but we can make users brew install imagesnap, it seems, and then arc could update stories.

Mar 22 2017, 7:40 PM
epriestley created T12441: Implement "Phabricator Stories".
Mar 22 2017, 7:38 PM
ruslan_a added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

Hmm. Ok. Deleted.

Mar 22 2017, 7:30 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a revision to T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for: Unknown Object (Differential Revision).
Mar 22 2017, 6:47 PM · Audit, Restricted Project, Differential
chad added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

I'm going to probably re-design this page a little.

Mar 22 2017, 5:24 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
chad claimed T5698: Github-style Remarkup previews on a checked-in resource.
Mar 22 2017, 5:24 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
gd added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

Thank you for such a quick turnaround! Highly appreciated.

Mar 22 2017, 5:23 PM · Bug Report
swisspol added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

@epriestley If you just add copy in the selection dialog, it will help a lot IMO:

Mar 22 2017, 5:11 PM · Differential, Bug Report
chad added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

And that's a really great profile image!

Mar 22 2017, 5:01 PM · Bug Report
epriestley added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

Thanks for the extremely thorough bug report. This should be fixed in HEAD of master, and promote to stable within about 72 hours.

Mar 22 2017, 5:00 PM · Bug Report
epriestley closed T12439: Maniphest comment editing fails with required custom field and edge as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:59 PM · Bug Report
chad closed T11865: "Aleo" does not include cyrillic characters as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:57 PM · FreeBSD, Feature Request
epriestley added a revision to T12439: Maniphest comment editing fails with required custom field and edge: Unknown Object (Differential Revision).
Mar 22 2017, 4:55 PM · Bug Report
chad added a revision to T11865: "Aleo" does not include cyrillic characters: Unknown Object (Differential Revision).
Mar 22 2017, 4:51 PM · FreeBSD, Feature Request
epriestley closed T11050: Allow resigning from a review you are not directly responsible for, a subtask of T10967: Move Differential reviewers back to a dedicated database storage table, as Resolved.
Mar 22 2017, 4:50 PM · Restricted Project, Infrastructure, Differential
epriestley closed T11050: Allow resigning from a review you are not directly responsible for as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:50 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley closed T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice as Resolved by committing Restricted Diffusion Commit.
Mar 22 2017, 4:50 PM · EditEngine, Bug Report
epriestley added a revision to T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for: Unknown Object (Differential Revision).
Mar 22 2017, 4:45 PM · Audit, Restricted Project, Differential
epriestley added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

I'd guess there is a ...->setContinueOnMissingFields(true)->... missing on an Editor somewhere.

Mar 22 2017, 4:27 PM · Bug Report
epriestley added a comment to T12440: Broken project permissions/weird bug with nested projects.

Actually, that fix is completely bogus and there's no inverse edge type so this is perhaps somewhat more involved.

Mar 22 2017, 4:25 PM · Bug Report
epriestley added a comment to T12440: Broken project permissions/weird bug with nested projects.

This is probably a one-line fix, but let me repro + get test coverage on it.

Mar 22 2017, 4:25 PM · Bug Report
bjshively created T12440: Broken project permissions/weird bug with nested projects.
Mar 22 2017, 4:18 PM · Bug Report
chad added a comment to T12439: Maniphest comment editing fails with required custom field and edge.

tarnation

Mar 22 2017, 4:13 PM · Bug Report
gd created T12439: Maniphest comment editing fails with required custom field and edge.
Mar 22 2017, 4:10 PM · Bug Report
aklapper removed a project from T12438: Project tokenizer functions like "any()" and "not()" do not include descendants: Typeahead.
Mar 22 2017, 3:05 PM · Typeahead, Projects, Maniphest, Feature Request
chad added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

Specifically, this task is about how the javascript in typeaheads rank and match choices.

Mar 22 2017, 2:56 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
chad added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

Not similar.

Mar 22 2017, 2:55 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
ruslan_a added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Mar 22 2017, 2:48 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
boruchy added a comment to T12437: Phriction Public Visibility requires login.

So root must always be visible to all?

Mar 22 2017, 2:44 PM · Bug Report