Page MenuHomePhabricator
Feed All Stories

Feb 7 2017

joshuaspence added a comment to T8937: Unclear exception when patching non-existant revision.

I don't believe this is related to E being set in variables_order.

Feb 7 2017, 8:40 PM · Arcanist
cspeckmim added a comment to T8937: Unclear exception when patching non-existant revision.

Is it possible this is related to the E argument mentioned in T12071, but for arc clients?

Feb 7 2017, 8:06 PM · Arcanist
jcox added a comment to T8937: Unclear exception when patching non-existant revision.

Just spent some time tracking down what ended up being this issue. I wonder if adding a check in this block to query for the given revision would be sufficient enough to detect this case and return a more sensible error message. I can submit a diff for that if that'd be acceptable

Feb 7 2017, 6:53 PM · Arcanist
chad closed T9336: Link profile image in feed as Resolved by committing Restricted Diffusion Commit.
Feb 7 2017, 6:09 PM · Badge Awarded, PHUI
chad added a comment to T12220: New custom type field: Project Tags.

Does datasource work? I've never tried it personally, but seems to be what you're asking for.
https://secure.phabricator.com/book/phabricator/article/custom_fields/

Feb 7 2017, 6:08 PM · Custom Fields, Feature Request
fosskevin added a comment to T9336: Link profile image in feed.

Is there any way to sort Differential diffs by how simple the change is? Is there a tag for small bug fixes so newbs can come in and see how a small problem was fixed?

Feb 7 2017, 6:08 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Thanks!

Feb 7 2017, 6:01 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

There is a Badge Awarded tag for easy-ish contributions.

Feb 7 2017, 5:58 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

Unfortunately if it's a 5-10 minute bug fix, we'll just fix it.

Feb 7 2017, 5:57 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Poking around the source code was fun. Please find time to put up minor issues like these for newbs. Thanks :)

Feb 7 2017, 5:52 PM · Badge Awarded, PHUI
chad closed T12221: Applying patch "phabricator:20161125.search.01.stemmed.sql" takes forever as Wontfix.

Thanks, glad this all worked out.

Feb 7 2017, 5:48 PM · Bug Report
chad added a revision to T9336: Link profile image in feed: Unknown Object (Differential Revision).
Feb 7 2017, 5:45 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

It took me a little, but I found the source and fixed it. Sorry, this was probably a bit hairier than expected.

Feb 7 2017, 5:45 PM · Badge Awarded, PHUI
fosskevin awarded T9336: Link profile image in feed a Baby Tequila token.
Feb 7 2017, 5:41 PM · Badge Awarded, PHUI
chad added a comment to T9336: Link profile image in feed.

I don't know where the bug is, so I'm not sure how to guide you to fix it without fixing it myself.

Feb 7 2017, 5:39 PM · Badge Awarded, PHUI
fosskevin added a comment to T9336: Link profile image in feed.

Is it in PhabricatorFeedStory or PhabricatorFeedBuilder from the folder src/applications/feed. If I'm looking in the wrong place, could you please clarify what you meant as "level or two up".

Feb 7 2017, 5:36 PM · Badge Awarded, PHUI
caov297 added a comment to T12225: pre-receive hook declined failure during git push.

UPDATE: This issue seems to have been addressed by upgrading to the latest codebase.

Feb 7 2017, 5:27 PM · Bug Report
TiTi added a comment to T11539: Phabricator Mercurial Repo “too many files open” error.

You can enforce the setting in /etc/security/limits.d/<user>.conf, example :

<user> hard nofile 8192
<user> soft nofile 8192

Replace <user> with the service username

Feb 7 2017, 5:20 PM · Bug Report
chad added a comment to T12225: pre-receive hook declined failure during git push.

Can you update your install and provide more detailed steps for us to follow? See Contributing Bug Reports for more information.

Feb 7 2017, 5:18 PM · Bug Report
chad added a comment to T12225: pre-receive hook declined failure during git push.

We don't accept bug reports from out of date installs, nor without steps the upstream can follow and reproduce.

Feb 7 2017, 5:17 PM · Bug Report
chad added a comment to T10390: Dashboards v2 (UX).

Nothing set in stone, It just popped into my head as a possible solution

Feb 7 2017, 5:14 PM · Dashboards (v2)
chad added a comment to T10390: Dashboards v2 (UX).

I'd probably use it in Dashboard creation as well for finding Panels.

Feb 7 2017, 5:13 PM · Dashboards (v2)
caov297 created T12225: pre-receive hook declined failure during git push.
Feb 7 2017, 5:13 PM · Bug Report
chad added a comment to T9336: Link profile image in feed.

I'd say it's a level or two up from the view controller, since setImageHref exists in PHUIFeedStory, but isn't being called.

Feb 7 2017, 5:10 PM · Badge Awarded, PHUI
sergio.castro added a comment to T12222: Add custom fields to the "Task Action..." menu.

Not really.

Feb 7 2017, 5:09 PM · Maniphest, Feature Request
epriestley added a comment to T10390: Dashboards v2 (UX).

Generally makes sense to me.

Feb 7 2017, 5:08 PM · Dashboards (v2)
chad added a comment to T10390: Dashboards v2 (UX).

@epriestley I think for Dashboards, and probably other applications, having some sort of compound typeahead/select would be helpful. I think maybe we can abstract this into using ApplicationSearch as the filter, and the tokenizer for the final results. Thoughts?

Feb 7 2017, 5:02 PM · Dashboards (v2)
fosskevin added a comment to T9336: Link profile image in feed.

I just noticed this task as a beginner task. Shall I try to fix this?

Feb 7 2017, 5:01 PM · Badge Awarded, PHUI
chad added a comment to T12222: Add custom fields to the "Task Action..." menu.

I think T4316 is probably the best solution here, without knowing more about your user's workflow.

Feb 7 2017, 4:47 PM · Maniphest, Feature Request
sergio.castro added a comment to T12222: Add custom fields to the "Task Action..." menu.

OK, I understand, I tried it several times... thanks for your time.

Feb 7 2017, 4:42 PM · Maniphest, Feature Request
chad added a comment to T12222: Add custom fields to the "Task Action..." menu.

See Describing Root Problems if you need help defining the root problem. We don't take "feature does not exist" as a reason to build something.

Feb 7 2017, 4:37 PM · Maniphest, Feature Request
sergio.castro added a comment to T12222: Add custom fields to the "Task Action..." menu.

The root problem is that I have created a custom field and I cannot modify it's value from the "Add Action" menu.

Feb 7 2017, 4:32 PM · Maniphest, Feature Request
epriestley created E1370: Last-Minute Pup Adventures.
Feb 7 2017, 4:32 PM
sergio.castro added a comment to T12223: Allow to duplicate Forms.

Well it's not a real problem if you see like that. It was only a suggestion. Of course I can live without that.

Feb 7 2017, 4:14 PM · EditEngine, Feature Request
chad added a comment to T12222: Add custom fields to the "Task Action..." menu.

You have yet to provide a root problem

Feb 7 2017, 4:05 PM · Maniphest, Feature Request
sergio.castro added a comment to T12222: Add custom fields to the "Task Action..." menu.

Sure I read them before posting anything!. Sorry I can't see what's wrong?

Feb 7 2017, 3:42 PM · Maniphest, Feature Request
chad added a comment to T12223: Allow to duplicate Forms.

This doesn't explain the root problem we require for feature requests. Please see Contributing Feature Requests and Describing Root Problems. We don't expect people to need to make so many forms, we don't know why you're creating so many forms, we don't know what number that is on say a weekly basis, and so forth. We also have upcoming products like Nuance that might be better suited for your workflow. Please please please... only file feature requests stating the problem (and not the solution) you are having with Phabricator.

Feb 7 2017, 3:37 PM · EditEngine, Feature Request
chad edited projects for T12223: Allow to duplicate Forms, added: EditEngine; removed Maniphest.
Feb 7 2017, 3:35 PM · EditEngine, Feature Request
sergio.castro added a comment to T12223: Allow to duplicate Forms.

Sorry I'll try to describe the problem better.

Feb 7 2017, 3:33 PM · EditEngine, Feature Request
chad added a comment to T12222: Add custom fields to the "Task Action..." menu.

Have you read the articles I linked?

Feb 7 2017, 3:28 PM · Maniphest, Feature Request
sergio.castro added a project to T12223: Allow to duplicate Forms: Maniphest.
Feb 7 2017, 3:27 PM · EditEngine, Feature Request
sergio.castro added a comment to T12222: Add custom fields to the "Task Action..." menu.

Sorry I'll try to describe the problem better.

Feb 7 2017, 3:23 PM · Maniphest, Feature Request
epriestley updated the task description for T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:23 PM · Phortune
epriestley created T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:22 PM · Phortune
chad added a comment to T12220: New custom type field: Project Tags.

I don't think the upstream should provide this yet. You're already able to write your own custom field and since it's your code and your rules, will be 10x better for your users. Mostly, we need to abstract out other similar top level problems (input that drives an input?) and devise a single solution that may or may not perfectly fit your needs. It also might take years.

Feb 7 2017, 3:18 PM · Custom Fields, Feature Request
chad added a comment to T12222: Add custom fields to the "Task Action..." menu.

The information provided in this feature request doesn't provide the upstream with enough information to move forward. Please read Contributing Feature Requests and Describing Root Problems carefully and be sure follow all required steps before filing a task. We always require a root problem with every task.

Feb 7 2017, 3:10 PM · Maniphest, Feature Request
chad added a comment to T12223: Allow to duplicate Forms.

The information provided in this feature request doesn't provide the upstream with enough information to move forward. Please read Contributing Feature Requests and Describing Root Problems carefully and be sure follow all required steps before filing a task. We always require a root problem with every task.

Feb 7 2017, 3:09 PM · EditEngine, Feature Request
avivey added a comment to Q553: Cannot import diff affecting 125 files (Answer 506).

storage.local-disk.path is the location where persisted files are stored by the local-disk storage engine., not temporary files. See https://secure.phabricator.com/book/phabricator/article/configuring_file_storage/#engine-local-disk.

Feb 7 2017, 3:06 PM
amartin33 added a comment to Q553: Cannot import diff affecting 125 files (Answer 506).

The chunks engine is not writable - this may be a problem. Moreover, both local-disk and amazon-s3 are not writable either. I have not set storage.local-disk.path - what should this typically be set to? Just some local path where phabricator will store temporary files?

Feb 7 2017, 2:56 PM
sergio.castro created T12223: Allow to duplicate Forms.
Feb 7 2017, 2:49 PM · EditEngine, Feature Request
TiTi added a comment to T12221: Applying patch "phabricator:20161125.search.01.stemmed.sql" takes forever.

Issue was: no more disk space

Feb 7 2017, 2:38 PM · Bug Report
sergio.castro created T12222: Add custom fields to the "Task Action..." menu.
Feb 7 2017, 2:31 PM · Maniphest, Feature Request
epriestley reopened T12213: Task title is truncated in task graph, even if there is enough space as "Open".
Feb 7 2017, 2:09 PM · Maniphest, Bug Report
avivey renamed T12220: New custom type field: Project Tags from New maniphest type field to select tags to New custom type field: Project Tags.
Feb 7 2017, 2:01 PM · Custom Fields, Feature Request
sergio.castro added a comment to T12220: New custom type field: Project Tags.

I know I can create a custom field with the select type, but the problem is that I have 10 different products (project tags) and each one has 100 milestones (2.0.1, 2.0.2, ...). You can imagine why I can not use select for this...

Feb 7 2017, 1:55 PM · Custom Fields, Feature Request
TiTi created T12221: Applying patch "phabricator:20161125.search.01.stemmed.sql" takes forever.
Feb 7 2017, 1:54 PM · Bug Report
samr awarded T12208: Collapsable Menu Item a Love token.
Feb 7 2017, 1:26 PM · Profile Menu Item
avivey closed T12220: New custom type field: Project Tags as Resolved.

Custom fields already support select type, and also allows searching by it:

maniphest.custom-field-definitions
{
	"company.foundin": {
		"name": "Found In",
		"type": "select",
		"search": true,
		"options": ["version 1", "version 2"]
	}
}

search interface:

Feb 7 2017, 1:13 PM · Custom Fields, Feature Request
sergio.castro created T12220: New custom type field: Project Tags.
Feb 7 2017, 12:42 PM · Custom Fields, Feature Request
onyukim updated the question details for Q560: How Can I find this menu?.
Feb 7 2017, 10:33 AM · Dashboards
onyukim added a comment to Q560: How Can I find this menu? (Answer 508).

Thank for your answer!

Feb 7 2017, 10:33 AM
avivey closed Q560: How Can I find this menu? as resolved.
Feb 7 2017, 10:26 AM · Dashboards
avivey added Q560: How Can I find this menu? (Answer 508).
Feb 7 2017, 10:25 AM
onyukim updated the question details for Q560: How Can I find this menu?.
Feb 7 2017, 7:47 AM · Dashboards
onyukim added a project to Q560: How Can I find this menu?: Dashboards.
Feb 7 2017, 7:35 AM · Dashboards
onyukim updated the question details for Q560: How Can I find this menu?.
Feb 7 2017, 7:34 AM · Dashboards
onyukim updated Q560: How Can I find this menu? from to How Can I find this menu?.
Feb 7 2017, 7:34 AM · Dashboards
mcorteel added a comment to T12213: Task title is truncated in task graph, even if there is enough space.

Thank you for your quick reply. Indeed, this is tricky. Apparently, max-width has to be set on cells for overflow to work.

Feb 7 2017, 6:31 AM · Maniphest, Bug Report
chad added a comment to T5301: Inline Remarkup escaping.

That said, if it's open, we do plan to address it eventually.

Feb 7 2017, 4:04 AM · Remarkup
chad added a comment to T5301: Inline Remarkup escaping.

It sounds counter-intuitive, be the upstream prefers not to spend time on theoretical issues. Basically we have thousands of open tasks, and we complete them based on overall impact. Something hypothetically an issue isn't going to receive much attention.

Feb 7 2017, 4:00 AM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

What about triple backticks in code blocks? Code blocks can contain
anything, so I consider not being able to put three consecutive backticks
in them a bug.

Feb 7 2017, 3:51 AM · Remarkup
liuxinyu970226 awarded T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches a Like token.
Feb 7 2017, 12:01 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search

Feb 6 2017

chad marked Q553: Cannot import diff affecting 125 files (Answer 507) as hidden.
Feb 6 2017, 10:44 PM
amartin33 added Q553: Cannot import diff affecting 125 files (Answer 507).
Feb 6 2017, 10:33 PM
avivey added Q553: Cannot import diff affecting 125 files (Answer 506).
Feb 6 2017, 10:14 PM
epriestley added a comment to T2794: Implement Phage (like Hypershell).

Per T12218, the Phacility cluster is reaching a scale (~50 devices) where we need to improve tooling over "open a bunch of terminal windows". I want to look at implementing Phage for this use case and see how far I can get.

Feb 6 2017, 9:54 PM · Phage, Infrastructure
amartin33 added a comment to Q552: Increase max file size of local-disk storage engine.

This summarizes the situation

Feb 6 2017, 9:47 PM
avivey added a comment to Q552: Increase max file size of local-disk storage engine.

What exactly is the user trying to do and how does it fail?

Feb 6 2017, 9:45 PM
avivey added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Can't the same tricks used to make a single web server handle multiple instances be used for the daemons?

Feb 6 2017, 9:36 PM · Ops, Phacility
amartin33 added Q552: Increase max file size of local-disk storage engine (Answer 505).
Feb 6 2017, 9:05 PM
epriestley added a parent task for T2794: Implement Phage (like Hypershell): T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Phage, Infrastructure
epriestley added a subtask for T12218: Reduce the operational cost of a larger Phacility cluster: T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged task T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley changed the visibility for T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Phage, Infrastructure
chad created E1369: Disneyland.
Feb 6 2017, 7:45 PM · Phacility
chad closed T12211: phabricator-home css doesn't get applied to dashboards on home as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 7:06 PM · Profile Menu Item, Dashboards, Bug Report
chad added a revision to T12211: phabricator-home css doesn't get applied to dashboards on home: Unknown Object (Differential Revision).
Feb 6 2017, 6:52 PM · Profile Menu Item, Dashboards, Bug Report
johnny-bit added a comment to T12219: Some MP4 videos do not play in Chrome.

I think that the problem is the content itself. This is evident by thumbnail fails to be generated when the second one is ok. On my OS/browser combo (Gentoo/firefox) first video loads very slowly while the second is perfectly ok. On Chrome first video refuses to load.
After downloading and testing locally, everything is fine. My guess is that chrome and firefox can guess proper values for decoders for "normal" video, while for "weird" video firefox tries it's best and chrome just gives up.

Feb 6 2017, 6:16 PM · Files
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Yeah, same here. Both videos are of similar size (1.6MB vs 2.1MB) and both appear to legitimately be MP4 / H264 videos (neither is some kind of obviously spooky magic like an AVI named .mp4).

Feb 6 2017, 5:39 PM · Files
chad added a comment to T12219: Some MP4 videos do not play in Chrome.

I can't play the top one in safari either

Feb 6 2017, 5:34 PM · Files
epriestley updated subscribers of T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:34 PM · Files
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Here's what I see in Chrome at time of writing:

Feb 6 2017, 5:34 PM · Files
epriestley created T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:33 PM · Files
epriestley closed T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 5:32 PM · Applications, Phacility
epriestley added a revision to T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application: Unknown Object (Differential Revision).
Feb 6 2017, 5:27 PM · Applications, Phacility
epriestley created T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 5:14 PM · Ops, Phacility
chad added a comment to T12214: Navigation menus in applications have no maximum width.

I was joking.

Feb 6 2017, 5:03 PM · PHUI
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

(Maybe the real user report was something only indirectly related, like putting the query on a Dashboard? That would make sense given that the name talks about dashboards...)

Feb 6 2017, 4:58 PM · PHUI
chad closed T12214: Navigation menus in applications have no maximum width as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 4:58 PM · PHUI