Page MenuHomePhabricator
Feed All Stories

Dec 12 2016

epriestley updated subscribers of T11989: Wage an endless war against HP Printer Fax Support.

We scored our first kill today. @dgdfgdg slipped through our defenses in his initial volley, but we reacted quickly and the system automatically deflected his second salvo.

Dec 12 2016, 11:14 PM · Abuse
chad renamed T11957: Add MenuEngine to Home from Add MenuEngine to Dashboards to Add MenuEngine to Home.
Dec 12 2016, 10:43 PM · Profile Menu Item, Dashboards
epriestley closed T4883: Customizing the default homepage for all users as Resolved.

T11957 is the modern followup for this.

Dec 12 2016, 10:38 PM · Dashboards (v2)
epriestley closed T4850: Defining policies for "Project Members" as Resolved.

At least in this use case, I believe things turned out alright without this policy.

Dec 12 2016, 10:34 PM · Restricted Project, Policy
epriestley closed T4806: Give installs more control over session expiry / prompt for reauth before taking security actions as Wontfix.

It's critical that we are addressing specific, plausible threat scenarios when implementing security protocols. This task currently lacks such a scenario.

Dec 12 2016, 10:20 PM · Restricted Project, Auth
epriestley closed T4448: Support symlinking phriction pages as Invalid.

This is pretty old and doesn't meet the requirements of a modern feature request (notably, clear definition of a root problem). Feel free to file a new request if this is still an issue. Particularly helpful would be discussion of why editing the page to say "Go see <other page>" is insufficient.

Dec 12 2016, 9:47 PM · Restricted Project, Phriction
epriestley closed T4439: Set up SPF records for domains we control as Resolved.

This got done at some point, I believe, since we have an SPF record now.

Dec 12 2016, 9:44 PM · Mail, Security
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel as Resolved.
  • Over time, we've drained the swamp to some degree on the default home page, by moving toward more useful defaults.
  • We implemented Dashboards. Although we'd like to improve them, they've allowed ambitious users to fix this themselves for some time.
  • See T11957 and M1473 for modern followups with a more concrete plan to lay this to rest.
  • See also T11132 for discussion of NUX-oriented changes, specifically.
Dec 12 2016, 9:30 PM · Restricted Project, Dashboards (v2)
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T3979: Support logged out version of the home page, as Resolved.
Dec 12 2016, 9:30 PM · Phabricator
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T4323: Scaling bug (for Chrome browser), as Resolved.
Dec 12 2016, 9:29 PM · Badge Awarded, Design
epriestley closed T2683: Improve the performance of Diffusion browse views as Resolved.

This is a billion years old now -- see, e.g., T11954 for more modern work.

Dec 12 2016, 9:21 PM · Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers as Resolved.

"Blame Revision" was a freeform text field at Facebook (from before DiffCamp, even) where you were ideally supposed to enter the revision or commit that introduced the bug you're fixing, if you were fixing a bug introduced by some known change.

Dec 12 2016, 9:18 PM · Diffusion, Audit, Differential
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers, a subtask of T1751: Consider ways to improve revert handling, as Resolved.
Dec 12 2016, 9:18 PM · Restricted Project, Diffusion, Differential
avivey awarded T2115: Back button support in Lightbox a 100 token.
Dec 12 2016, 9:16 PM · Quicksand, Lightbox, Files
epriestley added a project to T2115: Back button support in Lightbox: Quicksand.
Dec 12 2016, 9:10 PM · Quicksand, Lightbox, Files
lewellyn added a comment to Q531: Can an administrator invalidate a user's session to force a logout and relogin? (Answer 485).

Which settings, in particular, are you seeing issues with? The correct answer is to fix them, not hack in something to work around them being broken.

Dec 12 2016, 8:01 PM
caov297 closed Q531: Can an administrator invalidate a user's session to force a logout and relogin? as resolved.
Dec 12 2016, 7:06 PM
caov297 added a comment to Q531: Can an administrator invalidate a user's session to force a logout and relogin? (Answer 485).

the usecase is that if our administrator needs to change some configuration settings which may impact current login users, the idea is to perhaps have a mechanism for force a relogin so the setting takes affect. I accomplish by writing a cmdline application and querying the phabricator_session table to invalidate the user's session, it's not integrated into the phabricator UI, but work good enough for now.

Dec 12 2016, 7:06 PM
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@epriestley I can confirm it works fine both on Mac and Linux for me. Thanks a lot for the finding and quick fix!

Dec 12 2016, 6:50 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

That Chrome change seems at least plausible as a root cause to me, but I definitely don't know enough about the Chrome internals to really hazard a guess.

Dec 12 2016, 6:46 PM · Bug Report
epriestley closed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:39 PM · Bug Report
epriestley added a revision to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden: Unknown Object (Differential Revision).
Dec 12 2016, 6:36 PM · Bug Report
epriestley closed T11999: Fatal on "Customize Menu..." on home as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:33 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Chrome 55 no longer scrolls to elements which are completely hidden to When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a revision to T11999: Fatal on "Customize Menu..." on home: Unknown Object (Differential Revision).
Dec 12 2016, 6:16 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Links to Task's messages don't scroll to the message on Chrome 55 to Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
chad created T11999: Fatal on "Customize Menu..." on home.
Dec 12 2016, 6:14 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

See also https://code.google.com/p/chromium/issues/detail?id=473657 for earlier adventures in Chrome.

Dec 12 2016, 6:13 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my upstream report:

Dec 12 2016, 6:11 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Chromez

Dec 12 2016, 6:09 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@chad was that for me or for Chrome? 😄

Dec 12 2016, 6:08 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

2392289.png (225×300 px, 35 KB)

Dec 12 2016, 6:06 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@epriestley could it be related to this change? https://chromium.googlesource.com/chromium/src/+/a67debf9a9b78f60e7b10b5574ae4ceab49af31b%5E%21/#F2

Dec 12 2016, 6:01 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my reduced test case for Chome 55:

Dec 12 2016, 5:55 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Hah, I was on Chrome 54, and my report above works. But after updating to 55, it no longer works. Something changed in Chrome. Not sure what though.

Dec 12 2016, 5:47 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@chad I was replying but saw now your last comments, thanks @epriestley for narrowing it down. Interesting that I can repro on Chrome 55/Mac while you can't.

Dec 12 2016, 5:36 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Basically, I've found:

Dec 12 2016, 5:32 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Oh, it reproduces for me.

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This appears to be a bug in Chrome, because this fixes it:

Dec 12 2016, 5:31 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This doesn't reproduce for me on this install in Chrome 55/Mac, or any other browser. I'm assuming the issue you saw on this server was T11998 which was a local configuration issue.

Dec 12 2016, 5:20 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 5:15 PM · Bug Report
epriestley added a comment to T11998: Content flashes when loading pages in Chrome.

Specifically, I resolved it by just pushing everything.

Dec 12 2016, 5:06 PM
epriestley closed T11998: Content flashes when loading pages in Chrome as Resolved.

I think I had pushed new code to secure001 and then wandered off to do something else.

Dec 12 2016, 5:05 PM
chad added a comment to Q534: can the admin set a dashboard as the defaut dashboard for everyone? (Answer 487).

Our expectation building Phabricator is that it's easy and obvious to accomplish tasks. Where are you looking in Dashboards that you're not seeing how to accomplish this?

Dec 12 2016, 3:25 PM
epriestley updated subscribers of T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM
epriestley created T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM
Volans created T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 10:11 AM · Bug Report
ado9nai added Q534: can the admin set a dashboard as the defaut dashboard for everyone? (Answer 487).
Dec 12 2016, 9:25 AM
lewellyn edited P2025 Aphlict behind Apache.
Dec 12 2016, 4:16 AM
lewellyn created P2025 Aphlict behind Apache.
Dec 12 2016, 3:40 AM

Dec 11 2016

epriestley renamed T11957: Add MenuEngine to Home from Add PanelEngine to Dashboards to Add MenuEngine to Dashboards.
Dec 11 2016, 9:29 PM · Profile Menu Item, Dashboards
epriestley closed T11521: Request Review action should clear "accepted older" status as Resolved.

Oh, I think the edit to the title here is actually misleading, and the author in this scenario never used "Request Review" (this action is only available if the author has previously used "Plan Changes", which they did not appear to in this scenario).

Dec 11 2016, 9:06 PM · Restricted Project, Differential, Bug Report
lewellyn created P2024 My Nginx Configuration.
Dec 11 2016, 8:55 PM
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

I have a not-so-bad version of this in mind but it seems that the printer faxers are too terrified of our advanced defenses to even attack us any more.

Dec 11 2016, 8:41 PM · Abuse
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 6:54 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:51 PM · Profile Menu Item, Dashboards
chad added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

We have an identical ticket we plan to fix, definitely agree it's a bad experience.

Dec 11 2016, 5:38 PM · Bug Report
mbm added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

Okay then, I thought this was a bug as it didn't seem to make sense for me as a user. Sorry for taking up your time.

Dec 11 2016, 5:37 PM · Bug Report
chad merged T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard into T8033: Inform editor when panels have more restrictive policy than dashboard.
Dec 11 2016, 5:33 PM · Dashboards
chad merged task T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard into T8033: Inform editor when panels have more restrictive policy than dashboard.
Dec 11 2016, 5:33 PM · Bug Report
chad added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

This is expected behavior. We want to show an error instead of just vanishing the widget.

Dec 11 2016, 5:32 PM · Bug Report
mbm created T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.
Dec 11 2016, 5:30 PM · Bug Report
cspeckmim added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

@rscircus - this task (like I assume most tasks here) needs paid prioritization to move forward. see https://secure.phabricator.com/w/prioritization/

Dec 11 2016, 5:23 PM · Lint, Arcanist
chad closed T11990: Outline is invisible on submit buttons as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 5:21 PM · Design, Bug Report
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:08 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:03 PM · Profile Menu Item, Dashboards
epriestley closed T11980: Links to external systems as Wontfix.
  • Systems integrated with Doorkeeper (JIRA, Asana, some prototype GitHub support) already get URIs marked up.
  • The current JIRA integration does cover JIRA URIs in all remarkup systems, including Phriction and Maniphest, although you can not link to multiple JIRA installs until T6703, and you must use full URIs (if you use JIRA-123, it's possible that multiple linked installs have project namespaces called "JIRA"). It's possible we'll support this more naturally in the future, but not until after T6703, which is a very low priority.
  • Custom markup rules already supported (see P1157, P1209 for some examples), although you're on your own to write them. These are probably the best fit for your use case.
  • I believe needs for this sort of thing are often very specialized, so I do not currently plan to add any kind of generic, configurable remarkup rule that just matches arbitrary regexps against stuff and links them. You could write such a rule as an extension. One caveat to this is that we currently have bugtraq.url and bugtraq.logregex, which sort of work like this, except in a bad way. I'd like to remove them in the future, but there's an outside possibility that we'll replace them with a more flexible system like the one you describe.
Dec 11 2016, 4:56 PM · Remarkup, Feature Request
epriestley closed T11995: Fatal error while saving global default preferences as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · User Preferences, Bug Report
epriestley closed T11993: New install errors out before "run storage upgrade" message as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11993: New install errors out before "run storage upgrade" message.

Thanks!

Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley claimed T11993: New install errors out before "run storage upgrade" message.
Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11995: Fatal error while saving global default preferences.

Thanks! Yeah, this was just some editing/testing slop on my part. Your suggested fix is correct.

Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley claimed T11995: Fatal error while saving global default preferences.
Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley closed T11994: 'Affected files' doesn't work in 'Commits' Herald rules as Resolved.
Dec 11 2016, 3:18 PM · Bug Report (Needs Information)
epriestley added a revision to T11993: New install errors out before "run storage upgrade" message: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · Bug Report, Installing & Upgrading
epriestley added a revision to T11995: Fatal error while saving global default preferences: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · User Preferences, Bug Report
Info-Screen awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Like token.
Dec 11 2016, 12:45 PM
ado9nai updated Q534: can the admin set a dashboard as the defaut dashboard for everyone? from to can the admin set a dashboard as the defaut dashboard for everyone?.
Dec 11 2016, 10:06 AM
ado9nai added a comment to Q532: how can i config the homepage layerout (Answer 486).

can admin set a dashboard as the defaut dashboard for everyone?

Dec 11 2016, 10:05 AM
lewellyn created T11995: Fatal error while saving global default preferences.
Dec 11 2016, 9:17 AM · User Preferences, Bug Report
razvanm added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

This issue was solved by updating to the latest everything. I apologize for the noise. :-(

Dec 11 2016, 9:03 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

Here's the same rule with test console:
https://secure.phabricator.com/herald/transcript/185171/

Dec 11 2016, 8:26 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

(We don't maintain two code paths for Herald / Test Console)

Dec 11 2016, 8:18 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

Please complete the bug report first.

Dec 11 2016, 8:08 AM · Bug Report (Needs Information)
razvanm added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

The transcript you are pointing doesn't seem to be obtained using Test Console. Can you try using that?

Dec 11 2016, 8:04 AM · Bug Report (Needs Information)
chad edited projects for T11994: 'Affected files' doesn't work in 'Commits' Herald rules, added: Bug Report (Needs Information); removed Bug Report.
Dec 11 2016, 7:54 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

I tried the following, specifically:

Dec 11 2016, 7:52 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

Please read Contributing Bug Reports and fill in all required information for a bug report. Thanks!

Dec 11 2016, 7:39 AM · Bug Report (Needs Information)
rscircus added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

It seems, this task/problem has truly no priority, as @epriestley mentioned in his task description already. After skimming through related T5055, that idea reminded me of https://aur.archlinux.org/.

Dec 11 2016, 6:44 AM · Lint, Arcanist
lewellyn edited P2023 Alternate File Domain, plus Let's Encrypt.
Dec 11 2016, 5:51 AM
lewellyn created P2023 Alternate File Domain, plus Let's Encrypt.
Dec 11 2016, 5:50 AM
razvanm created T11994: 'Affected files' doesn't work in 'Commits' Herald rules.
Dec 11 2016, 4:53 AM · Bug Report (Needs Information)
chad added a revision to T11990: Outline is invisible on submit buttons: Unknown Object (Differential Revision).
Dec 11 2016, 12:58 AM · Design, Bug Report
• Gadget0624 added a comment to T11993: New install errors out before "run storage upgrade" message.

Dec 11 2016, 12:48 AM · Bug Report, Installing & Upgrading
chad added a comment to T11990: Outline is invisible on submit buttons.

Yeah, seems to be a bug in Chrome. I would follow up with them. There is no correct means to style it in Ubuntu, just some hacks.

Dec 11 2016, 12:46 AM · Design, Bug Report
• Gadget0624 awarded T11993: New install errors out before "run storage upgrade" message a Like token.
Dec 11 2016, 12:46 AM · Bug Report, Installing & Upgrading
chad added a comment to T11992: daemon hits policy exception repeatedly.

(Feel free to follow up with reproduction steps once you've sorted everything out)

Dec 11 2016, 12:09 AM · Daemons, Policy, Bug Report
chad closed T11992: daemon hits policy exception repeatedly as Invalid.

You have to be up to date and you must provide reproduction information in order to file a bug report. Please use Ponder otherwise. Thanks!

Dec 11 2016, 12:02 AM · Daemons, Policy, Bug Report

Dec 10 2016

avivey created T11993: New install errors out before "run storage upgrade" message.
Dec 10 2016, 11:35 PM · Bug Report, Installing & Upgrading
• sshannin updated the task description for T11992: daemon hits policy exception repeatedly.
Dec 10 2016, 11:31 PM · Daemons, Policy, Bug Report