Page MenuHomePhabricator
Feed All Stories

Nov 10 2016

avivey added a comment to T11849: Commit is no longer reachable.

What's unclear?

Nov 10 2016, 10:37 PM · Bug Report (Needs Information)
chad reopened T11837: Phabricator sometimes sends mail that it shouldn't as "Open".
Nov 10 2016, 10:34 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Hmm yeah, we record where in the workboard card is in the list, sticky. We could probably ignore that transaction.

Nov 10 2016, 10:31 PM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

OK. The type of the other transaction is subpriority. From the database:

Nov 10 2016, 10:29 PM · Bug Report
jsturgeon created T11849: Commit is no longer reachable.
Nov 10 2016, 10:24 PM · Bug Report (Needs Information)
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Initialisation doesn't seem to fit the pattern, as I would have expected an earlier column change to trigger it if that would. There are also over a dozen transactions on the timeline of this task before the section I pasted here, including comments (one deleted; I wonder if that's relevant), column changes, reassignments, and status changes.

Nov 10 2016, 10:06 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

There might be some crazy edge case of empty custom field that was previously hidden in a custom form and is being initialized for the first time, but not generating a visible transaction, so is getting lumped under "other". Hard to say, I can't really recreate how this might happen. Do you have "other" email sent to "on" but everything else "off" ? Knowing those would be important in a reproduction case as well.

Nov 10 2016, 9:52 PM · Bug Report
isfs added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Yes, both. I don't see how either of those could be involved with a column change, though, could it? Changes to our custom field do show on the timeline, too, but nothing is showing here.

Nov 10 2016, 9:50 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

Do you have custom fields or custom forms?

Nov 10 2016, 9:39 PM · Bug Report
isfs updated the task description for T11837: Phabricator sometimes sends mail that it shouldn't.
Nov 10 2016, 9:21 PM · Bug Report
isfs changed the status of T11837: Phabricator sometimes sends mail that it shouldn't from Resolved to Invalid.

I wouldn't call this resolved. Invalid may be most relevant, as with no STR, we can't confirm or action this.

Nov 10 2016, 9:21 PM · Bug Report
avivey added a project to T10405: Phabricator should generally work properly even if "gd" is not installed: Setup.
Nov 10 2016, 9:17 PM · Setup, Restricted Project
epriestley moved T7643: Improve prose diffs (was: description changes don't generate usable diffs) from The Queue to Paused on the Prioritized board.

I believe this is now in reasonable shape, in the sense that the overwhelming majority of prose inputs I'm aware of produce reasonable, human-readable diffs. They aren't perfect in all cases and aren't necessarily the diffs that a human would produce, but they're useful and fairly sensible.

Nov 10 2016, 8:57 PM · Prioritized, Transactions
chad added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

unit tests ftw

Nov 10 2016, 8:49 PM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

That seemed to just work? Slightly disconcerting.

Nov 10 2016, 8:42 PM · Prioritized, Transactions
jsturgeon updated Q511: Help debugging: EXCEPTION: (Exception) Can't parse an empty diff! at [<arcanist>/src/parser/ArcanistDiffParser.php:191] from to Help debugging: EXCEPTION: (Exception) Can't parse an empty diff! at [<arcanist>/src/parser/ArcanistDiffParser.php:191].
Nov 10 2016, 8:39 PM
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Nov 10 2016, 8:36 PM · Prioritized, Transactions
jcox added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Pretty sure this works as intended

Nov 10 2016, 8:08 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Look at how much engagement we're generating!

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

comments

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

more

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

need

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

still

Nov 10 2016, 8:05 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I would edit my comment to put a paragraph of text above the autoplay audio, but newsfeed caches the old comment. :3

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

I think we can safely conclude that autoplay audio in feed is an effective mechanism for disseminating important information.

Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad moved T11845: Media with "autoplay" should possibly not autoplay in news feed from Backlog to Rugged Terrain on the Prioritized board.
Nov 10 2016, 8:04 PM · Prioritized, Remarkup
chad added a project to T11845: Media with "autoplay" should possibly not autoplay in news feed: Prioritized.
Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad raised the priority of T11845: Media with "autoplay" should possibly not autoplay in news feed from Low to High.
Nov 10 2016, 8:03 PM · Prioritized, Remarkup
epriestley added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

Sure seems to be a lot of activity that generates feed stories on this task!

Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad added a comment to T11845: Media with "autoplay" should possibly not autoplay in news feed.

@epriestley FYI

Nov 10 2016, 8:03 PM · Prioritized, Remarkup
chad assigned T11845: Media with "autoplay" should possibly not autoplay in news feed to epriestley.
Nov 10 2016, 8:02 PM · Prioritized, Remarkup
chad awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Pirate Logo token.
Nov 10 2016, 8:02 PM · Prioritized, Remarkup
thoughtpolice awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a 100 token.
Nov 10 2016, 7:56 PM · Prioritized, Remarkup
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Y So Serious token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
eadler added a project to T5000: Using Differential with plain Git, without requiring Arc: FreeBSD.
Nov 10 2016, 7:52 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
jcox awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Party Time token.
Nov 10 2016, 7:52 PM · Prioritized, Remarkup
yelirekim awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Party Time token.
Nov 10 2016, 7:51 PM · Prioritized, Remarkup
avivey awarded T11845: Media with "autoplay" should possibly not autoplay in news feed a Manufacturing Defect? token.
Nov 10 2016, 7:50 PM · Prioritized, Remarkup
epriestley created T11845: Media with "autoplay" should possibly not autoplay in news feed.
Nov 10 2016, 7:48 PM · Prioritized, Remarkup
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 7:47 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

{auto-playing-audio WilhelmScream.mp3}

Nov 10 2016, 7:43 PM · Quicksand, Bug Report
epriestley added a project to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled: Quicksand.

Welcome to the wonderful, spooky world of Quicksand.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Yes I did have the persistent chat pane open. Also can't seem to repro without it.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
chad added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Quicksand

Nov 10 2016, 7:39 PM · Quicksand, Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

We still do a pretty questionable job on the first case in T7643#180264, where a comma is removed from the middle of a sentence.

Nov 10 2016, 7:36 PM · Prioritized, Transactions
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Do you have the persistent chat pane open?

Nov 10 2016, 7:22 PM · Quicksand, Bug Report
avivey added a comment to Q510: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.

I suspect this is a problem with the way you've installed phabricator.

Nov 10 2016, 7:01 PM
20after4 awarded Blog Post: Encouraging Open Source Etiquette a Love token.
Nov 10 2016, 6:42 PM
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

I suppose an alternate path is to enable Dashboards on Project homepages, and you can embed your project wiki or text panel for a really cool long description and information.

Nov 10 2016, 6:23 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Would you fill out at least, like, 5 of them?

Nov 10 2016, 6:21 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Hovercards, Search, Browse, etc. It could get used.

Nov 10 2016, 6:20 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

We could call it "Search Description" so it feels clear that it only displays in some UIs.

Nov 10 2016, 6:19 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Yeah, I think it's pretty reasonable if people would actually fill it out. We could surface it in a few other places too (e.g., /projects/) without fallback. It just seems like there's a decent chance no one will ever fill it out and it will sort of just be cluttering up the UI. But the cost on our side is pretty small, so if some people claim that they'd probably want to fill it out I'm happy to move forward with it.

Nov 10 2016, 6:18 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
chad added a project to T11761: Return to previous page after exiting high security mode: Security.
Nov 10 2016, 6:12 PM · Security
chad added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Provide an alternate, text-only field for "Project summary in typehaead results." which users only enter text into, so we don't have to worry about remarkup.

Nov 10 2016, 6:10 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley moved T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier from The Queue to Paused on the Prioritized board.

For reference, here's the current state of "discovery" downstream:

Nov 10 2016, 5:49 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley claimed T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Nov 10 2016, 5:13 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley removed a project from T9379: Build Phriction v3: Prioritized.

I'm going to kick this out of the queue for now and we'll reconsider it alongside other internal priorities once the queue clears. I think it's probably secondary to Conpherence now, at least, product-roadmap-wise, maybe?

Nov 10 2016, 5:12 PM · Phriction
epriestley removed a project from T9303: Improve Phacility Onboarding/NUX: Prioritized.

I'm going to kick this out of the queue for now and we can re-evaluate our internal priorities once the queue clears -- we got a decent iteration out and it looks like the next steps on NUX are probably a fair chunk of work.

Nov 10 2016, 5:10 PM · Phacility
epriestley removed a project from T7789: Support Git Large File Storage: Prioritized.

The driving install dropped off the grid a while ago, so this is no longer prioritized.

Nov 10 2016, 5:09 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from The Queue to Paused on the Prioritized board.

I believe this is now resolved, in the sense that I expect all specific, reproducible examples I'm aware of function in a way consistent with user expectation. In particular:

Nov 10 2016, 5:06 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T11839: Invalid translation for diffusion.uri.edit display as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 4:55 PM · Bug Report
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
Nov 10 2016, 4:37 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
jcox added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

The other errors that appear in DarkConsole:

pasted_file (276×920 px, 79 KB)

Nov 10 2016, 3:32 PM · Quicksand, Bug Report
jcox created T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 3:28 PM · Quicksand, Bug Report
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

I have some possible approaches for cheating on the "more than 100 results" case, but I think we ultimately need to put the prefix paging rule on the server side, so we return all prefix matches and then all content matches. That's kind of a big mess, but all the ways we can cheat will break down at some point (e.g., when you have 100 "wikidata" projects that are alphabetically earlier than "wikidata") so I think it's not avoidable.

Nov 10 2016, 2:58 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T4190: Rebuild remarkup image proxying.
  • Prototype applications must be enabled.
  • security.outbound-blacklist must not blacklist the target server (build servers may be on an internal network and on the default blacklist).
  • The link protocol must be "http" or "https".
  • You must not have exceeded your fetch quota for the last hour.
  • You must have file storage configured.
  • The image MIME type must be part of files.image-mime-types and files.viewable-mime-types.
  • The Phabricator server must be able to make outbound requests on the network.
Nov 10 2016, 2:57 PM · Contributor Onboarding, Remarkup
nochum added a comment to T4190: Rebuild remarkup image proxying.

(But note that it's cached for a trillion years, so it won't work for build status.)

Nov 10 2016, 2:53 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.
{img https://static-cdn.jtvnw.net/jtv_user_pictures/doritos-profile_image-4328d01909178d94-300x300.png}
Nov 10 2016, 2:51 PM · Contributor Onboarding, Remarkup
nochum added a comment to T4190: Rebuild remarkup image proxying.

Does the {img } thing work yet? I've been trying to use it locally but have not been able to get it to actually show an image. This would be super useful for us to be able to show the build status on a remarkup page (like the README.MD of our repo, for example). Thanks.

Nov 10 2016, 2:49 PM · Contributor Onboarding, Remarkup
jcox placed T8628: Modernize AphrontControllers to implement handleRequest up for grabs.
Nov 10 2016, 2:41 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox moved T8628: Modernize AphrontControllers to implement handleRequest from Basic to Ready on the Contributor Onboarding board.
Nov 10 2016, 2:40 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley moved T5267: Localize Phabricator from The Queue to Paused on the Prioritized board.

Pausing this from our perspective since we're waiting on guidance to move forward.

Nov 10 2016, 2:39 PM · Prioritized, Localization
epriestley added a parent task for T11050: Allow resigning from a review you are not directly responsible for: T10967: Move Differential reviewers back to a dedicated database storage table.
Nov 10 2016, 2:34 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a subtask for T10967: Move Differential reviewers back to a dedicated database storage table: T11050: Allow resigning from a review you are not directly responsible for.
Nov 10 2016, 2:34 PM · Restricted Project, Infrastructure, Differential
epriestley closed T11752: Drydock worker tasks should have higher priority as Resolved.

Presuming this is resolved since it hasn't been updated in about a month, but let us know if it's still an issue after the update.

Nov 10 2016, 2:33 PM · Drydock
epriestley claimed T11839: Invalid translation for diffusion.uri.edit display.

D16837 should clean this up. Thanks for the thorough report!

Nov 10 2016, 2:21 PM · Bug Report
epriestley added a revision to T11839: Invalid translation for diffusion.uri.edit display: Unknown Object (Differential Revision).
Nov 10 2016, 2:21 PM · Bug Report
epriestley added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

Some discussion of current context in T10448#186240.

Nov 10 2016, 2:18 PM · Customer Impact, Restricted Project, Mail
epriestley merged T11842: Create notification option for "someone mentions me" into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Nov 10 2016, 2:16 PM · Customer Impact, Restricted Project, Mail
epriestley merged task T11842: Create notification option for "someone mentions me" into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Nov 10 2016, 2:16 PM
epriestley added a comment to T7577: Improve username mention rules for Conpherence.

Oh, no, T7579 / T7580 are very slightly different. These probably do need updates at some point but I'll leave 'em for now

Nov 10 2016, 2:14 PM · Conpherence (v4)
epriestley added a comment to T7577: Improve username mention rules for Conpherence.

I'm going to merge this into T7580 since I think that's the same task?

Nov 10 2016, 2:13 PM · Conpherence (v4)
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

I added "Mentions" (and "Mocks") recently in connection with T4788.

Nov 10 2016, 2:10 PM · Restricted Project, FreeBSD, Maniphest
TiTi added a comment to T11539: Phabricator Mercurial Repo “too many files open” error.

Just had this issue today on our mercurial repository. Exact same exception when executing ./bin/repository update --trace <repository>
I've managed to solve it.

Nov 10 2016, 2:01 PM · Bug Report
huangsj added a comment to T7821: Phabricator full text search not working with mysql/elasticsearch .

@chad
I configure my Phabricator instance's MySQL with ngram fulltext parser and I can search CJK with mysql fulltext engine.

Nov 10 2016, 1:47 PM
jcox created T11842: Create notification option for "someone mentions me".
Nov 10 2016, 1:01 PM
chad closed T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade as Resolved.
Nov 10 2016, 6:11 AM · Bug Report
constantx added a comment to T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.

ah, seems like a restart of apache fixed it.

Nov 10 2016, 6:08 AM · Bug Report
constantx created T11841: Unhandled Exception ("AphrontSchemaQueryException") after upgrade.
Nov 10 2016, 6:02 AM · Bug Report
gshe updated Q510: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4 from to All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.
Nov 10 2016, 4:53 AM
constantx awarded T8442: Build Space switching UI a Love token.
Nov 10 2016, 4:49 AM · Restricted Project, Spaces, Wikimedia, Policy
chad added a comment to T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.

(Please ask general admin questions like this in Ponder).

Nov 10 2016, 4:15 AM · Setup, Bug Report
chad closed T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4 as Invalid.

We unfortunately do not take installation questions as bug reports. We're happy to assist with our Phacility Consulting if you need or use Support Resources.

Nov 10 2016, 4:14 AM · Setup, Bug Report
avivey added a comment to T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.

In the phabricator directory, what does file bin/config say?

Nov 10 2016, 4:11 AM · Setup, Bug Report
gshe created T11840: All the Phabricator commands cannot run under server SUSE Enterprise 11 SP4.
Nov 10 2016, 4:09 AM · Setup, Bug Report
lewellyn updated the task description for T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:36 AM · Bug Report
lewellyn updated the task description for T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:35 AM · Bug Report
lewellyn created T11839: Invalid translation for diffusion.uri.edit display.
Nov 10 2016, 2:34 AM · Bug Report
epriestley closed T11829: Fix all the circles as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 1:13 AM · Design