Page MenuHomePhabricator
Feed All Stories

Nov 10 2016

epriestley added a revision to T11829: Fix all the circles: Unknown Object (Differential Revision).
Nov 10 2016, 1:11 AM · Design
epriestley added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

This is sort-of-maybe related to T11482 but I'm also not exactly sure what's step in the process is slow here.

Nov 10 2016, 12:59 AM · Diffusion, Feature Request
epriestley closed T11833: "parent"/"child" relationship for Revisions is confusing as Wontfix.

I'm happy to change this if anyone comes up with good alternate wording, but I think this might be about the best we can do.

Nov 10 2016, 12:55 AM · Differential, Bug Report
epriestley added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

never mind I love the text area

Nov 10 2016, 12:54 AM · Setup
chad added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Also
this text
area sure
is
small now

Nov 10 2016, 12:53 AM · Setup
epriestley added a comment to E1209: Pull that into png.

Yeah, the upper-right action thing is a little weird since we don't use it in other applications, but it has felt OK to me once I kind of got used to it / continued being too lazy to change it.

Nov 10 2016, 12:53 AM
chad is attending E1209: Pull that into png.
Nov 10 2016, 12:51 AM
chad added a comment to E1209: Pull that into png.

Why can I subscribe to events? But not accept?

Nov 10 2016, 12:51 AM
epriestley changed the icon for E1209: Pull that into png from Default to Party.
Nov 10 2016, 12:51 AM
epriestley added a comment to E1209: Pull that into png.

Wouldn't miss it for the world!

Nov 10 2016, 12:50 AM
epriestley is attending E1209: Pull that into png.
Nov 10 2016, 12:50 AM
avivey created E1209: Pull that into png.
Nov 10 2016, 12:50 AM
epriestley triaged T11831: Add setup check for missing PCRE_UTF8 support as Wishlist priority.

This is probably the required test:

Nov 10 2016, 12:47 AM · Setup
avivey added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

Which interaction exactly is taking a long time?

Nov 10 2016, 12:44 AM · Diffusion, Feature Request
avivey closed T11792: Remove "No Highlighting" mode from Diffusion as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 12:40 AM · Diffusion, Bug Report
avivey added a revision to T11792: Remove "No Highlighting" mode from Diffusion: Unknown Object (Differential Revision).
Nov 10 2016, 12:33 AM · Diffusion, Bug Report

Nov 9 2016

epriestley closed T11836: Calendar Imports have the correct policy, but that policy is unclear, a subtask of T11809: Calendar v1 Errata Mark II, as Resolved.
Nov 9 2016, 11:05 PM · Calendar
epriestley closed T11836: Calendar Imports have the correct policy, but that policy is unclear as Resolved by committing Restricted Diffusion Commit.
Nov 9 2016, 11:05 PM · Calendar
avivey added Q509: How to change the default Pinned Applications? (Answer 468).
Nov 9 2016, 8:55 PM
epriestley added a parent task for T11836: Calendar Imports have the correct policy, but that policy is unclear: T11809: Calendar v1 Errata Mark II.
Nov 9 2016, 8:24 PM · Calendar
epriestley added a subtask for T11809: Calendar v1 Errata Mark II: T11836: Calendar Imports have the correct policy, but that policy is unclear.
Nov 9 2016, 8:24 PM · Calendar
epriestley edited projects for T11836: Calendar Imports have the correct policy, but that policy is unclear, added: Calendar; removed Bug Report.
Nov 9 2016, 8:24 PM · Calendar
epriestley added a revision to T11836: Calendar Imports have the correct policy, but that policy is unclear: Unknown Object (Differential Revision).
Nov 9 2016, 8:17 PM · Calendar
chad closed T11838: libphutil made call to undefined function id(), fataling on Windows as Resolved.

whew! good to hear.

Nov 9 2016, 6:06 PM · Bug Report
cxzzero added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

Definitely there was a problem with the installation, for some reason the files got corrupted and downloading a fresh installation solved the problem.

Nov 9 2016, 5:56 PM · Bug Report
epriestley renamed T11836: Calendar Imports have the correct policy, but that policy is unclear from Calendar Imports have the wrong policy set to Calendar Imports have the correct policy, but that policy is unclear.
Nov 9 2016, 5:39 PM · Calendar
cxzzero added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

Thanks chad. I will check if there is a problem with the installation and let you know.

Nov 9 2016, 5:18 PM · Bug Report
remusvrm added a comment to Q509: How to change the default Pinned Applications? (Answer 467).

Hi @kislinsk
Thanks for your answer! Sorry, I wasn't speciffic, I would like to change the default Home Page Pinned Applications for everybody. Is it possible?

Nov 9 2016, 5:18 PM
chad added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Great!

Nov 9 2016, 4:53 PM · Setup
chad closed T11837: Phabricator sometimes sends mail that it shouldn't as Resolved.

Closing as Resolved since this doesn't seem actionable by the upstream without concrete reproducible steps.

Nov 9 2016, 4:48 PM · Bug Report
chad added a comment to T11837: Phabricator sometimes sends mail that it shouldn't.

/mail/ will tell you why you received any given mail.

Nov 9 2016, 4:44 PM · Bug Report
chad added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

We need to know how to reproduce bugs in order to fix them. Please take the time to give us all information needed about your environment so we can reproduce the bug. Id() missing means something is dramatically wrong with your installation, as no part of Phabricator is expected to run without access to libphutil and its functions.

Nov 9 2016, 4:16 PM · Bug Report
cxzzero added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

For me seems to be quite good the information provided, but I try to explain myself with more details:

Nov 9 2016, 4:00 PM · Bug Report
chad added a comment to T11838: libphutil made call to undefined function id(), fataling on Windows.

This report doesn't look to include reproduction information.

Nov 9 2016, 3:28 PM · Bug Report
kislinsk added Q509: How to change the default Pinned Applications? (Answer 467).
Nov 9 2016, 2:34 PM
remusvrm updated Q509: How to change the default Pinned Applications? from to How to change the default Pinned Applications?.
Nov 9 2016, 2:09 PM
adam93 awarded T3498: Allow ignore whitespace in Audit/Diffusion diffs a Like token.
Nov 9 2016, 1:27 PM · Diffusion
cxzzero created T11838: libphutil made call to undefined function id(), fataling on Windows.
Nov 9 2016, 12:40 PM · Bug Report
isfs created T11837: Phabricator sometimes sends mail that it shouldn't.
Nov 9 2016, 10:37 AM · Bug Report
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Yes, i manually built the pcre, enable utf8 and unicode properties.
this issue was resolved.
thanks.

Nov 9 2016, 10:26 AM · Setup
remusvrm updated Q508: Way it is not possible to add members to Milestone/Subproject? from to Way it is not possible to add members to Milestone/Subproject?.
Nov 9 2016, 10:19 AM
chad added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Eventually building a setup check is the extent of our support here. You'll have to build/enable UTF-8 support for your system on your own.

Nov 9 2016, 5:02 AM · Setup
chad edited projects for T11831: Add setup check for missing PCRE_UTF8 support, added: Setup; removed Bug Report.
Nov 9 2016, 4:37 AM · Setup
chad renamed T11831: Add setup check for missing PCRE_UTF8 support from Remarkup (Rich Edit Text content view) cannot display under SUSE Enterprise 11 SP3 to Add setup check for missing PCRE_UTF8 support.
Nov 9 2016, 4:37 AM · Setup
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.
pcretest -C

PCRE version 8.10 2010-06-25
Compiled with

No UTF-8 support
No Unicode properties support
Newline sequence is LF
\R matches all Unicode newlines
Internal link size = 2
POSIX malloc threshold = 10
Default match limit = 10000000
Default recursion depth limit = 10000000
Match recursion uses stack
Nov 9 2016, 3:46 AM · Setup
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

I open the debug mode, on console, i found errors:
preg_replace_callback(): Compilation failed: this version of PCRE is not compiled with PCRE_UTF8 support at offset 0
Stack trace:
preg_replace_callback called at [/lv_code/phabricator/phabricator/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php:189]
PhabricatorObjectRemarkupRule::apply called at [/lv_code/phabricator/libphutil/src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockRule.php:78]
PhutilRemarkupBlockRule::applyRules called at [/lv_code/phabricator/libphutil/src/markup/engine/remarkup/blockrule/PhutilRemarkupDefaultBlockRule.php:17]
PhutilRemarkupDefaultBlockRule::markupText called at [/lv_code/phabricator/libphutil/src/markup/engine/PhutilRemarkupEngine.php:232]
PhutilRemarkupEngine::markupBlock called at [/lv_code/phabricator/libphutil/src/markup/engine/PhutilRemarkupEngine.php:128]
PhutilRemarkupEngine::preprocessText called at [/lv_code/phabricator/phabricator/src/infrastructure/markup/PhabricatorMarkupEngine.php:269]
PhabricatorMarkupEngine::loadPreprocessorCaches called at [/lv_code/phabricator/phabricator/src/infrastructure/markup/PhabricatorMarkupEngine.php:133]
PhabricatorMarkupEngine::process called at [/lv_code/phabricator/phabricator/src/infrastructure/markup/PhabricatorMarkupEngine.php:73]
PhabricatorMarkupEngine::renderOneObject called at [/lv_code/phabricator/phabricator/src/applications/phriction/controller/PhrictionMarkupPreviewController.php:23]
PhrictionMarkupPreviewController::processRequest called at [/lv_code/phabricator/phabricator/src/aphront/AphrontController.php:29]
AphrontController::handleRequest called at [/lv_code/phabricator/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:257]
AphrontApplicationConfiguration::processRequest called at [/lv_code/phabricator/phabricator/src/aphront/configuration/AphrontApplicationConfiguration.php:169]
AphrontApplicationConfiguration::runHTTPRequest called at [/lv_code/phabricator/phabricator/webroot/index.php:17]

Nov 9 2016, 3:46 AM · Setup

Nov 8 2016

epriestley added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

The policies work like you expect them to. This is just like a revision saying "All Users" but not being visible to users who can't see the corresponding repository.

Nov 8 2016, 10:19 PM · Calendar
hach-que added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

I think it makes more sense to have events inherit their policy from the import that created them (if they are imported events)? i.e. rather than copy policy settings on import, make the policy pull from the import similar to other systems (like how "build target" view policy is pulled from the "build" view policy).

Nov 8 2016, 10:10 PM · Calendar
hach-que added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

But yeah, it is 100% not good to show this:

Nov 8 2016, 10:08 PM · Calendar
hach-que added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

Okay, so I ended up having to restart my Phabricator instance to get the import to stop, then "Delete Imported Events" seemed to work right even though it took a reasonably long time to complete from the web UI (I feel like it should really be using the bulk operation infrastructure).

Nov 8 2016, 10:07 PM · Calendar
hach-que added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

Oh god it's still importing even after I disabled the import and deleted events.

Nov 8 2016, 10:01 PM · Calendar
hach-que created T11836: Calendar Imports have the correct policy, but that policy is unclear.
Nov 8 2016, 9:57 PM · Calendar
• willson556 added a project to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded.: Diffusion.
Nov 8 2016, 9:52 PM · Diffusion, Feature Request
• willson556 created T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..
Nov 8 2016, 9:51 PM · Diffusion, Feature Request
epriestley closed T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode as Resolved by committing Restricted Diffusion Commit.
Nov 8 2016, 9:27 PM · Clusters, NUX, Phacility, Bug Report
epriestley added a revision to T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode: Unknown Object (Differential Revision).
Nov 8 2016, 9:21 PM · Clusters, NUX, Phacility, Bug Report
epriestley claimed T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode.

It's just very
important to
thoroughly explore
the applications

Nov 8 2016, 9:19 PM · Clusters, NUX, Phacility, Bug Report
thoughtpolice created T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode.
Nov 8 2016, 9:03 PM · Clusters, NUX, Phacility, Bug Report
avivey added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

In my case (T9287), the dependencies are cross-repository, which I don't think we can reasonably automatically figure out.

Nov 8 2016, 7:59 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

(If we were better about figuring this out automatically -- which we may be soon -- would it be a problem at all?)

Nov 8 2016, 7:55 PM · Differential, Bug Report
avivey added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

The distinction between "Earlier Revisions" and "Earlier Versions of This Revision" (e.g., earlier diffs) seems potentially confusing to me. That is, I could imagine a new user thinking "Earlier Revisions" meant "earlier versions of this change", not "prior changes which this change depends on".

Nov 8 2016, 7:52 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

The distinction between "Earlier Revisions" and "Earlier Versions of This Revision" (e.g., earlier diffs) seems potentially confusing to me. That is, I could imagine a new user thinking "Earlier Revisions" meant "earlier versions of this change", not "prior changes which this change depends on".

Nov 8 2016, 7:51 PM · Differential, Bug Report
avivey added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

"Earlier" / "Later" ?

Nov 8 2016, 7:50 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

Or, of course, we could do:

Nov 8 2016, 7:49 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

I think there was no web UI for this until T4788, which added both options. Prior to that, the only way to mark dependencies was by writing "Depends On" in text (which still works). So we didn't previously have anything else, unless I'm misremembering.

Nov 8 2016, 7:47 PM · Differential, Bug Report
avivey added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

(I've asked a wordsmaster for help, so maybe we'll have better ideas soonish).

Nov 8 2016, 7:45 PM · Differential, Bug Report
avivey added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

I was used to the "dependency" ones we had, but I agree they're not really unconfusing enough.

Nov 8 2016, 7:40 PM · Differential, Bug Report
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
Nov 8 2016, 7:40 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

Our use of "parent" and "child" are consistent with Git's use of "parent" and "child", if that helps: for example, git help log discusses the ideas of "parent commits" and "child commits" in many places, and "parent revisions" and "child revisions" have the same relationship order as commits do in Git.

Nov 8 2016, 7:37 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

What specific, totally unambiguous labels would you prefer these actions to have?

Nov 8 2016, 7:33 PM · Differential, Bug Report
avivey updated the task description for T11833: "parent"/"child" relationship for Revisions is confusing.
Nov 8 2016, 7:12 PM · Differential, Bug Report
avivey created T11833: "parent"/"child" relationship for Revisions is confusing.
Nov 8 2016, 7:06 PM · Differential, Bug Report
chad added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

The Phabricator versions you listed above are also not current. Just a reminder we only take bug reports at HEAD.

Nov 8 2016, 5:48 PM · Setup
chad added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Bug reports like this are exceedingly resource intensive on the upstream and as stated, we are unlikely to look into for many years if ever. I'd be happy to accept this bug if you can duplicate the bug in a new, clean, environment and completely list out all components needed to reproduce it. Overall as no one else is reporting this, it is likely an environmental issue - so understanding what is unique in your environment vs everywhere else Phabricator is installed is important. Things to look at:

Nov 8 2016, 5:47 PM · Setup
epriestley added a comment to T5267: Localize Phabricator.

Sounds good, thanks!

Nov 8 2016, 5:42 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

In other words is your array syntax always messagekey[gender][plural] or could it also be messagekey[plural][plural] depending on the variables?

We support unlimited gender/plural variants in any order. We have a number of strings like this:

Nov 8 2016, 5:41 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

%s cannot be repeated as far as I know.

Nov 8 2016, 4:32 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:16 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

When multiple variants exist, should we export a nested structure like this?

[...]

Nov 8 2016, 3:56 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 3:31 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.
"aBmeIEk": {
    "one": "%s star",
    "other": "%s stars"
},
Nov 8 2016, 3:22 PM · Prioritized, Localization
Nikerabbit added a comment to T5267: Localize Phabricator.

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

At least some translators are likely familiar with $1, {{GENDER:$1|X|Y}}, and so on, right? And you have documentation on this syntax to help translators who aren't familiar with it learn it?

Nov 8 2016, 3:03 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 2:50 PM · Prioritized, Localization
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

you can check this page, it is original phabricator page, it also cannot show in my server.
maybe the remarkup engine cannot work in my server, i don't know how to resolve it.

Nov 8 2016, 2:40 PM · Setup
epriestley added a comment to T5267: Localize Phabricator.

Here are the current internal data formats:

Nov 8 2016, 2:21 PM · Prioritized, Localization
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

10.12.40.png (538×1 px, 91 KB)

this is the config error. i don't think it is the root cause.

Nov 8 2016, 2:13 PM · Setup
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Could you tell me how to check the server error?
i don't find the errors on server.

Nov 8 2016, 2:12 PM · Setup
cspeckmim added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

Ah yea my hypothesis doesn't make 100% sense given all the rest of the text in your screenshot. Are there errors on the server?

Nov 8 2016, 2:07 PM · Setup
gshe added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

i attached my saved webpage. The Text isn't existed the source code.

Nov 8 2016, 2:05 PM · Setup
• Amerr added a comment to T6653: Script and regex linter could use some examples.

For reference and the benefit of people Googling how to configure a script and regex linter, here is a full example (using sass-lint):

.arcconfig file:

{
"linters": {
    // snip ...
    "sass": {
          "type": "script-and-regex",
          "include": "(\\.scss$)",
          "script-and-regex.script": "sh -c 'sass-lint -v \"$0\" || true'",
          "script-and-regex.regex": "(^((?P<file>.+): line (?P<line>[0-9]+), col (?P<col>[0-9]+), (?P<severity>[^\\-]*) - (?P<message>.*) \\((?P<name>[a-z\\-]+)\\))$)m"
    }
}
Nov 8 2016, 2:04 PM · Lint, Documentation, Arcanist
epriestley added a comment to T5267: Localize Phabricator.

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

Nov 8 2016, 1:58 PM · Prioritized, Localization
cspeckmim added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

I don't know a thing about the web but looks like it might be a font issue. Presumably your setup has the monospaced font available for use in codeblocks, but not the regular text one.

Nov 8 2016, 1:13 PM · Setup
nileshgr added a comment to T11827: ssh-auth hangs on FreeBSD.

I'll have to update my instance first to test your patch, since it seems to be for newer version as you said earlier. I installed this from FreeBSD ports system, have to first convert it to normal git based install.

Nov 8 2016, 12:57 PM · Diffusion, Bug Report
epriestley closed T11830: ddz_test as Invalid.
Nov 8 2016, 12:22 PM
epriestley closed T11832: jkh as Invalid.
Nov 8 2016, 12:22 PM · Android
• zhenjianqi created T11832: jkh.
Nov 8 2016, 11:35 AM · Android
gshe created T11831: Add setup check for missing PCRE_UTF8 support.
Nov 8 2016, 10:47 AM · Setup
Nikerabbit added a comment to T5267: Localize Phabricator.

Some of the terms that I use below (e.g. outdated) are explained in https://www.mediawiki.org/wiki/Help:Extension:Translate/Glossary

Nov 8 2016, 9:35 AM · Prioritized, Localization