Page MenuHomePhabricator

Invalid translation for diffusion.uri.edit display
Closed, ResolvedPublic


If you set diffusion.uri.edit's display type to an invalid value (via Conduit), an error about an invalid translation occurs (as opposed to an error regarding an invalid value being provided).

In this case, I was providing a value of visible (to match the UI's value as the values don't seem to be documented elsewhere readily). For those wandering across this in the future, the correct value is always. :)

Reproduction steps:

$conduit->callMethodSynchronous('diffusion.uri.edit', array('transactions' => array(array('type' => 'display', 'value' => 'visible'), array('type' => 'repository', 'value' => $phid))));

Actual results:

Fatal error: Uncaught exception 'ConduitClientException' with message 'ERR-CONDUIT-CORE: Validation errors:
  - [Invalid Translation!] Value "%s" is not a valid display setting for this URI. Available types for this URI are: %s.' in /Users/Matthew/src/phabricator/libphutil/src/conduit/ConduitFuture.php:58
Stack trace:
#0 /Users/Matthew/src/phabricator/libphutil/src/future/FutureProxy.php(58): ConduitFuture->didReceiveResult(Array)
#1 /Users/Matthew/src/phabricator/libphutil/src/future/FutureProxy.php(35): FutureProxy->getResult()
#2 /Users/Matthew/src/phabricator/libphutil/src/conduit/ConduitClient.php(64): FutureProxy->resolve()
#3 /Users/Matthew/src/migration.php(105): ConduitClient->callMethodSynchronous('diffusion.uri.e...', Array)
#4 {main}
  thrown in /Users/Matthew/src/phabricator/libphutil/src/conduit/ConduitFuture.php on line 58

Expected results:

Either an error stating that the value was invalid or success, not an error about a translation issue with the error message.

Version Information:

phabricator d78802f3ab6572400b799f4aa1d7b21e1885e350 (Wed, Nov 9)
arcanist fad85844314b151994769a461825c90f7400c145 (Fri, Oct 21)
phutil c6634479d0f124b43a839a7ecbfaed434e710292 (Tue, Nov 8)