Page MenuHomePhabricator
Feed All Stories

Jan 6 2016

nochum added a comment to T9965: Don't require newline for Differential Revision autoclose magic.

@epriestley Can you reconsider this request now?

Jan 6 2016, 9:17 PM · Feature Request
Luke081515.2 created T10091: Expand syntax.
Jan 6 2016, 9:16 PM · Feature Request
jra3 added a revision to T8404: Running the cpplint linter through arcanist no longer works: Unknown Object (Differential Revision).
Jan 6 2016, 5:59 PM · Lint, Arcanist
epriestley closed T2451: Build a `diffusion.blame` Conduit method, a subtask of T2452: Implement "arc blame", as Resolved.
Jan 6 2016, 5:24 PM · Restricted Project, Arcanist, OS Students 2013
epriestley closed T2451: Build a `diffusion.blame` Conduit method as Resolved by committing Restricted Diffusion Commit.
Jan 6 2016, 5:24 PM · Diffusion, OS Students 2013
chad added a comment to T10090: Updating Herald rule throws Unhandled Exception.

What I created to test:

Jan 6 2016, 4:17 PM · Herald, Bug Report
chad added a comment to T10090: Updating Herald rule throws Unhandled Exception.

I can't reproduce this at HEAD. Are there more complete instructions we can follow?

Jan 6 2016, 4:15 PM · Herald, Bug Report
• alnet82 created T10090: Updating Herald rule throws Unhandled Exception.
Jan 6 2016, 3:36 PM · Herald, Bug Report
chad added a comment to Q260: Application E-Mail Addresses (Answer 295).

Does the user exist in Phabricator?

Jan 6 2016, 2:42 PM
epriestley added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Jan 6 2016, 2:20 PM · Diffusion
epriestley added a revision to T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Unknown Object (Differential Revision).
Jan 6 2016, 2:20 PM · Phacility, Diffusion, Phacility Support
epriestley added a revision to T2451: Build a `diffusion.blame` Conduit method: Unknown Object (Differential Revision).
Jan 6 2016, 1:17 PM · Diffusion, OS Students 2013
epriestley added a revision to T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion: Unknown Object (Differential Revision).
Jan 6 2016, 12:15 PM · Diffusion
epriestley moved T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion from Backlog to vNext on the Diffusion board.
Jan 6 2016, 11:12 AM · Diffusion
tycho.tatitscheff added a comment to Q264: Is there a way to fail "arc diff" if pushing to the staging repository fails? (Answer 296).

It can also happen when you configure stagging with ssh and you let the repository beeing clone with ssh and https !

Jan 6 2016, 8:58 AM
adam.mallinson added a comment to Q260: Application E-Mail Addresses (Answer 295).

Thanks Evan that was a great help. I have got that configured and working but how can i get it to send an e-mail with the ticket details to the person who submitted it?

Jan 6 2016, 8:25 AM
adam.mallinson reopened Q260: Application E-Mail Addresses.
Jan 6 2016, 8:22 AM · Mail, Maniphest
johnny-bit awarded T10084: Flag notes should be visible in object properties a Like token.
Jan 6 2016, 7:21 AM · Flags, Feature Request
hach-que added a comment to Q264: Is there a way to fail "arc diff" if pushing to the staging repository fails? (Answer 296).

Yes, it was because the SSH agent wasn't running (on Windows). I would have preferred to have it error and not submitted the diff, rather than having to do "arc diff" a second time to get the diff pushed to the staging repository.

Jan 6 2016, 6:46 AM
michaeljs1990 added Q264: Is there a way to fail "arc diff" if pushing to the staging repository fails? (Answer 296).
Jan 6 2016, 6:00 AM
hach-que updated Q264: Is there a way to fail "arc diff" if pushing to the staging repository fails? from to Is there a way to fail "arc diff" if pushing to the staging repository fails?.
Jan 6 2016, 3:59 AM · Arcanist
epriestley updated subscribers of T9084: Use a typeaheads for querying Object Types in Flags.

Flags currently has this unwieldy dropdown, which will only get worse over time as more applications and object types are added. It would be better to use a typeahead, like the one in global search:

Jan 6 2016, 3:25 AM · Contributor Onboarding, Flags
epriestley moved T9084: Use a typeaheads for querying Object Types in Flags from Backlog to vNext on the Flags board.
Jan 6 2016, 3:21 AM · Contributor Onboarding, Flags
epriestley triaged T9149: Flagging commits via Herald no longer generates flag note as Low priority.

I removed this because the implementation was pretty hacky (saved the rule as a text string, wasn't translatable).

Jan 6 2016, 3:21 AM · Restricted Project, Flags, Herald
epriestley moved T9149: Flagging commits via Herald no longer generates flag note from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Restricted Project, Flags, Herald
epriestley moved T10084: Flag notes should be visible in object properties from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Flags, Feature Request
chad added a comment to T10084: Flag notes should be visible in object properties.

good enough for me

Jan 6 2016, 3:12 AM · Flags, Feature Request
epriestley updated subscribers of T10084: Flag notes should be visible in object properties.

@chad, not sure if you have design thoughts here, but I think this is broadly reasonable.

Jan 6 2016, 3:09 AM · Flags, Feature Request
epriestley renamed T10084: Flag notes should be visible in object properties from Flag notes should be visible in Maniphest UI to Flag notes should be visible in object properties.
Jan 6 2016, 2:54 AM · Flags, Feature Request
epriestley closed T10085: Phabricator should ask if it should remove a flag when the flag's owner changes a task as Wontfix.

I think it's too hard for us to guess user intent here. There's nothing a user can do which strongly signals that their flag is obsolete, since flags mean a lot of different things (in your use case, it sounds like there's no single action you take which clears the flag, just "the next action after you added the flag"). Other users (myself included) use flags for different reasons, including as long-term bookmarks. Guessing intent is also difficult because you can flag many kinds of objects, not just tasks, and we'd strongly prefer features which can be implemented globally.

Jan 6 2016, 2:50 AM · Flags, Feature Request
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

Overall, the problems I currently see with watch/subscribe are:

Jan 6 2016, 2:30 AM · Projects, Bug Report
epriestley closed T10089: Unsubscribing from a Project seems to have no effect as Resolved by committing Restricted Diffusion Commit.
Jan 6 2016, 2:16 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

For the sake of completeness, the root issue you described elsewhere (unsubscribes cascading into more unsubscribes) is fixed (at least, indirectly) at HEAD, after 536d3a2, which stops self-subscribes and self-unsubscribes from publishing feed stories, mail, and notifications.

Jan 6 2016, 2:13 AM · Projects, Bug Report
epriestley claimed T10089: Unsubscribing from a Project seems to have no effect.
Jan 6 2016, 2:11 AM · Projects, Bug Report
epriestley added a revision to T10089: Unsubscribing from a Project seems to have no effect: Unknown Object (Differential Revision).
Jan 6 2016, 2:10 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

I don't currently plan to remove the option

Jan 6 2016, 1:57 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

Oh, by "remove the option" I meant "remove the option to subscribe to a project if you are not a member of the project" -- that is, "Subscribe" is disabled if you aren't a project member. I don't currently plan to remove the option, although I am leaning towards making members not be subscribed by default.

Jan 6 2016, 1:57 AM · Projects, Bug Report
chad reopened T10089: Unsubscribing from a Project seems to have no effect as "Open".

Ok, I misread T6113#83548 then, assume you wanted to remove the inconsistency by removing the ability for members to unsubscribe.

Jan 6 2016, 1:54 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

This isn't the same as T6183 or T6113, and isn't expected.

Jan 6 2016, 1:44 AM · Projects, Bug Report
chad added a comment to T10089: Unsubscribing from a Project seems to have no effect.

T6183 and T6113 are the relevant tasks I was able to dig up. Sounds like that option should just get removed?

Jan 6 2016, 1:27 AM · Projects, Bug Report
chad merged task T10089: Unsubscribing from a Project seems to have no effect into T6113: Unclear difference between "Watch Project" and "Subscribe".
Jan 6 2016, 1:24 AM · Projects, Bug Report
chad updated subscribers of T6113: Unclear difference between "Watch Project" and "Subscribe".
Jan 6 2016, 1:24 AM · Wikimedia, Guides, Projects
chad added a comment to T10089: Unsubscribing from a Project seems to have no effect.

You're required to verify bugs at HEAD. Please update your install.

Jan 6 2016, 1:17 AM · Projects, Bug Report
hach-que added a comment to T10084: Flag notes should be visible in object properties.

This would make flags actually useful. I think the last time I used them was years ago, and I've just been adding comments to tasks whenever I need to add personal reminders.

Jan 6 2016, 12:53 AM · Flags, Feature Request
hach-que awarded T10084: Flag notes should be visible in object properties a Like token.
Jan 6 2016, 12:52 AM · Flags, Feature Request
nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

This looks much better! Thanks!

Jan 6 2016, 12:34 AM · Drydock, Differential, Bug Report

Jan 5 2016

dgoldstein added a comment to T10088: ability to wontfix a maniphest task via an email command.

Mmm I didn't know that existed - will be super useful. Sorry for the bogus
task.

Jan 5 2016, 11:27 PM · Maniphest, Restricted Project, Feature Request
michaeljs1990 created T10089: Unsubscribing from a Project seems to have no effect.
Jan 5 2016, 11:17 PM · Projects, Bug Report
epriestley added a revision to T10088: ability to wontfix a maniphest task via an email command: Unknown Object (Differential Revision).
Jan 5 2016, 10:57 PM · Maniphest, Restricted Project, Feature Request
jhurwitz added a comment to T10088: ability to wontfix a maniphest task via an email command.

@dgoldstein, also, for future reference the way you find the list of email commands is to open an object of the type you care about (here, a task), click the circle/lifeboat thing, and then click "email commands."

Jan 5 2016, 10:52 PM · Maniphest, Restricted Project, Feature Request
epriestley closed T10088: ability to wontfix a maniphest task via an email command as Resolved.

wontfix.png (1×1 px, 217 KB)

Jan 5 2016, 10:50 PM · Maniphest, Restricted Project, Feature Request
dgoldstein created T10088: ability to wontfix a maniphest task via an email command.
Jan 5 2016, 10:48 PM · Maniphest, Restricted Project, Feature Request
hach-que added a comment to T5544: Implement EC2 blueprint for Drydock.

@epriestley Is there any capacity to get this Prioritized?

Jan 5 2016, 10:30 PM · Drydock
epriestley closed T8950: Mention moving hosted repositories in the "Backups and Migrations" documentation as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:03 PM · Diffusion, Documentation
epriestley closed T9192: Display import status / percentage on repository front page as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:03 PM · Diffusion
epriestley closed T9191: Display repository status (e.g. "importing") in search results as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:02 PM · Search, Diffusion
chad created M1455: Hovercard Explorations.
Jan 5 2016, 10:01 PM · Projects, Hovercards
epriestley closed T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException") as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 9:59 PM · Diffusion
CaptainOfCrush updated Q263: How to prevent sneaky changes pushed after review is approved? from to How to prevent sneaky changes pushed after review is approved?.
Jan 5 2016, 9:57 PM · Diffusion
epriestley added a comment to T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.

T4027 is another case of commits titled [JIRA-123] Blah blah blah.

Jan 5 2016, 9:53 PM · Remarkup
epriestley merged task T4027: Link commit header also to bugtraq url into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jan 5 2016, 9:52 PM · Remarkup, Diffusion
epriestley merged T4027: Link commit header also to bugtraq url into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jan 5 2016, 9:52 PM · Remarkup
epriestley closed T4159: Exceptions occurring in Diffusion which result in PHP-FPM worker processes crashing as Invalid.

This is very old, possibly fixed by now, doesn't include reproduction steps, and other users haven't reported issues. If you have specific issues with externals and reproduction steps, feel free to file new tasks.

Jan 5 2016, 9:50 PM · Diffusion
epriestley added a revision to T8950: Mention moving hosted repositories in the "Backups and Migrations" documentation: Unknown Object (Differential Revision).
Jan 5 2016, 9:42 PM · Diffusion, Documentation
epriestley added a revision to T9192: Display import status / percentage on repository front page: Unknown Object (Differential Revision).
Jan 5 2016, 9:37 PM · Diffusion
epriestley added a revision to T9191: Display repository status (e.g. "importing") in search results: Unknown Object (Differential Revision).
Jan 5 2016, 9:29 PM · Search, Diffusion
epriestley closed T5202: "Recent Commits" should include branch in title in Diffusion as Wontfix.

This is extremely old and I think no longer relevant. The crumbs now show the current branch, and I think Diffusion got better about consistently showing and retaining branches.

Jan 5 2016, 9:23 PM · Diffusion
epriestley added a comment to T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.

T5744 mentions another narrower and more reasonable use case (get specific badness which matches some pattern fixed), which is similar to the Mochi/i18n stuff.

Jan 5 2016, 9:19 PM · Diffusion
epriestley updated subscribers of T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.
Jan 5 2016, 9:17 PM · Diffusion
epriestley merged task T5744: Create obvious way to create an audit from Diffusion into T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.
Jan 5 2016, 9:17 PM · Audit, Diffusion
epriestley added a comment to T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".

T5046 has a specific case of this causing particularly questionable behavior when doing HTTP clones -- since the object is totally hidden, you don't get prompted for credentials.

Jan 5 2016, 9:14 PM · Policy, Spaces
epriestley updated the task description for T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:13 PM · Policy, Spaces
epriestley updated subscribers of T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:12 PM · Policy, Spaces
epriestley merged task T5046: Repositories requiring authentication does not prompt for auth details over http if "policy.allow-public" is true into T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:12 PM · Diffusion
epriestley added a comment to T5046: Repositories requiring authentication does not prompt for auth details over http if "policy.allow-public" is true.

This is expected with Spaces, which completely hide objects (primarily as a performance consideration). I'm going to merge this into T9771 which discusses this issue more broadly.

Jan 5 2016, 9:12 PM · Diffusion
epriestley added a comment to T6655: Offer to generate a new SSH key in /diffusion/import credentials step.

T8296 is a similar case for "Add Mirror".

Jan 5 2016, 9:08 PM · Diffusion
epriestley merged task T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown into T6655: Offer to generate a new SSH key in /diffusion/import credentials step.
Jan 5 2016, 9:08 PM · Passphrase, Diffusion
epriestley updated subscribers of T6655: Offer to generate a new SSH key in /diffusion/import credentials step.
Jan 5 2016, 9:08 PM · Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 9:04 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 8:29 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
foven added a comment to T9926: SVN Commit fails, hard to debug.

I am still trying to find a solution to this, but until I do I am considering hosting the SVN repository outside of Phabricator.

Jan 5 2016, 7:19 PM · Bug Report (Needs Information), Subversion, Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 7:02 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to Q262: How does unsubscribing from a Project work?.

This behavior is not expected. Please file a bug report with reproduction instructions.

Jan 5 2016, 6:08 PM · Projects
michaeljs1990 updated Q262: How does unsubscribing from a Project work? from to How does unsubscribing from a Project work?.
Jan 5 2016, 5:49 PM · Projects
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 5:22 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 4:41 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
chad added a comment to T9987: Diffs in a task should be sorted by the dependency tree.

We don't make or support git-phab. If the only reason for needing a new feature is because you're using a new, unsupported 3rd party application, it's not something the upstream will have any ability to prioritize. We prioritize tasks by likely impact and adoption across all our installs.

Jan 5 2016, 3:10 PM · Maniphest, Feature Request
Luke081515.2 awarded T10084: Flag notes should be visible in object properties a Like token.
Jan 5 2016, 2:35 PM · Flags, Feature Request
DheerendraRathor awarded T10084: Flag notes should be visible in object properties a Like token.
Jan 5 2016, 2:28 PM · Flags, Feature Request
epriestley moved T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException") from Backlog to vNext on the Diffusion board.
Jan 5 2016, 2:14 PM · Diffusion
epriestley added a revision to T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException"): Unknown Object (Differential Revision).
Jan 5 2016, 2:03 PM · Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 1:43 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a subtask for T4245: Make repository URIs slightly prettier: T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories.
Jan 5 2016, 1:25 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a parent task for T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories: T4245: Make repository URIs slightly prettier.
Jan 5 2016, 1:25 PM · Restricted Project, Diffusion
altendky added a comment to T9441: Cygwin PHP segfaults with arcanist.

Back at work... I have the same php, php-curl, and php-json versions in Cygwin and I am still core dumping (with my questionable-or-worse distribution system I'm not sure what arcanist and libphutil versions). I then updated to arcanist b3e68c9 and libphutil adb8a9c and arc doesn't seg-fault anymore. So, it seems to me that the initial trigger has likely been removed from arcanist but the issue that made it a seg-fault instead of a nice stack trace I suppose is still there in the PHP packages.

Jan 5 2016, 1:18 PM · Windows, Arcanist
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 1:12 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 12:51 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley closed T10087: fix the bug, a subtask of T10086: new test BUG , as Spite.
Jan 5 2016, 12:05 PM
epriestley closed T10087: fix the bug as Spite.
Jan 5 2016, 12:05 PM
epriestley closed T10086: new test BUG as Spite.
Jan 5 2016, 12:05 PM