Page MenuHomePhabricator

Create obvious way to create an audit from Diffusion
Closed, DuplicatePublic


I think it would be helpful to have an obvious way to create an audit when browsing the source of a project from Diffusion.

Currently, in every other context in which I am viewing source, and I click on a line number, I am allowed to create a comment at that line - in Diffusion, this merely highlights the line. This is a rather confusing difference in behavior - I was confused for several minutes at first, and I know that I'm not the only one at my organization.

Ultimately, this would be helpful when reviewing a file as a whole, instead of a particular commit. For example, I just identified a problem in a particular pattern we were using in our unit tests when applied in a certain way. I'd like to be able to browse the source of my repository, and highlight places where this pattern has unfortunate side effects, and then assign the responsibility for fixing the tests amongst my engineers.

Event Timeline

wotte raised the priority of this task from to Needs Triage.
wotte updated the task description. (Show Details)
wotte added projects: Diffusion, Audit.
wotte added a subscriber: wotte.
chad triaged this task as Wishlist priority.Jul 30 2014, 3:32 PM

Some related discussion in T491, T363, T1112 and maybe T4348.

The biggest issue here is that I think the UI is hard to get working intuitively, particularly given that commit-based audit already exists and will look very similar to new users.