Page MenuHomePhabricator
Create Task
Maniphest T7852

A repository grep search with no results returns an Unhandled Exception ("ConduitException")
Closed, ResolvedPublic
Actions

Description

https://secure.phabricator.com/diffusion/P/browse/master/?grep=asdfasdfasdf

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

chrisbolt created this task.Apr 18 2015, 12:03 AM
chrisbolt raised the priority of this task from to Needs Triage.
chrisbolt updated the task description. (Show Details)
chrisbolt added a project: Diffusion.
chrisbolt added a subscriber: chrisbolt.
joshuaspence added a subscriber: joshuaspence.Apr 18 2015, 11:24 AM
btrahan triaged this task as Low priority.Apr 23 2015, 8:08 PM
btrahan added a subscriber: btrahan.

This was intentionally "kicked down the road" as an example of unhandled exceptions generally not being handled so well. See https://secure.phabricator.com/D11789#114084

A spot fix would need to catch two types of exceptions - ConduitClientException and ConduitException - which have different data.

A general fix would probably need to have this sort of awareness too, and / or we'd need some more general Exception infrastructure so specific exceptions wouldn't need to be surfaced all the way down the stack.

epriestley merged a task: T8933: Grep with no results ends with Unhandled Exception.Jul 23 2015, 2:03 AM
epriestley added subscribers: hach-que, vrana.
clloos added a subscriber: clloos.Oct 5 2015, 1:35 PM
Herald added a subscriber: cspeckmim. · View Herald TranscriptOct 5 2015, 1:35 PM
cspeckmim removed a subscriber: cspeckmim.Oct 7 2015, 2:47 AM
epriestley added a revision: Restricted Differential Revision.Jan 5 2016, 2:03 PM
epriestley moved this task from Backlog to vNext on the Diffusion board.Jan 5 2016, 2:14 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 5 2016, 9:59 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility