Page MenuHomePhabricator

Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted"
Open, WishlistPublic

Description

(Yes I know that Drydock is a prototype application, but thought that you might not be aware of this)

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Drydock.
joshuaspence added a subscriber: joshuaspence.
epriestley renamed this task from "Unknown Object (Passphrase Credential)" in Drydock to Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".Nov 16 2015, 6:27 PM
epriestley triaged this task as Wishlist priority.
epriestley edited projects, added Spaces, Policy; removed Drydock.

We apply a Space constraint when executing this query and the object never makes it as far as the application. This is broadly by design, as it hugely improves the scalability of Spaces.

In the specific case of HandleQuery -- or perhaps any query with a PHID component? -- we could disable the Spaces constraint, let the object make it to standard policy filtering, and then drop it in the application so we render "Restricted" (or something more tailored, like "In Forbidden Space") instead of "Unknown".

epriestley updated the task description. (Show Details)

T5046 has a specific case of this causing particularly questionable behavior when doing HTTP clones -- since the object is totally hidden, you don't get prompted for credentials.

I'm leaning toward making any query with a set of unique identifiers (ids, callsigns, phids, etc) drop the Spaces clause in the query, but this is slightly tricky to do in a general way.