- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 23 2022
May 23 2022
epriestley committed rP631c36aee326: Don't consider file references inside quoted text blocks to grant "attachment… (authored by epriestley).
Don't consider file references inside quoted text blocks to grant "attachment…
epriestley committed rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit… (authored by epriestley).
Only attach files that are both referenced in Remarkup and attached by explicit…
- Further improve unit test coverage and test "reference doesn't grant view permission".
- Also fix indirect reference attachment/scrambling test.
- Fix unit test.
epriestley committed rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley).
Provide missing default attachment list for Files transactions
epriestley requested review of D21834: Provide missing default attachment list for Files transactions.
May 20 2022
May 20 2022
epriestley committed rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley).
Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
epriestley requested review of D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
May 19 2022
May 19 2022
epriestley committed rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on… (authored by epriestley).
Generate file attachment transactions for explicit Remarkup attachments on…
epriestley committed rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley).
Remove file attachment edge types, including API access
epriestley committed rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley).
Remove all "FileHasObject" edge reads and writes
epriestley committed rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes (authored by epriestley).
Remove all "ObjectHasFile" edge reads and writes
epriestley committed rP0329df0fa8d4: Copy file attachment edges to new storage (authored by epriestley).
Copy file attachment edges to new storage
epriestley committed rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction (authored by epriestley).
Adjust paste content transaction to support earlier file PHID extraction
epriestley committed rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage (authored by epriestley).
Double-write file attachment to old "edge" storage and new "attachment" storage
epriestley committed rP7fcc0f9ebd91: Remove "PhabricatorFile->detachFromObject()" (authored by epriestley).
Remove "PhabricatorFile->detachFromObject()"
epriestley committed rPcfa42c5e655c: Add database storage for a dedicated file attachment table (authored by epriestley).
Add database storage for a dedicated file attachment table
epriestley committed rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley).
Do not extract file PHIDs from remarkup blocks for attachment
epriestley triaged T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default" as Normal priority.
epriestley abandoned D21829: Generate attachment edges from drag-and-dropped files in stacked comments.
This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).
- Perform this migration entirely in SQL instead.
epriestley committed rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley).
Fix some test suite stragglers with PHP 8.1 compatibility
epriestley committed rP7693a711a725: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads (authored by epriestley).
Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads
epriestley committed rP33a0731619e8: Give "RemarkupControl" support for tracking metadata (authored by epriestley).
Give "RemarkupControl" support for tracking metadata
- Slightly smaller API, because versioned drafts are not coupled to form inputs.
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception, a subtask of T13588: PHP 8 Compatibility, as Resolved.
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception as Resolved.
Resolved by D21824.
May 17 2022
May 17 2022
epriestley committed rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads (authored by epriestley).
Fix an exception in cursor pagination of Conpherence threads
Remove "feed.publish" API
- Include library map update.
Thank you!
epriestley triaged T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Normal priority.
epriestley committed rARC85c953ebe4a6: Fix a PHP 8.1 repository marker issue in Mercurial (authored by epriestley).
Fix a PHP 8.1 repository marker issue in Mercurial
In T13588#256950, @cspeckmim wrote:A user just ran into this exception with Arcanist...
epriestley added a revision to T13588: PHP 8 Compatibility: D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
epriestley committed rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1 (authored by epriestley).
Straggling fixes for PhutilURI under PHP 8.1
epriestley requested review of D21824: Fix an exception in cursor pagination of Conpherence threads.
A user just ran into this exception with Arcanist (current master changeset) while running arc diff (using Mercurial) with PHP 8.1. I haven't looked too in depth but it seems similar to other PHP 8.1 issues.
[2022-05-17 20:49:47] EXCEPTION: (RuntimeException) substr(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=3cc486d5c156) #0 PhutilErrorHandler::handleError(integer, string, string, integer) #1 substr(NULL, integer, integer) called at [<arcanist>/src/repository/api/ArcanistRepositoryAPI.php:807] #2 ArcanistRepositoryAPI::getDisplayHash(NULL) called at [<arcanist>/src/repository/marker/ArcanistRepositoryMarkerQuery.php:67] #3 ArcanistRepositoryMarkerQuery::execute() called at [<arcanist>/src/repository/query/ArcanistRepositoryQuery.php:20] #4 ArcanistRepositoryQuery::executeOne() called at [<arcanist>/src/repository/api/ArcanistMercurialAPI.php:988] #5 ArcanistMercurialAPI::getActiveBookmark() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:2253] #6 ArcanistDiffWorkflow::buildDiffSpecification() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:380] #7 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427] <<< [1] (+8,567) <exec> 8,567,426 us
May 16 2022
May 16 2022
May 12 2022
May 12 2022
epriestley added a revision to T13588: PHP 8 Compatibility: D21822: Straggling fixes for PhutilURI under PHP 8.1.
epriestley committed rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items (authored by epriestley).
Add "pht_list()", a translation wrapper for lists of items
May 10 2022
May 10 2022
epriestley requested review of D21812: Do not extract file PHIDs from remarkup blocks for attachment.
I am pretty sure that this error message does not exist prior to PHP 8.1, and PHP 7.4 can not possibly emit it. See here for some evidence that this is true -- note that the error message is not present in the script output until PHP 8.1: