Page MenuHomePhabricator
Differential D21821

Fix some test suite stragglers with PHP 8.1 compatibility
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:37 PM.
Tags
None
Referenced Files
F19036463: D21821.id.diff
Tue, Nov 25, 8:13 PM
F19013779: D21821.diff
Sat, Nov 22, 4:53 PM
F18999609: D21821.id52017.diff
Nov 20 2025, 9:40 PM
F18877064: D21821.diff
Nov 6 2025, 5:42 AM
F18832051: D21821.id.diff
Oct 25 2025, 7:05 PM
F18787827: D21821.id52017.diff
Oct 15 2025, 1:42 AM
F18741563: D21821.diff
Oct 2 2025, 2:37 PM
F18736145: D21821.id52001.diff
Oct 1 2025, 4:59 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility
Summary

Ref T13588. This allows "arc unit --everything" to more or less run cleanly on PHP 8.1.

Test Plan

Ran "arc unit --everything".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 12 2022, 10:37 PM
epriestley created this revision.
Harbormaster completed remote builds in B25720: Diff 52001.May 12 2022, 10:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 7:04 PM
Closed by commit rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
parser/
ics/
4 lines
files/
format/
__tests__/
4 lines
nuance/
github/
2 lines
infrastructure/
markup/
blockrule/
2 lines
markuprule/
4 lines

Diff 52017

View Options

src/applications/calendar/parser/ics/PhutilICSWriter.php

Loading...
View Options

src/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php

Loading...
View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
Phabricator · Built by Phacility