Page MenuHomePhabricator

Remove all "ObjectHasFile" edge reads and writes
ClosedPublic

Authored by epriestley on May 12 2022, 10:15 PM.
Tags
None
Referenced Files
F11783314: D21819.id52027.diff
Sun, May 28, 10:51 PM
F11783313: D21819.id51999.diff
Sun, May 28, 10:51 PM
F11783312: D21819.id.diff
Sun, May 28, 10:51 PM
Unknown Object (File)
Thu, May 25, 11:28 PM
Unknown Object (File)
Wed, May 24, 5:12 PM
Unknown Object (File)
Tue, May 23, 9:04 AM
Unknown Object (File)
Sat, May 20, 10:41 PM
Unknown Object (File)
Sun, May 14, 7:52 PM
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes
Summary

Ref T13603. Migrate all code which interacts with the "ObjectHasFile" edge to use the "Attachments" table instead.

Test Plan
  • Edited a paste's view policy, confirmed associated file secret was scrambled.
  • Verified I could still view paste content as a user who could not naturally view the underlying file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 12 2022, 10:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.