Page MenuHomePhabricator
Differential D21819

Remove all "ObjectHasFile" edge reads and writes
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:15 PM.
Tags
None
Referenced Files
F17657501: D21819.diff
Sat, Jul 12, 12:19 PM
Unknown Object (File)
Mon, Jun 30, 9:26 PM
Unknown Object (File)
Tue, Jun 17, 5:10 AM
Unknown Object (File)
Jun 7 2025, 7:35 AM
Unknown Object (File)
Jun 7 2025, 2:23 AM
Unknown Object (File)
Jun 6 2025, 3:05 PM
Unknown Object (File)
Jun 4 2025, 7:10 PM
Unknown Object (File)
May 30 2025, 10:56 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes
Summary

Ref T13603. Migrate all code which interacts with the "ObjectHasFile" edge to use the "Attachments" table instead.

Test Plan
  • Edited a paste's view policy, confirmed associated file secret was scrambled.
  • Verified I could still view paste content as a user who could not naturally view the underlying file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 12 2022, 10:15 PM
Owners added a subscriber: Restricted Owners Package.May 12 2022, 10:15 PM
epriestley requested review of this revision.May 12 2022, 10:15 PM
Harbormaster completed remote builds in B25718: Diff 51999.May 12 2022, 10:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
Closed by commit rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
files/
query/
24 lines
storage/
6 lines
transactions/
editor/
52 lines

Diff 52027

View Options

resources/sql/autopatches/20140904.macroattach.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility