Page MenuHomePhabricator

Remove all "ObjectHasFile" edge reads and writes
ClosedPublic

Authored by epriestley on May 12 2022, 10:15 PM.
Tags
None
Referenced Files
F13258194: D21819.id.diff
Sun, May 26, 7:20 AM
F13244983: D21819.id.diff
Thu, May 23, 5:30 AM
F13244742: D21819.diff
Thu, May 23, 5:17 AM
F13235303: D21819.id.diff
Tue, May 21, 4:38 AM
F13207278: D21819.id52027.diff
Wed, May 15, 10:08 PM
F13198300: D21819.diff
Mon, May 13, 5:40 AM
F13183191: D21819.diff
Fri, May 10, 7:26 AM
F13178792: D21819.diff
Wed, May 8, 8:41 PM
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes
Summary

Ref T13603. Migrate all code which interacts with the "ObjectHasFile" edge to use the "Attachments" table instead.

Test Plan
  • Edited a paste's view policy, confirmed associated file secret was scrambled.
  • Verified I could still view paste content as a user who could not naturally view the underlying file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 12 2022, 10:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.