Page MenuHomePhabricator

Double-write file attachment to old "edge" storage and new "attachment" storage
Needs ReviewPublic

Authored by epriestley on Thu, May 12, 9:34 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Summary

Ref T13603. This adds a second write to new "attachment" storage to all writers except one in Paste, which creates the file inline.

Test Plan
  • Updated a macro image, confirmed a write to "attachment" storage (transaction pathway).
  • Updated a blog profile image, confirmed a write to "attachment" storage (legacy pathway).

Diff Detail

Repository
rP Phabricator
Branch
file4
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25714
Build 35542: arc lint + arc unit

Unit TestsFailed

TimeTest
44 msPhabricatorFileTestCase::testFileIndirectScramble
Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
221 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
9 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
96 msPhabricatorFileTestCase::testFileDirectScramble
2 assertions passed.
6 msPhabricatorFileTestCase::testFileStorageDelete
1 assertion passed.
View Full Test Results (1 Failed · 16 Passed)

Event Timeline

epriestley created this revision.