Page MenuHomePhabricator
Feed All Stories

Aug 8 2022

epriestley added a comment to T13652: Notes on Ardunio CNC drivers.
FeatureDimension
Barrel6.8mm
Divot Size2.5mm H x 1.15mm W x 1.6mm D
Divot Distance7mm
Shaft~3mm
Aug 8 2022, 5:17 PM

Aug 1 2022

garoevans updated garoevans.
Aug 1 2022, 12:44 PM

Jul 29 2022

epriestley triaged T13686: Disable Ubuntu unattended upgrades as Normal priority.
Jul 29 2022, 12:16 PM · Phacility

Jul 8 2022

epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).

Jul 8 2022, 3:57 AM · EditEngine, Files
Krinkle added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

I believe we may be hitting either the problem one of the above commit fixes, or suffering from a similar caused as side-effect from it.

Jul 8 2022, 3:35 AM · EditEngine, Files

Jun 14 2022

epriestley committed rPf2a7db1b1a1c: (stable) Flatten "RemarkupValue" objects when setting field defaults for custom… (authored by epriestley).
(stable) Flatten "RemarkupValue" objects when setting field defaults for custom…
Jun 14 2022, 5:12 PM
epriestley closed D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:37 PM
epriestley committed rP9426765a2c6a: Flatten "RemarkupValue" objects when setting field defaults for custom forms (authored by epriestley).
Flatten "RemarkupValue" objects when setting field defaults for custom forms
Jun 14 2022, 4:37 PM
epriestley requested review of D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:32 PM
epriestley added a revision to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization: D21854: Flatten "RemarkupValue" objects when setting field defaults for custom forms.
Jun 14 2022, 4:32 PM · EditEngine, Files
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

...ideally this sort of thing should fail loudly at serialization time...

Jun 14 2022, 4:29 PM · EditEngine, Files
epriestley triaged T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Normal priority.
Jun 14 2022, 1:09 PM · EditEngine, Files

Jun 13 2022

epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.
  • The drydock_resource table could use a (status, ...) key to satisfy common/default queries.
Jun 13 2022, 1:16 PM · Drydock

Jun 9 2022

bagashe updated bagashe.
Jun 9 2022, 11:29 PM

Jun 7 2022

vm abandoned D10443: Allow arc patch to keep empty commits.
Jun 7 2022, 9:42 PM
vm abandoned D15124: Add linter to support eslint.
Jun 7 2022, 9:42 PM
vm requested review of D21853: Fix more PHP 8.1 "strlen(null)" callsites.
Jun 7 2022, 7:48 PM
vm added a revision to T13588: PHP 8 Compatibility: D21853: Fix more PHP 8.1 "strlen(null)" callsites.
Jun 7 2022, 7:48 PM · Infrastructure
epriestley triaged T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable as Normal priority.
Jun 7 2022, 3:04 AM · Drydock

Jun 3 2022

epriestley committed rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented… (authored by epriestley).
(stable) Fix repository URI generation for SVN commit identifiers represented…
Jun 3 2022, 10:16 PM
epriestley closed D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:01 PM
epriestley committed rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with… (authored by epriestley).
Fix repository URI generation for SVN commit identifiers represented with…
Jun 3 2022, 10:01 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:00 PM · Infrastructure
epriestley requested review of D21852: Fix repository URI generation for SVN commit identifiers represented with integer types.
Jun 3 2022, 10:00 PM

May 31 2022

epriestley closed D21851: Fix a policy issue where permissions were not properly checked when disabling global builtin queries.
May 31 2022, 6:00 PM
epriestley committed rP944b257d5df3: Fix a policy issue where permissions were not properly checked when disabling… (authored by epriestley).
Fix a policy issue where permissions were not properly checked when disabling…
May 31 2022, 6:00 PM
epriestley requested review of D21851: Fix a policy issue where permissions were not properly checked when disabling global builtin queries.
May 31 2022, 5:59 PM
epriestley closed D21850: Remove obsolete, policy-violating "owners.query" API method.
May 31 2022, 5:44 PM
epriestley committed rP3052ed14849c: Remove obsolete, policy-violating "owners.query" API method (authored by epriestley).
Remove obsolete, policy-violating "owners.query" API method
May 31 2022, 5:44 PM
epriestley requested review of D21850: Remove obsolete, policy-violating "owners.query" API method.
May 31 2022, 5:43 PM

May 28 2022

epriestley committed rP95481b5e3c49: (stable) Improve remarkup metadata robustness against debris in the database (authored by epriestley).
(stable) Improve remarkup metadata robustness against debris in the database
May 28 2022, 1:30 PM
epriestley closed D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM
epriestley committed rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database (authored by epriestley).
Improve remarkup metadata robustness against debris in the database
May 28 2022, 1:29 PM
epriestley requested review of D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM · Remarkup

May 27 2022

epriestley edited the content of Changelog.
May 27 2022, 6:33 PM
epriestley created an object: 2022 Week 21 (Late May).
May 27 2022, 6:14 PM
epriestley triaged T13683: Security Guidance: References to Files in Remarkup as Normal priority.
May 27 2022, 6:13 PM · Guides, Files, Security
epriestley committed rPd075f3e93c02: (stable) Promote 2022 Week 21 (authored by epriestley).
(stable) Promote 2022 Week 21
May 27 2022, 6:13 PM
epriestley committed rARCb6babd9a07f4: (stable) Promote 2022 Week 21 (authored by epriestley).
(stable) Promote 2022 Week 21
May 27 2022, 6:13 PM
epriestley closed D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:15 PM
epriestley committed rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley).
Update Slowvote poll status to use sensible string constants
May 27 2022, 5:15 PM
epriestley committed rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley).
Separate Slowvote poll status onto a dedicated object
May 27 2022, 5:15 PM
epriestley closed D21847: Separate Slowvote poll status onto a dedicated object.
May 27 2022, 5:15 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:14 PM · Remarkup
epriestley requested review of D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:14 PM

May 26 2022

epriestley requested review of D21847: Separate Slowvote poll status onto a dedicated object.
May 26 2022, 5:46 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21847: Separate Slowvote poll status onto a dedicated object.
May 26 2022, 5:46 PM · Remarkup
epriestley closed D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:27 PM
epriestley committed rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants (authored by epriestley).
Update Slowvote voting methods to use sensible string constants
May 26 2022, 5:27 PM
epriestley requested review of D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:24 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:24 PM · Remarkup
epriestley closed D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:17 PM
epriestley committed rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley).
Move Slowvote vote types to a separate object
May 26 2022, 5:17 PM
epriestley updated the diff for D21845: Move Slowvote vote types to a separate object.
  • Update some file/class names.
May 26 2022, 5:09 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:09 PM · Remarkup
epriestley requested review of D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:09 PM
epriestley committed rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley).
Update Slowvote to use sensible string constants for response visibility
May 26 2022, 4:59 PM
epriestley closed D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM
epriestley closed D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:58 PM
epriestley committed rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley).
Move Slowvote response visibility to a separate object
May 26 2022, 4:58 PM
epriestley requested review of D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:40 PM · Remarkup
epriestley requested review of D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:40 PM
epriestley committed rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley).
Migrate "SlowvotePoll" to modern mailkey storage
May 26 2022, 4:29 PM
epriestley closed D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 4:29 PM
epriestley closed D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 4:29 PM
epriestley committed rPd91727e66ceb: Update nonstandard PHID key on "SlowvotePoll" (authored by epriestley).
Update nonstandard PHID key on "SlowvotePoll"
May 26 2022, 4:29 PM
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.

May 26 2022, 12:13 AM · Mail
epriestley requested review of D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM · Remarkup
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM · Mail
epriestley requested review of D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 12:00 AM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 12:00 AM · Remarkup

May 25 2022

epriestley closed D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:56 PM
epriestley committed rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley).
Update "Files" attachment table to show more attachment details and support…
May 25 2022, 7:56 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:53 PM · Remarkup
epriestley requested review of D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:53 PM
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...

May 25 2022, 5:33 PM · Remarkup
epriestley closed D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:25 PM
epriestley committed rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley).
Pass "object" to modular transaction methods explicitly
May 25 2022, 5:25 PM
epriestley requested review of D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:18 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:18 PM · Remarkup
Undedist updated Undedist.
May 25 2022, 8:08 AM

May 24 2022

epriestley closed D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:19 PM
epriestley committed rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley).
Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
May 24 2022, 5:19 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:08 PM · Remarkup
epriestley requested review of D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:08 PM
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
May 24 2022, 4:56 PM · Remarkup
epriestley closed D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
May 24 2022, 4:50 PM
epriestley committed rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not… (authored by epriestley).
Provide a simple "Attach File" explicit workflow for files referenced but not…
May 24 2022, 4:50 PM
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
  • Rebuild Celerity map.
May 24 2022, 1:13 AM
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
  • Correct some translation strings.
May 24 2022, 1:13 AM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
May 24 2022, 1:12 AM · Remarkup
epriestley requested review of D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
May 24 2022, 1:12 AM

May 23 2022

epriestley closed D21836: Provide a rudimentary "Attached Files" curtain UI panel.
May 23 2022, 9:08 PM
epriestley closed D21835: Give "FileAttachment" policy support and a query object.
May 23 2022, 9:08 PM
epriestley committed rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel (authored by epriestley).
Provide a rudimentary "Attached Files" curtain UI panel
May 23 2022, 9:08 PM
epriestley committed rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley).
Give "FileAttachment" policy support and a query object
May 23 2022, 9:08 PM