Page MenuHomePhabricator
Differential D21812

Do not extract file PHIDs from remarkup blocks for attachment
ClosedPublic
Actions

Authored by epriestley on May 10 2022, 6:54 PM.
Tags
None
Referenced Files
F18081642: D21812.diff
Tue, Aug 5, 1:23 AM
F17950583: D21812.id52021.diff
Fri, Aug 1, 12:32 AM
F17948289: D21812.id.diff
Thu, Jul 31, 8:43 PM
F17935612: D21812.diff
Wed, Jul 30, 11:27 PM
F17924223: D21812.diff
Wed, Jul 30, 9:27 AM
F17674591: D21812.diff
Sun, Jul 13, 7:25 AM
F17657493: D21812.diff
Sat, Jul 12, 12:18 PM
Unknown Object (File)
Jul 3 2025, 6:35 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment
Summary

Ref T13603. When processing transactions that include remarkup blocks, stop extracting file references from them for attachment.

Test Plan

Submitted a remarkup block with a file reference, no longer saw automatic file attachment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 10 2022, 6:54 PM
epriestley created this revision.
Harbormaster completed remote builds in B25709: Diff 51989.May 10 2022, 6:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
Closed by commit rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment.

Revision Contents
Changeset List

Diff 52021

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility