Do not extract file PHIDs from remarkup blocks for attachment
ClosedPublic
Actions

Authored by epriestley on May 10 2022, 6:54 PM.

Tags

None

Referenced Files

	F19095328: D21812.id.diff
	Thu, Dec 4, 4:51 AM

	F19089767: D21812.diff
	Wed, Dec 3, 8:57 AM

	F18962353: D21812.diff
	Nov 13 2025, 4:59 PM

	F18846774: D21812.id51989.diff
	Oct 29 2025, 9:04 PM

	F18780433: D21812.diff
	Oct 12 2025, 2:00 PM

	F18751619: D21812.id52021.diff
	Oct 4 2025, 11:56 AM

	F18741125: D21812.id52021.diff
	Oct 2 2025, 8:42 AM

	F18737060: D21812.diff
	Oct 1 2025, 8:48 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment

Summary

Ref T13603. When processing transactions that include remarkup blocks, stop extracting file references from them for attachment.

Test Plan

Submitted a remarkup block with a file reference, no longer saw automatic file attachment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 10 2022, 6:54 PM

epriestley created this revision.

Harbormaster completed remote builds in B25709: Diff 51989.May 10 2022, 6:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM

Closed by commit rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

18 lines

PhabricatorApplicationTransactionEditor.php

8 lines

Diff 52021

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php