Page MenuHomePhabricator

Straggling fixes for PhutilURI under PHP 8.1
Needs ReviewPublic

Authored by epriestley on Thu, May 12, 10:38 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Summary

Ref T13588. Additional PhutilURI fixes for PHP 8.1.

Test Plan

Ran "arc unit --everything" in Phabricator.

Diff Detail

Repository
rARC Arcanist
Branch
unit2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25721
Build 35549: arc lint + arc unit

Unit TestsFailed

TimeTest
1,019 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
0 msArcanistBaseCommitParserTestCase::testBasics
2 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testHalt
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJump
1 assertion(s) passed.
0 msArcanistBaseCommitParserTestCase::testJumpReturn
1 assertion(s) passed.
View Full Test Results (1 Failed · 74 Passed)

Event Timeline

epriestley created this revision.