Fix an exception in cursor pagination of Conpherence threads
147b48b934b3
Actions

Description

Fix an exception in cursor pagination of Conpherence threads

Summary: Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan:

Wrote 100+ messages to a Conpherence room.
Clicked "Show Older Messages".
Before: exception, int passed to "phutil_nonempty_string()".
After: older messages loaded.

Maniphest Tasks: T13680

Differential Revision: https://secure.phabricator.com/D21824

Details

Provenance

epriestley	Authored on May 17 2022, 11:07 PM
epriestley	Pushed on May 17 2022, 11:31 PM

Differential Revision

D21824: Fix an exception in cursor pagination of Conpherence threads

Parents

rP431612023dae: Remove "feed.publish" API

Branches

Unknown

Tags

Unknown

Tasks

T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception

Event Timeline

epriestley committed rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads (authored by epriestley).May 17 2022, 11:31 PM

epriestley added a task: T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception.

epriestley added an edge: D21824: Fix an exception in cursor pagination of Conpherence threads.

Changes (1)

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

rP147b48b934b3

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php