Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 8:54 AM
Unknown Object (File)
Fri, Jul 1, 8:54 AM
Unknown Object (File)
Fri, Jul 1, 8:54 AM
Unknown Object (File)
Wed, Jun 29, 9:57 AM
Unknown Object (File)
Fri, Jun 24, 12:02 AM
Unknown Object (File)
Tue, Jun 21, 7:23 PM
Unknown Object (File)
Thu, Jun 16, 10:24 AM
Unknown Object (File)
Thu, Jun 16, 10:24 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.