Page MenuHomePhabricator

Fix an exception in cursor pagination of Conpherence threads
ClosedPublic

Authored by epriestley on May 17 2022, 11:08 PM.
Tags
None
Referenced Files
F13232909: D21824.diff
Tue, May 21, 1:33 AM
F13211438: D21824.diff
Fri, May 17, 5:45 AM
F13198307: D21824.diff
Mon, May 13, 5:41 AM
F13196689: D21824.diff
Sun, May 12, 11:28 PM
F13183097: D21824.diff
Fri, May 10, 6:57 AM
Unknown Object (File)
Sat, May 4, 10:50 PM
Unknown Object (File)
Sat, May 4, 10:44 AM
Unknown Object (File)
Fri, May 3, 6:12 AM
Subscribers
None

Details

Summary

Ref T13680. Conpherence may pass values with an integer type to this layer of the stack. These are "supposed" to be strings, but just be accepting.

Test Plan
  • Wrote 100+ messages to a Conpherence room.
  • Clicked "Show Older Messages".
  • Before: exception, int passed to "phutil_nonempty_string()".
  • After: older messages loaded.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable