Page MenuHomePhabricator

Fix a PHP 8.1 repository marker issue in Mercurial
ClosedPublic

Authored by epriestley on May 17 2022, 11:18 PM.
Tags
None
Referenced Files
F15391648: D21825.id52007.diff
Sat, Mar 15, 10:50 AM
F15391644: D21825.id52006.diff
Sat, Mar 15, 10:49 AM
F15391643: D21825.id.diff
Sat, Mar 15, 10:49 AM
F15387854: D21825.diff
Sat, Mar 15, 3:01 AM
F15377480: D21825.diff
Thu, Mar 13, 9:07 AM
F15340622: D21825.id52006.diff
Sun, Mar 9, 3:55 PM
Unknown Object (File)
Thu, Feb 27, 4:09 PM
Unknown Object (File)
Thu, Feb 27, 4:09 PM
Subscribers
None

Details

Summary

Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to substr(null, ...).

Don't attempt to generate a display name for markers with no commit hash.

Test Plan
  • Ran arc branches under PHP 8.1 in a Mercurial repository.
  • Before: fatal.
  • After: sensible output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable