Page MenuHomePhabricator

Fix a PHP 8.1 repository marker issue in Mercurial
ClosedPublic

Authored by epriestley on May 17 2022, 11:18 PM.
Tags
None
Referenced Files
F10890673: D21825.diff
Sun, Jul 3, 7:23 AM
Unknown Object (File)
Fri, Jul 1, 8:49 AM
Unknown Object (File)
Fri, Jul 1, 8:49 AM
Unknown Object (File)
Fri, Jul 1, 8:48 AM
Unknown Object (File)
Wed, Jun 29, 9:54 AM
Unknown Object (File)
Thu, Jun 16, 10:23 AM
Unknown Object (File)
Thu, Jun 16, 10:23 AM
Unknown Object (File)
Thu, Jun 16, 10:23 AM
Subscribers
None

Details

Summary

Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to substr(null, ...).

Don't attempt to generate a display name for markers with no commit hash.

Test Plan
  • Ran arc branches under PHP 8.1 in a Mercurial repository.
  • Before: fatal.
  • After: sensible output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable