Page MenuHomePhabricator

Fix a PHP 8.1 repository marker issue in Mercurial
ClosedPublic

Authored by epriestley on May 17 2022, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 20 2026, 10:12 PM
Unknown Object (File)
Mar 18 2026, 12:17 AM
Unknown Object (File)
Mar 15 2026, 3:11 AM
Unknown Object (File)
Mar 6 2026, 5:13 PM
Unknown Object (File)
Mar 5 2026, 3:17 PM
Unknown Object (File)
Mar 4 2026, 2:40 AM
Unknown Object (File)
Mar 2 2026, 4:00 PM
Unknown Object (File)
Jan 29 2026, 5:44 PM
Subscribers
None

Details

Summary

Ref T13588. "arc-ls-markers" emits a "branch-state" marker so callers can identify which branch is active in the working copy.

This marker doesn't have an associated commit, so trying to generate a display name fails under stricter PHP 8.1 rules when we try to substr(null, ...).

Don't attempt to generate a display name for markers with no commit hash.

Test Plan
  • Ran arc branches under PHP 8.1 in a Mercurial repository.
  • Before: fatal.
  • After: sensible output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable