Page MenuHomePhabricator

Generate attachment edges from drag-and-dropped files in stacked comments
AbandonedPublic

Authored by epriestley on May 19 2022, 7:30 PM.
Tags
None
Referenced Files
F15549009: D21829.id.diff
Sun, Apr 27, 3:21 AM
F15549007: D21829.diff
Sun, Apr 27, 3:20 AM
F15542666: D21829.id52019.diff
Fri, Apr 25, 5:53 PM
F15529254: D21829.id52019.diff
Tue, Apr 22, 6:14 PM
F15524321: D21829.id.diff
Mon, Apr 21, 7:25 AM
F15513365: D21829.diff
Thu, Apr 17, 6:28 PM
F15507263: D21829.id.diff
Tue, Apr 15, 5:57 PM
F15503001: D21829.diff
Mon, Apr 14, 6:01 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Summary

Ref T13603. When users drag-and-drop files into stacked comment remarkup text areas, process the attachment metadata and attach the files.

Test Plan

Dragged-and-dropped files into a Maniphest comment, saw them attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25731
Build 35559: arc lint + arc unit

Event Timeline

epriestley created this revision.

This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).