Generate attachment edges from drag-and-dropped files in stacked comments
AbandonedPublic
Actions

Authored by epriestley on May 19 2022, 7:30 PM.

Tags

None

Referenced Files

	F14007755: D21829.diff
	Tue, Oct 29, 11:07 AM

	F13997734: D21829.id.diff
	Thu, Oct 24, 5:54 AM

	F13981155: D21829.id.diff
	Sat, Oct 19, 2:34 PM

	F13981154: D21829.id52019.diff
	Sat, Oct 19, 2:34 PM

	F13981106: D21829.diff
	Sat, Oct 19, 2:17 PM

	F13975342: D21829.id52019.diff
	Fri, Oct 18, 9:45 AM

	Unknown Object (File)
	Oct 1 2024, 10:22 AM

	Unknown Object (File)
	Sep 30 2024, 4:29 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task

Summary

Ref T13603. When users drag-and-drop files into stacked comment remarkup text areas, process the attachment metadata and attach the files.

Test Plan

Dragged-and-dropped files into a Maniphest comment, saw them attach properly.

Diff Detail

Repository

rP Phabricator

Branch

file10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25731
Build 35559: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 19 2022, 7:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25731: Diff 52019.May 19 2022, 7:30 PM

This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

31 lines

Diff 52019

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Generate attachment edges from drag-and-dropped files in stacked commentsAbandonedPublicActions