Generate attachment edges from drag-and-dropped files in stacked comments
AbandonedPublic
Actions

Authored by epriestley on May 19 2022, 7:30 PM.

Tags

None

Referenced Files

	F15452025: D21829.id52019.diff
	Sat, Mar 29, 1:16 AM

	F15452023: D21829.id.diff
	Sat, Mar 29, 1:14 AM

	F15450321: D21829.id.diff
	Fri, Mar 28, 3:01 PM

	F15439232: D21829.diff
	Wed, Mar 26, 6:26 AM

	F15424185: D21829.id52019.diff
	Sat, Mar 22, 8:44 PM

	F15423472: D21829.id.diff
	Sat, Mar 22, 3:36 PM

	F15420082: D21829.diff
	Fri, Mar 21, 11:11 AM

	F15419564: D21829.diff
	Fri, Mar 21, 7:03 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task

Summary

Ref T13603. When users drag-and-drop files into stacked comment remarkup text areas, process the attachment metadata and attach the files.

Test Plan

Dragged-and-dropped files into a Maniphest comment, saw them attach properly.

Diff Detail

Repository

rP Phabricator

Branch

file10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25731
Build 35559: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 19 2022, 7:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25731: Diff 52019.May 19 2022, 7:30 PM

This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

31 lines

Diff 52019

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Generate attachment edges from drag-and-dropped files in stacked commentsAbandonedPublicActions