Page MenuHomePhabricator

When predicting object policies for project milestones, adjust objects so they behave like milestones
ClosedPublic

Authored by epriestley on Nov 19 2019, 6:29 AM.
Tags
None
Referenced Files
F18739389: D20919.id.diff
Wed, Oct 1, 9:15 PM
F18728673: D20919.diff
Tue, Sep 30, 9:42 AM
F18567562: D20919.id.diff
Sep 9 2025, 3:55 PM
F18445890: D20919.id.diff
Aug 31 2025, 8:40 PM
F18415240: D20919.diff
Aug 30 2025, 9:29 AM
F18100809: D20919.id.diff
Aug 9 2025, 12:06 PM
F17864129: D20919.id.diff
Jul 28 2025, 1:48 AM
F17829614: D20919.diff
Jul 26 2025, 10:14 AM
Subscribers
None

Details

Summary

Ref T13462. Currently, when testing milestone edit policies during creation, the project object does not behave like a milestone:

  • it doesn't have a milestone number yet, so it doesn't try to access the parent project; and
  • the parent project isn't attached yet.

Instead: attach the parent project sooner (which "should" be harmless, although it's possible this has weird side effects); and give the adjusted policy object a dummy milestone number if it doesn't have one yet. This forces it to act like a milestone when emitting policies.

Test Plan
  • Set "Projects" application default edit policy to "No One".
  • Created a milestone I had permission to create.
    • Before: failed with a policy error, because the project behaved like a non-milestone and returned "No One" as the effective edit policy.
    • After: worked properly, correctly evaluting the parent project edit policy as the effective edit policy.
  • Tried to create a milestone I did not have permission to create (no edit permission on parent project).
    • Got an appropriate edit policy error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable