Page MenuHomePhabricator

Make repository identity email address association case-insensitive
ClosedPublic

Authored by epriestley on Thu, Nov 14, 3:15 AM.

Details

Summary

Ref T13444. Currently, identities for a particular email address are queried with "LIKE" against a binary column, which makes the query case-sensitive.

  • Extract the email address into a separate "sort255" column.
  • Add a key for it.
  • Make the query a standard "IN (%Ls)" query.
  • Deal with weird cases where an email address is 10000 bytes long or full of binary junk.
Test Plan
  • Ran migration, inspected database for general sanity.
  • Ran query script in T13444, saw it return the same hits for "git@" and "GIT@".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 14, 3:15 AM
Owners added a subscriber: Restricted Owners Package.Thu, Nov 14, 3:15 AM
epriestley requested review of this revision.Thu, Nov 14, 3:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Nov 19, 5:37 PM
This revision was automatically updated to reflect the committed changes.