Page MenuHomePhabricator

Make repository identity email address association case-insensitive
ClosedPublic

Authored by epriestley on Nov 14 2019, 3:15 AM.
Tags
None
Referenced Files
F15540471: D20907.id.diff
Fri, Apr 25, 7:45 AM
F15538898: D20907.diff
Thu, Apr 24, 10:18 PM
F15537733: D20907.id49829.diff
Thu, Apr 24, 3:27 PM
F15477675: D20907.id49829.diff
Mon, Apr 7, 5:17 PM
F15412453: D20907.diff
Mar 19 2025, 1:05 PM
F15407784: D20907.diff
Mar 18 2025, 7:35 PM
F15384686: D20907.diff
Mar 14 2025, 8:35 PM
Unknown Object (File)
Feb 21 2025, 9:50 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13444. Currently, identities for a particular email address are queried with "LIKE" against a binary column, which makes the query case-sensitive.

  • Extract the email address into a separate "sort255" column.
  • Add a key for it.
  • Make the query a standard "IN (%Ls)" query.
  • Deal with weird cases where an email address is 10000 bytes long or full of binary junk.
Test Plan
  • Ran migration, inspected database for general sanity.
  • Ran query script in T13444, saw it return the same hits for "git@" and "GIT@".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Nov 14 2019, 3:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.