Differential D20924

Remove "phlog()" of exeptions during Conduit calls
ClosedPublic
Actions

Authored by epriestley on Nov 22 2019, 7:54 PM.

Tags

None

Referenced Files

	F22674188: D20924.id.diff
	Thu, Oct 1, 8:42 PM

	F22587130: D20924.diff
	Mon, Sep 28, 2:06 AM

	Unknown Object (File)
	Sun, Sep 13, 4:06 PM

	Unknown Object (File)
	Sun, Sep 13, 12:49 PM

	Unknown Object (File)
	Sat, Sep 12, 11:21 PM

	Unknown Object (File)
	Aug 30 2026, 2:58 AM

	Unknown Object (File)
	Jun 23 2026, 9:45 AM

	Unknown Object (File)
	Apr 22 2026, 12:56 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13465: Stop sending Conduit exceptions to the error log
Commits: rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls

Summary

Fixes T13465. This "phlog()" made some degree of sense at one time, but is no longer useful or consistent. Get rid of it. See T13465 for discussion.

Test Plan

Made a conduit call that hit a policy error, no longer saw error in log.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 22 2019, 7:54 PM

Harbormaster completed remote builds in B23694: Diff 49865.Nov 22 2019, 7:56 PM

epriestley requested review of this revision.Nov 22 2019, 7:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2019, 8:03 PM

Closed by commit rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

3 lines

Diff 49866

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Remove "phlog()" of exeptions during Conduit callsClosedPublicActions