Page MenuHomePhabricator

Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently

Authored by epriestley on Nov 14 2019, 4:09 AM.



Ref T13444. You can currently explicitly unassign an identity (useful if the matching algorithm is misfiring). However, this populates the "currentEffectiveUserPHID" with the "unassigned()" token, which mostly makes things more difficult.

When an identity is explicitly unassigned, convert that into an explicit null in the effective user PHID.

Then, realign "assigned" / "effective" language a bit. Previously, withAssigneePHIDs(...) actualy queried effective users, which was misleading. Finally, bulk up the list view a little bit to make testing slightly easier.

Test Plan
  • Unassigned an identity, ran migration, saw currentEffectiveUserPHID become NULL for the identity.
  • Unassigned a fresh identity, saw NULL.
  • Queried for various identities under the modified constraints.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Nov 14 2019, 4:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.