Page MenuHomePhabricator

Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently
ClosedPublic

Authored by epriestley on Thu, Nov 14, 4:09 AM.

Details

Summary

Ref T13444. You can currently explicitly unassign an identity (useful if the matching algorithm is misfiring). However, this populates the "currentEffectiveUserPHID" with the "unassigned()" token, which mostly makes things more difficult.

When an identity is explicitly unassigned, convert that into an explicit null in the effective user PHID.

Then, realign "assigned" / "effective" language a bit. Previously, withAssigneePHIDs(...) actualy queried effective users, which was misleading. Finally, bulk up the list view a little bit to make testing slightly easier.

Test Plan
  • Unassigned an identity, ran migration, saw currentEffectiveUserPHID become NULL for the identity.
  • Unassigned a fresh identity, saw NULL.
  • Queried for various identities under the modified constraints.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 14, 4:09 AM
Owners added a subscriber: Restricted Owners Package.Thu, Nov 14, 4:09 AM
epriestley requested review of this revision.Thu, Nov 14, 4:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Nov 19, 5:37 PM
This revision was automatically updated to reflect the committed changes.