Page MenuHomePhabricator

When predicting project membership during edits, predict milestones will have parent membership
ClosedPublic

Authored by epriestley on Tue, Nov 19, 6:52 AM.

Details

Summary

Depends on D20919. Ref T13462. When editing milestones, we currently predict they will have no members for policy evaluation purposes. This isn't the right rule.

Instead, predict that their membership will be the same as the parent project's membership, and pass this hint to the policy layer.

See T13462 for additional context and discussion.

Test Plan
  • Set project A's edit policy to "Project Members".
  • Joined project A.
  • Tried to create a milestone of project A.
    • Before: policy exception that the edit policy excludes me.
    • After: clean milestone creation.
  • As a non-member, tried to create a milestone. Received appropriate policy error.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Nov 19, 6:52 AM
epriestley requested review of this revision.Tue, Nov 19, 6:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Nov 19, 7:07 AM
This revision was automatically updated to reflect the committed changes.