Page MenuHomePhabricator

When predicting project membership during edits, predict milestones will have parent membership
ClosedPublic

Authored by epriestley on Nov 19 2019, 6:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 4:13 AM
Unknown Object (File)
Feb 23 2024, 4:47 AM
Unknown Object (File)
Feb 8 2024, 2:17 AM
Unknown Object (File)
Jan 31 2024, 4:40 PM
Unknown Object (File)
Jan 17 2024, 6:05 AM
Unknown Object (File)
Dec 25 2023, 12:19 PM
Unknown Object (File)
Nov 30 2023, 4:00 AM
Unknown Object (File)
Nov 25 2023, 10:50 PM
Subscribers
None

Details

Summary

Depends on D20919. Ref T13462. When editing milestones, we currently predict they will have no members for policy evaluation purposes. This isn't the right rule.

Instead, predict that their membership will be the same as the parent project's membership, and pass this hint to the policy layer.

See T13462 for additional context and discussion.

Test Plan
  • Set project A's edit policy to "Project Members".
  • Joined project A.
  • Tried to create a milestone of project A.
    • Before: policy exception that the edit policy excludes me.
    • After: clean milestone creation.
  • As a non-member, tried to create a milestone. Received appropriate policy error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 7:07 AM
This revision was automatically updated to reflect the committed changes.