When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.

Nov 14 2019, 3:22 AM · Diffusion

epriestley requested review of D20907: Make repository identity email address association case-insensitive.

Nov 14 2019, 3:17 AM

epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20907: Make repository identity email address association case-insensitive.

Nov 14 2019, 3:15 AM · Diffusion

epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.

Nov 14 2019, 3:05 AM · Diffusion

epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

The internal construction with LIKE '%...' is also not great:

Nov 14 2019, 2:47 AM · Diffusion

epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Looking up identities by email address is improperly case-sensitive, because the query is a LIKE query against a binary column.

Nov 14 2019, 2:46 AM · Diffusion

epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Here's a list of bugs I expect exist, although I haven't made it far as reproducing them yet:

Nov 14 2019, 2:41 AM · Diffusion

epriestley added a parent task for T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: T13444: Provide a standalone script entry point for resolving a repository identity.

Nov 14 2019, 2:12 AM · Diffusion

epriestley added a subtask for T13444: Provide a standalone script entry point for resolving a repository identity: T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration.

Nov 14 2019, 2:12 AM · Diffusion

epriestley triaged T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Low priority.

Nov 14 2019, 1:35 AM · Diffusion

epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

We currently have bin/repository rebuild-identities, which takes a list of repository identifiers or --all. This has a lot of history in T12164 and we currently queue an "activity" for it during migrations in 20180809.repo_identities.activity.php.

Nov 14 2019, 1:19 AM · Diffusion

Nov 13 2019

epriestley committed rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits (authored by epriestley).

Surface edits to "Text" panels on dashboards as remarkup edits

Nov 13 2019, 6:35 PM

epriestley closed D20906: Surface edits to "Text" panels on dashboards as remarkup edits.

Nov 13 2019, 6:35 PM

epriestley closed T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Resolved by committing rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.

Nov 13 2019, 6:35 PM · Dashboards, Remarkup

epriestley requested review of D20906: Surface edits to "Text" panels on dashboards as remarkup edits.

Nov 13 2019, 6:33 PM

epriestley added a revision to T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc): D20906: Surface edits to "Text" panels on dashboards as remarkup edits.

Nov 13 2019, 6:32 PM · Dashboards, Remarkup

epriestley triaged T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Low priority.

Nov 13 2019, 6:31 PM · Dashboards, Remarkup

epriestley committed rP2adc36ba0b8d: Correctly identify more SSH private key problems as "formatting" or… (authored by epriestley).

Correctly identify more SSH private key problems as "formatting" or…

Nov 13 2019, 6:22 PM

epriestley closed D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.

Nov 13 2019, 6:22 PM

epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys as Resolved.

I've marked D20905 as resolving this. This isn't really "resolved" completely, but T13454 has a better description of what the problems are and why they're difficult. Our behavior is, at least, substantially better than it was before.

Nov 13 2019, 6:19 PM · Passphrase

epriestley closed T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys, a subtask of T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body, as Resolved.

Nov 13 2019, 6:19 PM · Auth

epriestley requested review of D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.

Nov 13 2019, 6:18 PM

epriestley added a revision to T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.

Nov 13 2019, 6:17 PM · Auth

epriestley added a revision to T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: D20905: Correctly identify more SSH private key problems as "formatting" or "passphrase" related.

Nov 13 2019, 6:17 PM · Passphrase

epriestley added a parent task for T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys: T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body.

Nov 13 2019, 6:12 PM · Passphrase

epriestley added a subtask for T13454: Handle password-protected SSH keys with no "ENCRYPTED" text in the key body: T13006: Passphrase can't distinguish between correct, mangled, and passphrase-encoded SSH keys.