Page MenuHomePhabricator
Feed All Stories

Oct 11 2018

epriestley closed D19744: In "bin/bulk export", require "--output <path>" by default.
Oct 11 2018, 8:35 PM
epriestley committed rP4f54d483d5bf: Support export of revisions to Excel/CSV/JSON/etc (authored by epriestley).
Support export of revisions to Excel/CSV/JSON/etc
Oct 11 2018, 8:34 PM
epriestley closed D19743: Support export of revisions to Excel/CSV/JSON/etc.
Oct 11 2018, 8:34 PM
amckinley accepted D19743: Support export of revisions to Excel/CSV/JSON/etc.
Oct 11 2018, 8:31 PM
amckinley accepted D19744: In "bin/bulk export", require "--output <path>" by default.
Oct 11 2018, 8:29 PM
epriestley requested review of D19744: In "bin/bulk export", require "--output <path>" by default.
Oct 11 2018, 7:40 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: D19744: In "bin/bulk export", require "--output <path>" by default.
Oct 11 2018, 7:38 PM · Plans
ReturnZero added a comment to D19159: Include OAuth targets in "form-action" Content-Security-Policy.

@epriestley Forgive me if you already got a notification about this, but I don't see your name as a subscriber so I wasn't sure if you would see it or not.

Oct 11 2018, 7:37 PM
epriestley requested review of D19743: Support export of revisions to Excel/CSV/JSON/etc.
Oct 11 2018, 3:32 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: D19743: Support export of revisions to Excel/CSV/JSON/etc.
Oct 11 2018, 3:31 PM · Plans
epriestley committed rP4f557ff075ad: When using "bin/bulk export --overwrite", actually overwrite the file (authored by epriestley).
When using "bin/bulk export --overwrite", actually overwrite the file
Oct 11 2018, 3:13 PM
epriestley closed D19739: When using "bin/bulk export --overwrite", actually overwrite the file.
Oct 11 2018, 3:13 PM

Oct 10 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 10 2018, 11:42 PM · Plans, Harbormaster
joshuaspence added a comment to D19740: Fix class attribute node in anonymous class.

@epriestley, would you mind taking a look at this diff?

Oct 10 2018, 11:31 PM
ReturnZero added a comment to D19159: Include OAuth targets in "form-action" Content-Security-Policy.

I just did a fresh install of Phabricator with only Slack OAuth enabled (no password login) and I'm running in to this, it says "Refused to load <url> because it does not appear in the form-action directive of the Content Security Policy." in the console when clicking the Log In or Register button to log in. Interestingly it didn't seem to have trouble registering for an account, but refuses to log in. Same issue on Chrome and in Safari. Restarted apache which didn't seem to make a difference.

Oct 10 2018, 7:50 PM
epriestley requested review of D19742: Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline".
Oct 10 2018, 7:45 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: D19742: Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline".
Oct 10 2018, 7:44 PM · Plans
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I think that workflow is pretty strongly undesirable: it suggests users make an incorrect change (e.g., suggest a patch which violates the style guideline) and they're expected to answer "Y" to it.

Oct 10 2018, 7:30 PM · Restricted Project, Arcanist
jparise added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

One additional perspective on this:

Oct 10 2018, 7:03 PM · Restricted Project, Arcanist
epriestley committed rP4928c34d00c2: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags (authored by epriestley).
Allow "bin/bulk export" to merge multiple queries and accept more flexible flags
Oct 10 2018, 4:14 PM
epriestley closed D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
Oct 10 2018, 4:14 PM
epriestley updated the task description for T13210: Plans: 2018 Week 41-44 Bonus Content.
Oct 10 2018, 4:08 PM · Plans
joshuaspence accepted D19741: Let lint rules support anonymous classes.

Maybe add some comments?

Oct 10 2018, 3:37 AM
wjiang requested review of D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19741: Let lint rules support anonymous classes.
Oct 10 2018, 12:04 AM · XHPAST

Oct 9 2018

amckinley accepted D19739: When using "bin/bulk export --overwrite", actually overwrite the file.
Oct 9 2018, 8:44 PM
amckinley accepted D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
Oct 9 2018, 8:43 PM
urzds added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

See-Also: https://circleci.com/ideas/?idea=CCI-I-430
See-Also: https://discuss.circleci.com/t/webhook-support-removed-from-documentation-still-supported/19984

Oct 9 2018, 10:08 AM · Guides, Harbormaster
joshuaspence accepted D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 3:31 AM
wjiang added a comment to D19740: Fix class attribute node in anonymous class.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Oct 9 2018, 1:47 AM
joshuaspence added a comment to D19740: Fix class attribute node in anonymous class.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Oct 9 2018, 1:43 AM
wjiang updated the test plan for D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM
wjiang requested review of D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19740: Fix class attribute node in anonymous class.
Oct 9 2018, 1:39 AM · XHPAST

Oct 8 2018

joshuaspence committed rPHU603209bb1756: Add support for anonymous class (authored by wjiang).
Add support for anonymous class
Oct 8 2018, 11:39 PM
joshuaspence closed D19736: Add support for anonymous class.
Oct 8 2018, 11:39 PM
joshuaspence added a comment to D19736: Add support for anonymous class.

Automated landing didn't work so I'll do it the old-fashioned way.

Oct 8 2018, 11:35 PM
epriestley triaged T13211: Improve intracluster synchronization routing as Normal priority.
Oct 8 2018, 7:29 PM · Clusters, Diffusion
epriestley requested review of D19739: When using "bin/bulk export --overwrite", actually overwrite the file.
Oct 8 2018, 6:23 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: D19739: When using "bin/bulk export --overwrite", actually overwrite the file.
Oct 8 2018, 6:22 PM · Plans
epriestley updated the diff for D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
  • When the user specifies a bad "--class" like "--class xyz", suggest only engines which support export instead of all engines.
Oct 8 2018, 5:24 PM
epriestley requested review of D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
Oct 8 2018, 5:20 PM
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
Oct 8 2018, 5:19 PM · Plans
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I think this is all done but want to let things run against bastion007 for a bit before I tear down bastion005.

Oct 8 2018, 3:43 PM · Phacility, Ops
epriestley added a revision to T13207: Cycle More AWS Hosts (October 2018): Unknown Object (Differential Revision).
Oct 8 2018, 3:41 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I also needed to copy the old master.key from bastion005 to bastion007 in /core/lib/keystore/.

Oct 8 2018, 3:40 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I turned bastion.phacility.net and bastion-external.phacillity.net into CNAME records and pointed them at the new bastions.

Oct 8 2018, 3:35 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

There's a minor deadlock on bastion deployment with the current scripts: during deploy, we run deploy-key to copy the deploy key from the bastion to the target host during deployment, so that we don't need to put the entire keystore on normal cluster nodes, and so that we don't need to have the keystore on the control host (staff laptop) outside the cluster.

Oct 8 2018, 3:31 PM · Phacility, Ops
epriestley accepted D19736: Add support for anonymous class.
Oct 8 2018, 2:05 PM
joshuaspence accepted D19736: Add support for anonymous class.
Oct 8 2018, 12:54 AM
wjiang added a reviewer for D19736: Add support for anonymous class: thaiphv.
Oct 8 2018, 12:53 AM
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D19736: Add support for anonymous class.
Oct 8 2018, 12:51 AM · XHPAST
wjiang requested review of D19736: Add support for anonymous class.
Oct 8 2018, 12:51 AM

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Oct 6 2018

epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I cycled all the hosts except bastion. saux001 needs to be vetted a bit (it handles "Land Revision" from the web UI) but it isn't critical if it needs a bit more work.

Oct 6 2018, 3:38 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I 'm going to get these underway once the deploy finishes.

Oct 6 2018, 2:45 PM · Phacility, Ops
epriestley edited the content of Changelog.
Oct 6 2018, 1:35 PM
epriestley committed rPHUaae888dfe741: (stable) Promote 2018 Week 40 (authored by epriestley).
(stable) Promote 2018 Week 40
Oct 6 2018, 1:32 PM
epriestley committed rP9e4de100aece: (stable) Promote 2018 Week 40 (authored by epriestley).
(stable) Promote 2018 Week 40
Oct 6 2018, 1:32 PM
epriestley created 2018 Week 40 (Early October).
Oct 6 2018, 1:32 PM

Oct 5 2018

epriestley raised the priority of T13210: Plans: 2018 Week 41-44 Bonus Content from Low to Normal.
Oct 5 2018, 11:19 PM · Plans
epriestley triaged T13210: Plans: 2018 Week 41-44 Bonus Content as Low priority.
Oct 5 2018, 11:19 PM · Plans
epriestley closed T13202: Plans: 2018 Week 38-40 Bonus Content as Resolved.
Oct 5 2018, 11:19 PM · Plans
epriestley requested review of D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Oct 5 2018, 9:02 PM
epriestley added a revision to T13109: Improve cluster write feedback and write routing: D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Oct 5 2018, 9:01 PM · Diffusion
epriestley added a revision to T10884: Sort repository, database and notification services better (by network distance): D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Oct 5 2018, 9:01 PM · Clusters
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Oct 5 2018, 9:01 PM · Plans
epriestley committed rP99034efa8b8d: Make Pholio mail render without a ton of over-escaped HTML (authored by epriestley).
Make Pholio mail render without a ton of over-escaped HTML
Oct 5 2018, 8:37 PM
epriestley closed D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:37 PM
epriestley closed T12814: pholio transaction emails have too much html as Resolved by committing rP99034efa8b8d: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:37 PM · Pholio, Transactions, Bug Report
epriestley requested review of D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Oct 5 2018, 8:37 PM
epriestley added a revision to T13109: Improve cluster write feedback and write routing: D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Oct 5 2018, 8:35 PM · Diffusion
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Oct 5 2018, 8:35 PM · Plans
epriestley added inline comments to D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:17 PM
amckinley accepted D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:08 PM
Harbormaster failed to build B20993: rARCbd5884022022: Fix two issues with the Java syntax highlighter lexer for rARCbd5884022022: Fix two issues with the Java syntax highlighter lexer!
Oct 5 2018, 7:32 PM
epriestley committed rARCbd5884022022: Fix two issues with the Java syntax highlighter lexer (authored by epriestley).
Fix two issues with the Java syntax highlighter lexer
Oct 5 2018, 7:32 PM
epriestley committed rPHUc6a6853ff8ae: Fix two issues with the Java syntax highlighter lexer (authored by epriestley).
Fix two issues with the Java syntax highlighter lexer
Oct 5 2018, 7:30 PM
epriestley closed D19731: Fix two issues with the Java syntax highlighter lexer.
Oct 5 2018, 7:29 PM
epriestley committed rPc6c1893dc0be: Allow revisions to be filtered by created date (authored by epriestley).
Allow revisions to be filtered by created date
Oct 5 2018, 7:28 PM
epriestley closed D19732: Allow revisions to be filtered by created date.
Oct 5 2018, 7:28 PM
epriestley added a comment to D19731: Fix two issues with the Java syntax highlighter lexer.

(I'm also going to pick this to arcanist/wilds, but may stop picking everything individually in favor of some future "all remaining changes" change at some date in the future depending on how things go.)

Oct 5 2018, 7:27 PM
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 5 2018, 7:23 PM · Plans
epriestley requested review of D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 6:44 PM
epriestley added a revision to T12814: pholio transaction emails have too much html: D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 6:43 PM · Pholio, Transactions, Bug Report
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 6:43 PM · Plans
amckinley accepted D19732: Allow revisions to be filtered by created date.
Oct 5 2018, 6:17 PM
epriestley requested review of D19732: Allow revisions to be filtered by created date.
Oct 5 2018, 6:15 PM
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: D19732: Allow revisions to be filtered by created date.
Oct 5 2018, 6:14 PM · Plans
amckinley accepted D19731: Fix two issues with the Java syntax highlighter lexer.
Oct 5 2018, 6:11 PM
epriestley requested review of D19731: Fix two issues with the Java syntax highlighter lexer.
Oct 5 2018, 5:52 PM
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 5 2018, 5:52 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: D19731: Fix two issues with the Java syntax highlighter lexer.
Oct 5 2018, 5:52 PM · Plans
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

For now, I just hard-wiped the cache and regenerated the documentation again. ¯\_(ツ)_/¯

Oct 5 2018, 4:15 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The file cache says that these files have already been parsed and contain no atoms, so the rest of the program behavior is expected after that. I'm not sure how this state came to exist.

Oct 5 2018, 4:03 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
  • DivinerPublisher->publishAtoms() is being passed nothing, so it's correctly deleting everything.
  • The graph cache is empty.
  • The actual atom.cache file on disk is empty.
  • The input to the cache is empty.
  • The files aren't being passed to the atomizer rules (although the rules appear to be applying correctly).
Oct 5 2018, 3:36 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

So, so far it looks like the database is in a "good" state but the publish workflow incorrectly deleted all the articles. From previous efforts, I believe dropping the cache fixes this issue.

Oct 5 2018, 3:26 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

But note that the graphHash and nodeHash columns are 0, which I believe is a signal that these nodes have been deleted (I haven't touched this code in a while).

Oct 5 2018, 3:21 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

Oh, the contrib stuff got separated into a different book and has fully unpublished:

Oct 5 2018, 1:27 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The "Contributor Introduction" document, specifically, seems to have unpublished. Let me see what I can dig up about the current database state.

Oct 5 2018, 1:14 PM · Diviner