Page MenuHomePhabricator
Feed All Stories

Oct 4 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 4 2018, 10:45 PM · Plans
20after4 awarded rARC8e0e07664a83: [Wilds] Remove libphutil a Party Time token.
Oct 4 2018, 4:31 PM
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

"Yes", but post- T13098.

Oct 4 2018, 1:46 PM · Arcanist
joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

@epriestley, would you be open to making the chunk size configurable? Changing the chunk size from 32 to 512 reduced the amount of time required for us to lint ~1500 TypeScript files from 370 seconds to 66 seconds.

Oct 4 2018, 3:00 AM · Arcanist
joshuaspence abandoned D17350: Allow external linters to operate on multiple paths in batches.

I can just do this with D19730 instead.

Oct 4 2018, 12:18 AM

Oct 3 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 3:15 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 2:54 PM · Plans
epriestley renamed T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Replace arc.bat with something better to Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]".
Oct 3 2018, 2:52 PM · Arcanist, Windows
Harbormaster failed to build B20986: rARCfa27ad761aa0: [Wilds] Stop writing temporary files for linter tests for rARCfa27ad761aa0: [Wilds] Stop writing temporary files for linter tests!
Oct 3 2018, 2:50 PM
Harbormaster failed to build B20985: rARC79d3692f6612: [Wilds] Pass or skip all remaining Windows unit test failures for rARC79d3692f6612: [Wilds] Pass or skip all remaining Windows unit test failures!
Oct 3 2018, 2:50 PM
Harbormaster failed to build B20984: rARC9ac0b69798c6: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows for rARC9ac0b69798c6: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows!
Oct 3 2018, 2:50 PM
Harbormaster failed to build B20982: rARC0140a0e99000: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell" for rARC0140a0e99000: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell"!
Oct 3 2018, 2:50 PM
Harbormaster failed to build B20983: rARCb1921850452c: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate… for rARCb1921850452c: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate…!
Oct 3 2018, 2:50 PM
Harbormaster failed to build B20981: rARC5a4c489916e8: [Wilds] Use "random_bytes()" if it is available (after PHP7) for rARC5a4c489916e8: [Wilds] Use "random_bytes()" if it is available (after PHP7)!
Oct 3 2018, 2:49 PM
epriestley committed rARCfa27ad761aa0: [Wilds] Stop writing temporary files for linter tests (authored by epriestley).
[Wilds] Stop writing temporary files for linter tests
Oct 3 2018, 2:49 PM
epriestley committed rARC79d3692f6612: [Wilds] Pass or skip all remaining Windows unit test failures (authored by epriestley).
[Wilds] Pass or skip all remaining Windows unit test failures
Oct 3 2018, 2:49 PM
epriestley committed rARC9ac0b69798c6: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows (authored by epriestley).
[Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows
Oct 3 2018, 2:49 PM
epriestley committed rARCb1921850452c: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate… (authored by epriestley).
[Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate…
Oct 3 2018, 2:49 PM
epriestley committed rARC5a4c489916e8: [Wilds] Use "random_bytes()" if it is available (after PHP7) (authored by epriestley).
[Wilds] Use "random_bytes()" if it is available (after PHP7)
Oct 3 2018, 2:49 PM
epriestley committed rARC0140a0e99000: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell" (authored by epriestley).
[Wilds] On Windows: always use stdout/stderr files and always "bypass_shell"
Oct 3 2018, 2:49 PM
epriestley closed D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 3 2018, 2:49 PM
epriestley closed D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 3 2018, 2:49 PM
epriestley closed D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 3 2018, 2:49 PM
epriestley closed D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 3 2018, 2:49 PM
epriestley closed D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 3 2018, 2:49 PM
epriestley closed D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 3 2018, 2:49 PM
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 1:30 AM · Plans

Oct 2 2018

amckinley accepted D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 10:47 PM
amckinley accepted D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 2 2018, 7:56 PM
amckinley accepted D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 7:34 PM
amckinley accepted D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 7:20 PM
amckinley accepted D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 2 2018, 7:18 PM
epriestley added inline comments to D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 2 2018, 7:03 PM
amckinley accepted D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.

noidea

Oct 2 2018, 7:00 PM
epriestley added inline comments to D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 6:43 PM
Harbormaster failed remote builds in B20980: Diff 47139 for D19729: [Wilds] Pass or skip all remaining Windows unit test failures!
Oct 2 2018, 6:38 PM
epriestley requested review of D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 6:38 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 6:38 PM · Arcanist, Windows
Harbormaster failed remote builds in B20979: Diff 47138 for D19728: [Wilds] Stop writing temporary files for linter tests!
Oct 2 2018, 6:35 PM
epriestley requested review of D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 2 2018, 6:35 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 2 2018, 6:35 PM · Arcanist, Windows
epriestley added inline comments to D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 6:30 PM
Harbormaster failed remote builds in B20978: Diff 47137 for D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell"!
Oct 2 2018, 6:26 PM
epriestley requested review of D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 6:26 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 6:25 PM · Arcanist, Windows
epriestley added inline comments to D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 6:11 PM
epriestley updated the diff for D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
  • More correct fix for error message.
Oct 2 2018, 6:09 PM
epriestley requested review of D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 6:08 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 6:08 PM · Arcanist, Windows
epriestley requested review of D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 2 2018, 6:04 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 2 2018, 5:57 PM · Arcanist, Windows
epriestley added inline comments to D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 2 2018, 5:52 PM
epriestley updated the diff for D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
  • With context.
Oct 2 2018, 5:51 PM
Harbormaster failed remote builds in B20975: Diff 47132 for D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges!
Oct 2 2018, 5:51 PM
epriestley requested review of D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 2 2018, 5:51 PM
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 2 2018, 5:51 PM · Arcanist, Windows
Harbormaster failed to build B20974: rARCb6ab24b5dacf: Improve some relatively obscure Unicode behavior under Windows. for rARCb6ab24b5dacf: Improve some relatively obscure Unicode behavior under Windows.!
Oct 2 2018, 5:21 PM
epriestley committed rARCb6ab24b5dacf: Improve some relatively obscure Unicode behavior under Windows. (authored by epriestley).
Improve some relatively obscure Unicode behavior under Windows.
Oct 2 2018, 5:21 PM
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

In retrospect, I should have rigged the hash for the the "Remove libphutil" commit to have some cool recognizable prefix like de1e7ed, since half of arcanist/ now ends up there on git blame.

Oct 2 2018, 5:05 PM · Arcanist, Plans
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Also, guess what this checkbox does on Windows 10?

Oct 2 2018, 4:57 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Consider this script:

Oct 2 2018, 4:56 PM · Arcanist, Windows
Harbormaster failed to build B20973: rARCeb57e9d7f607: Skip Phage tests under Windows since they seem a little ambitious. for rARCeb57e9d7f607: Skip Phage tests under Windows since they seem a little ambitious.!
Oct 2 2018, 4:27 PM
epriestley committed rARCeb57e9d7f607: Skip Phage tests under Windows since they seem a little ambitious. (authored by epriestley).
Skip Phage tests under Windows since they seem a little ambitious.
Oct 2 2018, 4:27 PM
Harbormaster failed to build B20972: rARCcf982254bb91: Remove a questionable Filesystem test case and fully normalize the EditorConfig… for rARCcf982254bb91: Remove a questionable Filesystem test case and fully normalize the EditorConfig…!
Oct 2 2018, 4:21 PM
epriestley committed rARCcf982254bb91: Remove a questionable Filesystem test case and fully normalize the EditorConfig… (authored by epriestley).
Remove a questionable Filesystem test case and fully normalize the EditorConfig…
Oct 2 2018, 4:21 PM
Harbormaster failed to build B20971: rARC9d57a343ab58: Normalize ".editorconfig" paths to use "/" as a directory separator. for rARC9d57a343ab58: Normalize ".editorconfig" paths to use "/" as a directory separator.!
Oct 2 2018, 4:15 PM
epriestley committed rARC9d57a343ab58: Normalize ".editorconfig" paths to use "/" as a directory separator. (authored by epriestley).
Normalize ".editorconfig" paths to use "/" as a directory separator.
Oct 2 2018, 4:14 PM
Harbormaster failed to build B20970: rARC679bccbd1f04: Flavor to taste with backslashes. for rARC679bccbd1f04: Flavor to taste with backslashes.!
Oct 2 2018, 4:09 PM
epriestley committed rARC679bccbd1f04: Flavor to taste with backslashes. (authored by epriestley).
Flavor to taste with backslashes.
Oct 2 2018, 4:08 PM
Harbormaster failed to build B20969: rARCaca8f3a4a198: In Filesystem::resolvePath(), normalize directory separators even for fictional… for rARCaca8f3a4a198: In Filesystem::resolvePath(), normalize directory separators even for fictional…!
Oct 2 2018, 4:07 PM
epriestley committed rARCaca8f3a4a198: In Filesystem::resolvePath(), normalize directory separators even for fictional… (authored by epriestley).
In Filesystem::resolvePath(), normalize directory separators even for fictional…
Oct 2 2018, 4:07 PM
Harbormaster failed to build B20968: rARC05c958106b2e: Skip this test entirely on Windows since we can't write files with "*" in their… for rARC05c958106b2e: Skip this test entirely on Windows since we can't write files with "*" in their…!
Oct 2 2018, 3:54 PM
epriestley committed rARC05c958106b2e: Skip this test entirely on Windows since we can't write files with "*" in their… (authored by epriestley).
Skip this test entirely on Windows since we can't write files with "*" in their…
Oct 2 2018, 3:53 PM
Harbormaster failed to build B20967: rARCc6312d88f123: Use walkToRoot() to (probably?) make the EditorConfig test cases pass on… for rARCc6312d88f123: Use walkToRoot() to (probably?) make the EditorConfig test cases pass on…!
Oct 2 2018, 3:45 PM
epriestley committed rARCc6312d88f123: Use walkToRoot() to (probably?) make the EditorConfig test cases pass on… (authored by epriestley).
Use walkToRoot() to (probably?) make the EditorConfig test cases pass on…
Oct 2 2018, 3:45 PM
Harbormaster failed to build B20966: rARCcb53d78107b9: Normalize "/" vs "\" path expectations in a walkToRoot() test case. for rARCcb53d78107b9: Normalize "/" vs "\" path expectations in a walkToRoot() test case.!
Oct 2 2018, 3:41 PM
Harbormaster failed to build B20965: rARC137c1c8aab05: Don't run a test which relies on writing a file with literal backslashes in its… for rARC137c1c8aab05: Don't run a test which relies on writing a file with literal backslashes in its…!
Oct 2 2018, 3:41 PM
epriestley committed rARC137c1c8aab05: Don't run a test which relies on writing a file with literal backslashes in its… (authored by epriestley).
Don't run a test which relies on writing a file with literal backslashes in its…
Oct 2 2018, 3:41 PM
epriestley committed rARCcb53d78107b9: Normalize "/" vs "\" path expectations in a walkToRoot() test case. (authored by epriestley).
Normalize "/" vs "\" path expectations in a walkToRoot() test case.
Oct 2 2018, 3:41 PM
Harbormaster failed to build B20964: rARC07d93f7a9c8f: Throw CommandException, not Exception, when proc_open() fails so that Windows… for rARC07d93f7a9c8f: Throw CommandException, not Exception, when proc_open() fails so that Windows…!
Oct 2 2018, 3:31 PM
Harbormaster failed to build B20963: rARCd763e295d091: Correct an outdated comment about stream_select(). for rARCd763e295d091: Correct an outdated comment about stream_select().!
Oct 2 2018, 3:31 PM
epriestley committed rARC07d93f7a9c8f: Throw CommandException, not Exception, when proc_open() fails so that Windows… (authored by epriestley).
Throw CommandException, not Exception, when proc_open() fails so that Windows…
Oct 2 2018, 3:31 PM
epriestley committed rARCd763e295d091: Correct an outdated comment about stream_select(). (authored by epriestley).
Correct an outdated comment about stream_select().
Oct 2 2018, 3:31 PM
Harbormaster failed to build B20962: rARC33d1d044f4f3: Really, truly cache binary availability. for rARC33d1d044f4f3: Really, truly cache binary availability.!
Oct 2 2018, 3:11 PM
epriestley committed rARC33d1d044f4f3: Really, truly cache binary availability. (authored by epriestley).
Really, truly cache binary availability.
Oct 2 2018, 3:11 PM
Harbormaster failed to build B20961: rARCe541ac5e8cbb: Actually cache the availability of binaries properly. for rARCe541ac5e8cbb: Actually cache the availability of binaries properly.!
Oct 2 2018, 3:07 PM
epriestley committed rARCe541ac5e8cbb: Actually cache the availability of binaries properly. (authored by epriestley).
Actually cache the availability of binaries properly.
Oct 2 2018, 3:07 PM
Harbormaster failed to build B20960: rARC75da75a97cf5: Use a support "sleep" instead of a shell builtin and skip another XHPAST test. for rARC75da75a97cf5: Use a support "sleep" instead of a shell builtin and skip another XHPAST test.!
Oct 2 2018, 3:05 PM
epriestley committed rARC75da75a97cf5: Use a support "sleep" instead of a shell builtin and skip another XHPAST test. (authored by epriestley).
Use a support "sleep" instead of a shell builtin and skip another XHPAST test.
Oct 2 2018, 3:05 PM
Harbormaster failed to build B20959: rARCe693296c6452: Require "diff" for another test which relies on it. for rARCe693296c6452: Require "diff" for another test which relies on it.!
Oct 2 2018, 1:24 PM
Harbormaster failed to build B20958: rARC13ec74f153ff: Continue restructuring subprocess support unit tests for Windows. for rARC13ec74f153ff: Continue restructuring subprocess support unit tests for Windows.!
Oct 2 2018, 1:24 PM
Harbormaster failed to build B20957: rARCe1f75084d122: Skip a test which makes no assertions on Windows. for rARCe1f75084d122: Skip a test which makes no assertions on Windows.!
Oct 2 2018, 1:24 PM
epriestley committed rARCe693296c6452: Require "diff" for another test which relies on it. (authored by epriestley).
Require "diff" for another test which relies on it.
Oct 2 2018, 1:24 PM
epriestley committed rARC13ec74f153ff: Continue restructuring subprocess support unit tests for Windows. (authored by epriestley).
Continue restructuring subprocess support unit tests for Windows.
Oct 2 2018, 1:24 PM
epriestley committed rARCe1f75084d122: Skip a test which makes no assertions on Windows. (authored by epriestley).
Skip a test which makes no assertions on Windows.
Oct 2 2018, 1:24 PM
epriestley lowered the priority of T2465: Context not available for revisions created on Windows from High to Low.
Oct 2 2018, 1:05 PM · Windows, Subversion, Arcanist
epriestley moved T9441: Cygwin PHP segfaults with arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:05 PM · Windows, Arcanist
epriestley moved T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:03 PM · Arcanist, Windows
epriestley renamed T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD") from arc patch fails on Windows with SVN to arc patch fails on Windows with SVN (because it uses "cd", not "setCWD").
Oct 2 2018, 1:03 PM · Windows, Arcanist
epriestley moved T8855: Add Powershell support to Arcanist documentation from Backlog to Powershell on the Windows board.
Oct 2 2018, 1:01 PM · Windows, Arcanist