Page MenuHomePhabricator

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"
ClosedPublic

Authored by epriestley on Oct 10 2018, 7:44 PM.
Tags
None
Referenced Files
F18568550: D19742.id47171.diff
Wed, Sep 10, 12:14 AM
F18568549: D19742.id47165.diff
Wed, Sep 10, 12:14 AM
F18509869: D19742.id.diff
Fri, Sep 5, 3:39 AM
F18503388: D19742.diff
Thu, Sep 4, 11:03 PM
F18429949: D19742.id.diff
Sun, Aug 31, 3:32 AM
F18414304: D19742.diff
Sat, Aug 30, 8:26 AM
F18205387: D19742.id47171.diff
Mon, Aug 18, 2:46 PM
F18095153: D19742.id.diff
Aug 7 2025, 10:32 PM
Subscribers
None

Details

Summary

See PHI920. Ref T13210. Since the HTML is just:

<a>View Inline</a><span>filename.txt</span>

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a <div>?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan
  • Made an inline.
  • Used bin/mail show-outbound --id ... --dump-html to dump the HTML.
  • Double-clicked the filename.

Screen Shot 2018-10-10 at 12.40.39 PM.png (956×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable