Page MenuHomePhabricator

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"
ClosedPublic

Authored by epriestley on Oct 10 2018, 7:44 PM.

Details

Summary

See PHI920. Ref T13210. Since the HTML is just:

<a>View Inline</a><span>filename.txt</span>

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a <div>?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan
  • Made an inline.
  • Used bin/mail show-outbound --id ... --dump-html to dump the HTML.
  • Double-clicked the filename.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 10 2018, 7:44 PM
epriestley requested review of this revision.Oct 10 2018, 7:45 PM
amckinley accepted this revision.Oct 11 2018, 8:42 PM
This revision is now accepted and ready to land.Oct 11 2018, 8:42 PM
This revision was automatically updated to reflect the committed changes.