Page MenuHomePhabricator

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"
ClosedPublic

Authored by epriestley on Oct 10 2018, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 4:51 AM
Unknown Object (File)
Sun, Dec 15, 2:14 AM
Unknown Object (File)
Thu, Dec 12, 6:14 AM
Unknown Object (File)
Thu, Dec 12, 3:54 AM
Unknown Object (File)
Dec 9 2024, 5:08 PM
Unknown Object (File)
Dec 7 2024, 3:23 PM
Unknown Object (File)
Dec 4 2024, 9:53 PM
Subscribers
None

Details

Summary

See PHI920. Ref T13210. Since the HTML is just:

<a>View Inline</a><span>filename.txt</span>

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a <div>?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan
  • Made an inline.
  • Used bin/mail show-outbound --id ... --dump-html to dump the HTML.
  • Double-clicked the filename.

Screen Shot 2018-10-10 at 12.40.39 PM.png (956×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable