Page MenuHomePhabricator

Allow "bin/bulk export" to merge multiple queries and accept more flexible flags

Authored by epriestley on Oct 8 2018, 5:19 PM.



Ref T13210. Minor usability improvements to "bin/bulk export":

  • Allow --class task to work (previously, only --class ManiphestTaskSearchEngine worked).
  • If you run --query jXIlzQyOYHPU, don't require --class, since the query identifies the class on its own.
  • Allow users to call --query A --query B --query C and get a union of all results.
Test Plan
  • Ran --class task, --query A --query B, --query X (with no --class), got good results.
  • Ran various flavors of bad combinations (queries from different engines, invalid engines, query and class differing, ambiguous/invalid --class name) and got sensible errors.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 8 2018, 5:19 PM
epriestley requested review of this revision.Oct 8 2018, 5:20 PM
epriestley updated this revision to Diff 47159.Oct 8 2018, 5:24 PM
  • When the user specifies a bad "--class" like "--class xyz", suggest only engines which support export instead of all engines.
amckinley accepted this revision.Oct 9 2018, 8:43 PM
This revision is now accepted and ready to land.Oct 9 2018, 8:43 PM
This revision was automatically updated to reflect the committed changes.