Page MenuHomePhabricator

In "bin/bulk export", require "--output <path>" by default
ClosedPublic

Authored by epriestley on Oct 11 2018, 7:38 PM.

Details

Summary

Depends on D19743. Ref T13210. Since this command can easily dump a bunch of binary data (or just a huge long blob of nonsense) to stdout, default to requiring "--output <file>".

Using --output - will print to stdout.

Test Plan

Ran with: no --output, --output file, --output -, --output - --overwrite. Got sensible results or errors in all cases.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 11 2018, 7:38 PM
epriestley requested review of this revision.Oct 11 2018, 7:40 PM
amckinley accepted this revision.Oct 11 2018, 8:29 PM
This revision is now accepted and ready to land.Oct 11 2018, 8:29 PM
This revision was automatically updated to reflect the committed changes.